Newbie member with code problem

[kathanon]

Hi I am new to php, but have inherited what is turning out to be a quite complicated website to maintain.

It isn't very fully commented and I need to make some changes but don't really understand all of the code.

I am hoping it is ok to just post the code here. I don't want to just go ahead and dump a whole lot of code without checking it is ok.

The code is for a search of mysql, the problem is that it will only search on one keyword, not two. Before I think it may have been set up to search on more than one, but it gave multiple duplicate results. I am hoping that there is a way to allow searching on multiple keywords but to only return one instance of each result.

Many thanks, I will post it as soon as I hear back from anyone that it is ok to post long bits of code (about 94 lines I think)

Many thanks

Kathy

[TheDefender]

Post the applicable code (such as the query code)... Well, actually, 94 would be a fairly small amount of code compared to some others. Go ahead and post the code.

[kathanon]

Thanks, here is the code, I am not sure if the commented parts are what used to search on multiple keys, am still finding my way around with this.

<?php require_once('../isa/isa.php'); ?>

<?php
$editFormAction = $HTTP_SERVER_VARS['PHP_SELF'];
/if (isset($HTTP_SERVER_VARS['QUERY_STRING'])) {
$editFormAction .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];
}/

mysql_select_db($database_isa, $isa);

if(isset($HTTP_POST_VARS['searchme']) ) { // true if search has been submitted
if ($HTTP_POST_VARS['keys'] == "") {
$Criteria = "";
} else {
$Criteria = " AND ((k.key_word LIKE '%".$HTTP_POST_VARS['keys']."%')";
$Criteria .= " OR (i.img_desc LIKE '%".$HTTP_POST_VARS['keys']."%')";
$Criteria .= " OR (i.img_title LIKE '%".$HTTP_POST_VARS['keys']."%'))";
}
if ($HTTP_POST_VARS['img_category'] <> "999") { //search a specific category
$Criteria .= " AND k.key_word=".GetSQLValueString($HTTP_POST_VARS['img_category'], "text")." ";
}

    $FromDate = $HTTP_POST_VARS['year']."-".$HTTP_POST_VARS['mth']."-".$HTTP_POST_VARS['day']." 00:00:00";
    $ToDate = $HTTP_POST_VARS['toyear']."-".$HTTP_POST_VARS['tomth']."-".$HTTP_POST_VARS['today']." 23:59:59";
    $Criteria .= " AND i.img_taken BETWEEN ".GetSQLValueString($FromDate, "date")." AND ".GetSQLValueString($ToDate, "date")." ";

    $Orderby = " ORDER BY img_taken DESC";

switch ($HTTP_POST_VARS['orderby']) {
case "alph":
$Orderby = " ORDER BY img_title";
break;
case "prec":
$Orderby = " ORDER BY img_created DESC";
break;
case "olde":
$Orderby = " ORDER BY img_created ASC";
break;
}
$query_imgs = sprintf("SELECT DISTINCT (i.img_ID), i.img_ID, i.img_title, i.img_file, i.img_taken, i.img_type FROM images i, keywords k, keylinks l WHERE k.key_ID=l.key_ID AND i.img_ID=l.item_ID AND i.img_archive='0' %s %s", $Criteria, $Orderby);
//echo $query_imgs; //$query_limit_obs = sprintf("%s LIMIT 0, 10", $query_obs);
} else {
$query_imgs = "SELECT FROM images WHERE img_archive='0' ORDER BY img_created DESC";
}
/$query_limit_imgs = sprintf("%s LIMIT 0, 8", $query_imgs);
$imgs = mysql_query($query_limit_imgs, $isa) or die(mysql_error());
$total_imgs = mysql_num_rows($imgs);
$row_imgs = mysql_fetch_assoc($imgs);*/
$currentPage = $HTTP_SERVER_VARS["PHP_SELF"];

$maxRows_imgs = 8;
$pageNum_imgs = 0;
if (isset($HTTP_GET_VARS['pageNum_imgs'])) {
$pageNum_imgs = $HTTP_GET_VARS['pageNum_imgs'];
}
$startRow_imgs = $pageNum_imgs * $maxRows_imgs;

//$query_imgs = "SELECT * FROM images WHERE img_archive <> '0' ORDER BY img_created DESC";
$query_limit_imgs = sprintf("%s LIMIT %d, %d", $query_imgs, $startRow_imgs, $maxRows_imgs);
$imgs = mysql_query($query_limit_imgs, $isa) or die(mysql_error());
$row_imgs = mysql_fetch_assoc($imgs);
//if (isset($HTTP_GET_VARS['totalRows_imgs'])) {
// $totalRows_imgs = $HTTP_GET_VARS['totalRows_imgs'];
//} else {
$totalRows_imgs = mysql_num_rows($imgs);
//}

$all_imgs = mysql_query($query_imgs, $isa) or die(mysql_error());
$allRows_imgs = mysql_num_rows($all_imgs);
mysql_free_result($all_imgs);

$totalPages_imgs = ceil($allRows_imgs/$maxRows_imgs)-1;

$queryString_imgs = "";
if (!empty($HTTP_SERVER_VARS['QUERY_STRING'])) {
$params = explode("&", $HTTP_SERVER_VARS['QUERY_STRING']);
$newParams = array();
foreach ($params as $param) {
if (stristr($param, "pageNum_imgs") == false &&
stristr($param, "totalRows_imgs") == false) {
array_push($newParams, $param);
}
}
if (count($newParams) != 0) {
$queryString_imgs = "&" . implode("&", $newParams);
}
}
$queryString_imgs = sprintf("&totalRows_imgs=%d%s", $totalRows_imgs, $queryString_imgs);
?>