Delete checkbox not working in IE but works in Firefox?

etrooper

Hi all,

Just a quick question...

Does anybody know why M$ IE will not let me delete a listing with a checkbox, where it works fine with Mozilla firefox?

Here is the code:

if ($remove) {

// code to delete by checkbox

if (isset($_POST['remove']) && isset($_POST['id']) && is_array($_POST['id'])) {

    foreach ($_POST['id'] as $id) {

    		$sql = "DELETE FROM usedcars WHERE id= '$id'";	

		$result = mysql_query($sql);

    		if (!$result) {
    			echo "<P class=header>Something is wrong, the selected items were not deleted</P>"; }


		} }



	else {

		echo "<P class=header>You did not check any items to delete</P>";


}

if ($result) {

			echo "<P class=header>Selected item/s Deleted</P>"; }

}

Here is the relevant part of the table where the check box is located, I wont paste the whole table as it is long, but here is the checkbox selection and the submit part:

<td><P class=header><input type="checkbox" name="id[]" value='<?php echo $myrow['id'] ?>'</P></td>

and

<P class=header><input type="Image" src="button_empty.png" name="remove"  value="Delete selected"></P>

Can anybody suggest what might be wrong?

Thanks

BSTRhino

I doubt its something to do with your PHP code, that is probably working fine.

In your <FORM> tag did you remember to write method="POST"?

That was a well written post, giving us the relevant bits, it's very helpful for us to help you. But, could you explain more about what you mean by "will not let me"?

Also, this is not really related to what you want, but you will find your page would be more efficient if you merged it into just one query:

$selectSQL = 'SELECT * FROM yourtable WHERE id IN (' . implode($_POST['id'], ',') . ')';
$deleteSQL = 'DELETE FROM yourtable WHERE id IN (' . implode($_POST['id'], ',') . ')';

Using the IN function you can specify multiple ids to select/update or delete in a query. And having one query will be faster than having multiple. Hopefully this will improve the performance of your page.

MarkR

Dunno about your IE problem.

But you DEFINITELY want to check that the ids are integers in your delete function, otherwise you will have a SQL injection vulnerability.

Mark

etrooper

Thanks for the reply.

What I mean by "it wont let me..." is in IE the listing does not get deleted after you click on a checkbox and then click the delete icon (button_empty.png), infact nothing happens in IE.

In firefox it all goes as expected, you check a checkbox then click on the delete icon and it comes up saying "thankyou, item deleted" and on subsequent refresh of page listing is indeed gone.