move_uploaded_file & <input type=\"text

[PRSBOY]

Hey again, i have another two problems that i cant work out, they are:

i have a page that checks something, and depending on what it is, it moves it to a folder, BUT, i want one item to get moved into two folders, i have this:

if($ann == "item")
move_uploaded_file($tmpname, "images/$id.jpg");
move_uploaded_file($tmpname, "$def/$id.jpg");

but that only copies it to "images/$id.jpg"

i dont know what to do 🙁

---

my other problem is this:

tr("Image", "<input type=\"text\" class=\"input\" name=\"image\" value=\"" . htmlspecialchars($row["image"]) . "\" size=\"80\" />", 1);

it brings up the image link, i can change it, but when it comes to clicking "edit" (where is saves the changed) it just refreshes as normal but hasnt made the changed.

i also dont know whats going wrong with thing 🙁

any help would be greatly apreciated 🙂

[gufmn]

For your first question, is this the actual code? You might want to put some {}s around your if statement.

Second question, need to see some more code. How are you capturing/displaying the information?

[PRSBOY]

the {}'s dont work (they make no difference).

---

the data is from a table in the mysql and its all working fine apart from the saving part :\

[gufmn]

Need to see more code. Show us the full if statement with the {}s as well as your sql update statement and anything else that might help. All I see is your <input> tag. I don't see your <form> tag. Are you using POST, GET? How are you handling the POST/GET data once it's sent?

[PRSBOY]

i got the first problem sorted:

if($ann == "item"){
copy($tmpname, "images/$id.jpg"); 
move_uploaded_file($tmpname, "$def/$id.jpg");
};

move_uploaded_file($tmpname, "$def/$id.jpg");

as for the second question here is the code:

<?

require_once("inc.php");

if (!mkglobal("id"))
    die();

$id = 0 + $id;
if (!$id)
    die();

dbconn();

loggedinorreturn();

$res = mysql_query("SELECT * FROM picture WHERE id = $id");
$row = mysql_fetch_array($res);
if (!$row)
    die();

stdhead("Edit Picture \"" . $row["name"] . "\"");

if (!isset($CURUSER) || ($CURUSER["id"] != $row["owner"] && $CURUSER["admin"] != "yes")) {
    print("<center><font size=3>Can't edit this Picture</font><BR></center>\n");
    print("<p><center>You're not the rightful owner, or you're not <a href=\"login.php?returnto=" . urlencode($_SERVER["REQUEST_URI"]) . "&nowarn=1\">logged in</a> properly.</center></p>\n");
}
else {
    print("<form method=\"post\" action=\"takeedit.php\">\n");
    print("<input type=\"hidden\" name=\"id\" value=\"$id\">\n");
    if (isset($_GET["returnto"]))
        print("<input type=\"hidden\" name=\"returnto\" value=\"" . htmlspecialchars($_GET["returnto"]) . "\" />\n");
    print("<table width=\"650\" class=\"table1\" border=\"1\" cellspacing=\"0\" cellpadding=\"2\">\n");
    tr("Picture name", "<input type=\"text\" class=\"input\" name=\"name\" value=\"" . htmlspecialchars($row["name"]) . "\" size=\"80\" />", 1);
    tr("Picture URL", "<input type=\"text\" class=\"input\" name=\"image\" value=\"" . htmlspecialchars($row["image"]) . "\" size=\"80\" />", 1);
    tr("Description<br />(no html allowed)", "<textarea name=\"descr\" class=\"input\" rows=\"10\" cols=\"60\">" . htmlspecialchars($row["ori_descr"]) . "</textarea>", 1);

$s = "<select name=\"type\">\n";

$cats = genrelist();
foreach ($cats as $subrow) {
    $s .= "<option value=\"" . $subrow["id"] . "\"";
    if ($subrow["id"] == $row["category"])
        $s .= " selected=\"selected\"";
    $s .= ">" . htmlspecialchars($subrow["name"]) . "</option>\n";
}

$s .= "</select>\n";
tr("Type", $s, 1);
tr("Visible", "<input type=\"checkbox\" name=\"visible\"" . (($row["visible"] == "yes") ? " checked=\"checked\"" : "" ) . " value=\"1\" /> Visible on main page<br />", 1);

if ($CURUSER["admin"] == "yes")
    tr("Banned", "<input type=\"checkbox\" name=\"banned\"" . (($row["banned"] == "yes") ? " checked=\"checked\"" : "" ) . " value=\"1\" /> Banned", 1);

print("<tr><td colspan=\"2\" align=\"center\"><input type=\"submit\" value=\"Edit it!\" /> <input type=\"reset\" value=\"Revert changes\"></td></tr>\n");
print("</table>\n");
print("</form>\n");
print("<p>\n");
print("<form method=\"post\" action=\"delete.php\">\n");
print("<input type=\"hidden\" name=\"id\" value=\"$id\">\n");
if (isset($_GET["returnto"]))
    print("<input type=\"hidden\" name=\"returnto\" value=\"" . htmlspecialchars($_GET["returnto"]) . "\" />\n");
print("Don't edit it, but <input type=\"submit\" value=\"delete it!\" />\n");
print("(Yes I'm sure about that: <input type=\"checkbox\" name=\"sure\" value=\"1\" /> )\n");
print("</form>\n");
print("</p>\n");
}

stdfoot();

?>

[gufmn]

the data is from a table in the mysql and its all working fine apart from the saving part :\

If you are trying to save changes to an entry in the db, you will need to have an update statement which I don't see in your code. You didn't specify the name of the file where this code resides. Is it posting to itself?

[PRSBOY]

how comes it saves the name and details without an update statment?

(not questioning you, just wondering)

[gufmn]

Originally posted by PRSBOY
how comes it saves the name and details without an update statment?

(not questioning you, just wondering)

I couldn't tell you since the only sql statement I see is "SELECT * from". That's not saving anything. How are you saving the information you say it's is saving?

you should be doing something like:

print("<form method=\"post\" action=\"takeedit.php?action=edit\">\n");

Then in takeedit.php:

if($_GET['action'] == "edit"){
$sql = (update table blah blah blah);
}

I do this on a page of mine and it works perfectly.

Or, since you're using POST, you could just throw in a hidden field called "action" or something with a value of "edit". Then you would do:

if($_POST['action'] == "edit"){
yadayadayada....
}

Is this helping at all?

[PRSBOY]

aww crap, i forgot about takeedit.php 😛

right, its working fine! thanks for reminding me about that 😛

just had to add:

$updateset[] = "image = " . sqlesc($image);

hehe, thanks 🙂

[gufmn]

Glad to hear you got it working. It's always the little things 🙂