[Resolved] Multiple IFs - Single ELSE

[partypete]

Hello all,

As mentioned in a previous post, I'm trying to do some server-side form validation. Only problem now is that my if/else code is allowing the form to be sent when it shouldn't be. The code I have is:

<?php
/***** Validate Sign-Up Form *****/
if (!preg_match($regex_lettersnumbersunderscore, $fv_user_name)) {
	$vald_user_name = "F";
 }
if (!preg_match($regex_lettersnumbersunderscore, $fv_user_password)) {
	$vald_user_password = "F";
	}
if (!preg_match($regex_lettersnumbersunderscore, $fv_txtconfirm)) {
	$vald_txtconfirm = "F";
	}
if ("$fv_user_password" != "$fv_txtconfirm") {
	$vald_passwordmatch = "F";
	}
if (!preg_match($regex_email, $fv_user_email)) {
	$vald_user_email = "F";
	}
if (!preg_match($regex_capitalY, $fv_user_agreement)) {
	$vald_user_agreement = "F";
} else {
	$vald_form1 = "P";
}
?>

The problem is that only the bottom IF statement needs to pass for the ELSE statement to be triggered. In this case it sets the variable $vald_form1 to "P" which allows another script further down the page to execute. What I want is, ALL 6 IF statements must pass before the ELSE statement is executed.

What needs to be changed so that the ELSE statement will only be triggered if ALL the IF statements pass?(In this case "pass" means all the "F" variables would NOT be set. "F" stands for Failed.)

Thank you as always,

Peter

[apzer0]

You should use the switch statment
http://il.php.net/manual/en/control-structures.switch.php

[Weedpacket]

You'll need to look at all your $vald_* variables to see if they're set or not in order to decide whether or not their respective tests failed. That would make for an ugly test at the end.

Here's a bitfield solution (not necessarily the best, but a lot more convenient than a lot of plain variables that may or may not even be set).

define('INVALID_USER_NAME',       1);
define('INVALID_USER_PASSWORD',   2);
define('INVALID_TXTCONFIRM',      4);
define('INVALID_PASSWORDMATCH',   8);
define('INVALID_USER_EMAIL',     16);
define('INVALID_USER_AGREEMENT', 32);

/***** Validate Sign-Up Form *****/
$tests = 0;
if (!preg_match($regex_lettersnumbersunderscore, $fv_user_name)) {
    $tests |= INVALID_USER_NAME;
 }
if (!preg_match($regex_lettersnumbersunderscore, $fv_user_password)) {
    $tests |= INVALID_USER_PASSWORD;
    }
if (!preg_match($regex_lettersnumbersunderscore, $fv_txtconfirm)) {
    $tests |= INVALID_TXTCONFIRM;
    }
if ("$fv_user_password" != "$fv_txtconfirm") {
    $test |= INVALID_PASSWORDMATCH;
    }
if (!preg_match($regex_email, $fv_user_email)) {
    $test |= INVALID_USER_EMAIL;
    }
if (!preg_match($regex_capitalY, $fv_user_agreement)) {
    $test |= INVALID_USER_AGREEMENT;
	}


if($test==0)
{
	$vald_form1 = "P";
}

And you can see which tests failed by using, e.g.,

if($tests&INVALID_USER_EMAIL)
{ // Email was invalid
}

[The_Chancer]

Just seen you have both $test abnd $tests in the same script...

better check those out...

[partypete]

Thanks all.

apzer0 - From what I understand "switch" won't work in this situation.

Weedpacket - Thanks I'm sure that would have worked nicely but I've decided to try something a tad simpler. I got rid of the ELSE statement entirely. If any of the IF statements fail, the variable $form1_ok = "N" (No) is set. Then in the final IF statement I simply check to see if that variable has been set which would mean atleast one IF statement failed and hence the code further down the page should NOT execute.

The code below seems to be working good.

Thanks again!

Peter

<?php
/***** Validate Sign-Up Form *****/
if ("$nametaken" == "Y") {
	$form1_ok = "N";
 }
if ("$emailtaken" == "Y") {
	$form1_ok = "N";
 }
if (!preg_match($regex_az_09_uscore_hyphen, $fv_user_name)) {
	$vald_user_name = "F";
	$form1_ok = "N";
 }
if (!preg_match($regex_az_09_uscore_hyphen, $fv_user_password)) {
	$vald_user_password = "F";
	$form1_ok = "N";
	}
if (!preg_match($regex_az_09_uscore_hyphen, $fv_txtconfirm)) {
	$vald_txtconfirm = "F";
	$form1_ok = "N";
	}
if ("$fv_user_password" != "$fv_txtconfirm") {
	$vald_passwordmatch = "F";
	$form1_ok = "N";
	}
if (!preg_match($regex_email, $fv_user_email)) {
	$vald_user_email = "F";
	$form1_ok = "N";
	}
if (!preg_match($regex_capitalY, $fv_user_agreement)) {
	$vald_user_agreement = "F";
	$form1_ok = "N";
 }
if ("$form1_ok" != "N") {
	$vald_form1 = "P";
}
?>

[Weedpacket]

Incidentally, you do know that PHP comes with true and false, don't you?

[partypete]

Yes I've read certain functions output true/false or 1/0 etc but I'm not much of a hand coder so what functions do what has escaped me a bit. The way I do it is to make the code as much like descriptive plain english as possible which keeps it easier to understand. Not the best way I'm sure, but it works.

Thanks again!