Displaying image - why doesn't this work properly?

jonki

Hi - I was wondering if there is anything I can add to this code to make sure that when foto is empty then nothing is displayed.

if(!empty($foto)) 
{echo'<img src="../../fotos_coches/' . $foto . '" width="300">'; } ?>

What I don't understand is that sometimes this html gets displayed even when foto is empty:

Is there anything I can do? I tried adding a "AND ($foto_type == "image/gif") or ($foto_type == "image/pjpeg") " but this didn't seem to work either...

Any ideas?

Many many thanks

Jon

TheDefender

I have had issues using empty() in the past myself, so I generally combine isset() and a check to see if the value is blank or not...

// First I trim any space off the beginning and end fo the variable.
$foto = trim($foto);
if(isset($foto) && $foto != "")  

{echo'<img src="../../fotos_coches/' . $foto . '" width="300">'; }

The main question is where/how is this $foto variable being set? There may be something being put in there that you aren't aware of.

bubblenut

In you example $foto isn't empty, it's a space. That's why empty is returning false. You could do a str_replace(' ', '', $foto) but then that would break for any images with spaces in the name. I think what would be a better idea would be to check if the file exists, and check it's type.

To check the file exists

file_exists($foto);

Remember that if you're not in the directory where the file resides you'll have to prepend the path.

Where are you getting $foto_type from?
I would suggest the easiest way to check the file's type would be.

mime_get_content_type($foto);

Check the manual (located at www.php.net) for further details on the functions I've used here.

HTH
Bubble

jonki

Defender - thanks; worked brilliantly.
Bubblenut - thanks for your help. It was really appreciated. Didn't quite get that far, but useful knowledge for the future.

Thanks a lot

Jon

jonki

Just a quick question.
Do either of you know (or had any similar problems with) why sometimes the file name gets truncated.

Sometimes my users upload a file but all I see is a red x. Sometimes there is a filename but it has no extention.
I use the usual checkd to see if it is a jpeg or gif and I reassign it a $newfotoname2 = uniqid("").$ext ;

The crazy thing is that sometimes there is no extension but the picture still displays perfectly.

I have tried to assimilate the results but no matter what I do I always get the picture uploaded perfectly.

Is there any limit to some peoples f**k-up-ability quotient?

Thanks

Jon

tsinka

Hi,

use getimagesize to check the uploaded files. This function returns an array with some useful info about the image (size, type ...). The function returns false if the file is e.g. an invalid image.

Thomas