data from forms into database

raymie7

Hi,
I'm having trouble putting data into a db from a form using the following php.

$name=$POST['name'];
$email=$POST['email'];
$name=trim($name);
$email=trim($email);
$name=addslashes($name);
$email=addslashes($email);
$chartnews=$POST['chartnews'];
$generalnews=$POST['generalnews'];

require_once("./Includes/db_connect.php");

if (($name!='')&&($email!='')&&($chartnews=="on"))
{
mysql_query("INSERT_INTO_subscribe_gen_SET_id= ' ' ");
mysql_query("INSERT_INTO_subscribe_gen_SET_name= '$name' ");
mysql_query("INSERT_INTO_subscribe_gen_SET_email= '$email' ");
}

The code in the db_connect file is:

Can anyone tell me what the problem is?

Cheers

has27

I'd always use

mysql_query("INSERT INTO subscribe_gen SET id= ' ' , name='$name', email='$email';");

I think you're suffering from an overdose of underscores...

Also, I think you need to combine the query statements. As it is it looks like you're doing three queries, which would insert three rows into the database, one with name, one with id and one with email.

Another thing - why is id blank? If this is an auto incrementer, just leave it out and all will be well...

Hope this helps. H.

raymie7

Thanks for your help.

The id column in the database is auto_increment so I've left it out as you suggested and modified the code to:

if (($name!='')&&($email!='')&&($chartnews=="on"))
{
mysql_query("INSERT_INTO_subscribe_gen_SET_name='$name',email='$email' ; ");
}
But the fields still won't apear in the database? Do you think the problem lies elsewhere?

Cheers

has27

You've still got underscores between INSERT and INTO - check the code I posted earlier carefully for syntax and see if that works...

You've also put $name!-" in your if statement - you need two quotes - $name!-""

Let me know if this works...

Weedpacket

Originally posted by has27
You've also put $name!-" in your if statement - you need two quotes - $name!-""

If you look closely, it's '', not ".

raymie7: Have you tried using [man]mysql_error/man to see what error MySQL is hitting (if any)? And take off the @ thing until you've got it working. It might be hiding error messages (that's what it's for) that might help you work out what's wrong. And when posting, put your code in [php]...[/php] tags to make it easier to read. Oh, and that semicolon on the end of the query really doesn't need to be there.

raymie7

Still not having any luck. I'm sure this code is fine now thanks, I need to look at other possible problem areas. Although the connection should be working fine as I've put in error messages to declare problems. Here's my query now anyway.

if (($name!=" ")&&($email!=" ")&&($chartnews=="on"))
{
mysql_query("INSERT_INTO_subscribe_gen_SET_name='$name',email='$email' ; ");
}

has27

Try this.

if (($name!=" ")&&($email!=" ")&&($chartnews=="on"))
{
mysql_query("INSERT INTO subscribe_gen SET name='$name', email='$email';");
}

raymie7

Sorry, these underscores keep appearing whenever I paste code into these textareas. I have taken all the underscores out as you said and so my query is the same as you've suggested. Honest!

has27

Hm.
Just on the obvious, there is a column called 'name' and 'email', isn't there? 🙂
Other than that, stumped. Weed, your call... sorry...

Weedpacket

Well, I've already made a couple of other suggestions that there hasn't been any feedback on, yet; those are my suggestions unless there more information is supplied.

raymie7

Still no luck. I'm all out of ideas so this is the best code I can come up with. This is my form fields.

<?php
$name=$POST['name'];
$email=$POST['email'];
$name=trim($name);
$email=trim($email);
$name=addslashes($name);
$email=addslashes($email);
$chartnews=$POST['chartnews'];
$generalnews=$POST['generalnews'];
require_once("./Includes/setup.inc.php");

if (($name!=" ")&&($email!=" ")&&($chartnews=="on"))
{
mysql_query("INSERT_INTO_subscribe_gen_VALUES_name='$name',email='$email' ");
}?>

The code for the connection is as follows:

<?php
$link = mysql_connect("localhost", "scottis2_smc", "sm1bgt129mn");

mysql_select_db("scottis2_test", $link);
echo mysql_errno($link) . ": " . mysql_error($link). "\n";

mysql_select_db("kossu", $link);
mysql_query("SELECT * FROM subscribe_gen", $link);
echo mysql_errno($link) . ": " . mysql_error($link) . "\n";
?>

I've used mysql_error as weed has suggested and now when I try to insert the data to the db 0: 0: appears at the top of the page but I'm not sure what this means?

PHP_apprentice

raymie

here are a few suggestions. They may seem elementary, but they work

These are just a few items that may help you troulbe shoot.


$query = "INSERT INTO subscribe_gen (name, email) VALUES ('$name','$email')";

$result = mysql_query($query);
$error = mysql_error();

if (!$result)
{
   echo $error;
}

writing out the entire insert string has helpeped me trouble shoot in the past.
this is just some thoughts.

Weedpacket

Originally posted by raymie7
I've used mysql_error as weed has suggested...

Did you try using it on the query that was causing the error (i.e., the INSERT - which you really should look at because as PHP_apprentice has noted, the syntax is completely wrong as you've written it).