jpgraph1.17 & php 5.0.0

[robgudgeon]

hi

has anyone successfully got php 5.0.0 and the latest jp graph working together? all i can get from code that worked fine in php 4.3 and the previous jp graph is:

general PHP error: non-static method jpgraph::install () should not be called statically

any advice appreciated
cheers, rob

[tsinka]

Hi,

the OO model of PHP5 has been rewritten completely. jpgraph isn't completely compatible. According to the website of jpgraph jpgraph 2.x will be rewritten to be compatible to PHP5. So far 1.x doesn't work with PHP 5 very well.

With php 5.0.1 and error_reporting=E_ALL I don't get any errors, with error_reporting set to 2048 (E_STRICT) I got numerous warnings and errors.

So either try to disable error_reporting (set it to 0) with php 5.0.0 or upgrade to php 5.0.1 because it seems like all the errors related to changes to PHP5 seem to be only displayed with php 5.0.1 if error_reporting is set to E_STRICT. Seems like php 5.0.0 sometimes shows errors in error_reporting mode E_ALL that should only be displayed in mode E_STRICT (just a guess).

Thomas

[robgudgeon]

hi Thomas

Thanks for your reply, I got a similar reply from johan on jpgraph's forum.

Unfortunately I've upgraded to php 5.0.1 but am still getting the same problems regardless of the error_reporting setting

any other suggestions?
cheers. Rob

[tsinka]

Inside the script jpgraph.php (around line 218 in the latest beta) change the class JpGraphError to:

class JpGraphError {
public static function Install($aErrObject) {
GLOBAL $jpg_err;
$jpg_err = $aErrObject;
}
public static function Raise($aMsg,$aHalt=true){
GLOBAL $jpg_err;
$tmp = new $jpg_err;
$tmp->Raise($aMsg,$aHalt);
}
}

I hope this solves that "static" error.

Thomas

[robgudgeon]

I changed the class as you suggested - this did solve the static issue but there's now a new bug:

General PHP error: var: Deprecated

please use the public/private/protected modifiers

I think it's referring to line 238:

public static function Install($aErrObject) {

?

many thanks, Rob

[tsinka]

Hi,

the problem is that the keyword var inside classes in the PHP 4.x style has been deprecated. I think we should rather check how we can solve the "problem" that any (PHP 5 related) error messages appear at all. Please post your php.ini so I can see how it looks like now.

Thomas

[robgudgeon]

hi Thomas

I've attached it to this message as php.txt as I didn't think .ini extensions would be allowed

thanks, rob

[tsinka]

Did you try error_reporting=0 in php.ini ? I know that this isn't a recommended setting but just to test ...

Thomas

[tsinka]

You can download the latest JpGraph 2.x development tree at http://www.aditus.nu/jpgraph/jpg_publiccvs.php

Besides that I modified the sources of the latest 1.x version so that JpGraph doesn't show any error messages in E_STRICT/E_ALL mode. The zip file is too large to post but it seems to work.

Thomas

[jpgraph]

Hi, (I'm the author of Jpgraph)

I also would like to get to the bottom of this. I'm running PHP5 with E_ALL by default. Will try the E_STRICT shortly.

I'm a little bit surprised that the CVS v2 works fine .. There are many changes in that code base but very few that has directly (yet) todo with PHP5. Basically the PHP5 support is what is already available in 1.17beta.

What I did was to backport the showstoppers to make the 1.x series run under PHP 5 from the CVS-2 branch

I have done quite a lot of testing on 5.0.1 and with E_ALL 1.17beta seems to be fine. If that is not the case I sure want to try to re-create the problems.

Are you running PHP as cli, CGI or module?
Are you dunning Linux/Windows?
Are you running under IIS/Apache?

Rgds
Johan

[tsinka]

Hi Johan,

after reading your post I remembered that I forgot to test the 2.x version with E_STRICT. Version 2.x also shows PHP5 related errors with error_reporting=E_STRICT.

I tested jpgraph with error_reporting=4095 which results in a long list of (expected) warnings.

What I don't understand is that robgudgeon gets any messages even with error_reporting set to 0.

robgudgeon: did you test error_reporting=0 ?

Thomas

[robgudgeon]

hi guys

yep, i've tried with error_reporting = 0 in my php.ini and it makes no difference.

one thing that's probably worth mentioning - I need to run 2 separate PHPs: 4.3.3 so the live jp graph still works for users, and a php 5.0.1 on an apache running on a different port for development until this issue is resolved. currently both php installations use the same php.ini though I don't see why this would be a problem

Johan - I'm running PHP on Linux, under Apache with PHP running as a DSO

thanks, rob

[robgudgeon]

for anyone watching this with a similar problem, a workaround can be seen at http://jpgraph.intellit.nl/viewtopic.php?t=2108

it's to turn off track_errors

thanks, rob