if statement help

Ivains

Having problems getting my if statement to work correctly. Below I have a random image script and what I want it to do is if there was not an image uploaded for the property displayed to display the No Image Available picture. However its not displaying. I get the random images for the ones uploaded, but not the ones without.

Any help on what I'm doing wrong would be gratefully appreciated.

$picturepath  = $mosConfig_live_site.$ea_picpath."/";

$query="SELECT * FROM #__estateagent_object ORDER BY rand() LIMIT 1";
$database->setQuery( $query );
$rows = $database->loadObjectList();
$row=$rows[0];

$query1="SELECT id, img_id, obj_img1, obj_img1_descript FROM #__estateagent_images WHERE img_id=$row->id";
$database->setQuery( $query1 );
$rows1 = $database->loadObjectList();
$row1=$rows1[0];

$query2="SELECT * FROM #__estateagent_category WHERE cat_id=$row->obj_cat";
$database->setQuery( $query2 );
$rows2 = $database->loadObjectList();
$row2=$rows2[0];

if($row1[0]=="") {
$sm_pic = "<img src='".$picturepath."thmb_".$row1->obj_img1."' border='0' alt='$row->obj_title'>"; }
elseif($row1[0]!=""){
$sm_pic = "<img src='".$mosConfig_live_site."/components/com_estateagent/obj_pictures/nopic.png' border='0' alt='No Picture Available'>"; }

echo "<center><a href='index.php?option=com_estateagent&Itemid=0&func=showObject&objid=$row->id'><b>$row2->cat_name</b><br/>$sm_pic<br/>$row->obj_title</a></center>";

Weedpacket

What is the value of img_id if there is no image? NULL, I'd guess, in which case you'd want to include "OR img_id IS NULL" in the query.

Another approach would be to reserve image ID 0 to mean the "No Available Picture" image, and then have that field default to 0. Then no special treatment would be required.

Ivains

I should of clarified myself a bit more. The original script when uploading the full-size pic uploads it to the obj_pictures directory and automatically creates the thumb in the same folder.

So in the folder you will have 2 images (e.g. image1.jpg and thmb_image1.jpg).

The db only stores the name of the full-size pic which in this case would be image1.jpg and the img_id which links it to the id of the first query. There is no value img value linking it to the data what so ever if no pic was uploaded. Thats where my problem is.

If you notice the queries there are 3. The first one stores all the information for the property (e.g. Discription, Location, etc.). The second one stores the image information if the image was uploaded (e.g. id, img_id, img_name, img_discription). And the third is the category (e.g. For Sale, For Rent, etc.).

So what I want it to do is that if no image was ever uploaded to display the No Picture Available image. Right now withthe script as is, it displays the red x and of course if there was an image uploaded it will display it correctly.

Thanks for responding any suggestions would be gratefully appreciated.

tsinka

Hi,

first of all check if the path to the nopic image is correct at all. Second, not all browsers can dispay png images (e.g. IE5,IE6).

Change the image format to jpg or gif.

Thomas

Ivains

The path is correct. The image is good. I'm just having a hard time making it display the No Pic Avail image if one was not uploaded. There is no reference in the db.

If I write the statement as such:

if($img_id=$row->id) {
$sm_pic = "<img src='".$picturepath."thmb_".$row1->obj_img1."' border='0' alt='$row->obj_title'>"; }
else {
$sm_pic = "<img src='". $mosConfig_live_site."/components/com_estateagent/obj_pictures/nopic.png' border='0' alt='No Picture Available'>"; }

It will randomize the pics, but if not loaded will display red x.

If I change the first line to:

if($id=$row->img_id) {

It will display the No Pic Avail all the time.

Its a mind boggler to me...