List menu multi select

[Madwizard]

Hi, I'm trying to make a list menu which will display the list taken from one table and compare it to a comma delimited string taken from another table which will become the selected items in the list. But i can't work out how to loop through the items. This is what i have so far can anyone help?

<?
$Colourquery = mysql_query("SELECT * FROM colour_tbl"); // mySQL query
$ColourArray = explode(',',$row["itemColour"]); // Explode array from data 1,2,3,4,5
print "<SELECT name=typeColour[] size=5 multiple>";
while ($Colouresult = mysql_fetch_assoc($Colourquery))
{
echo "<OPTION value= $Colouresult[colourId] ";
foreach ($ColourArray as $COL)
{
if ($Colouresult["colourId"] == $COL)
{
echo "Selected> $Colouresult[colourType] </OPTION>";
} else {
echo " > $Colouresult[colourType] </OPTION>";
}
}
}
print "</SELECT>";
?>

[czambran]

try this and tell if it works

<?
$Colourquery = mysql_query("SELECT * FROM colour_tbl"); // mySQL query
$ColourArray = explode(',',$row['itemColour']); // Explode array from data 1,2,3,4,5
print "<SELECT name=typeColour[] size=5 multiple>";
while ($Colouresult = mysql_fetch_assoc($Colourquery))
{
echo "<OPTION value= $Colouresult['colourId'] ";
echo in_array($Colouresult['colourId'],$ColourArray)? "Selected":''; 
echo "> {$Colouresult['colourType'] }</OPTION>";
}
print "</SELECT>";
?>

[Madwizard]

I had to modify the script as it was coming up with a few errors but it only makes one item selected.

$Colourquery = mysql_query("SELECT * FROM colour_tbl"); // mySQL query
$ColourArray = explode(',',$row["itemColour"]); // Explode array from data 1,2,3,4,5

		print "<SELECT name=typeColour[] size=5 multiple>"; 
		while ($Colouresult = mysql_fetch_assoc($Colourquery)) 
		{ 
				echo "<OPTION value= $Colouresult[colourId] "; 
					foreach ($ColourArray as $key=>$value) 
					{ 
						if ($Colouresult['colourId'] == $value)
						{ 
							echo "Selected"; 
						}
						echo "> {$Colouresult['colourType'] }</OPTION>"; 
					}
		} 
		print "</SELECT>";

[czambran]

I edited my post, try the new code. It's smaller and faster.

let me know if it worked

[Madwizard]

Yes it works thank you. You have been a great help 😃