problem with 2 mysql whiles

kumschick

Why don't the first while doesn't work correctly?

          $i=0;
          if(!empty($orderby)) { $orderby="$orderby"; } else { $orderby="id"; }
          $chkuser=mysql_query("select * from $db_computer order by $orderby");
          while($row=mysql_fetch_array($chkuser))
            {

        $i++;
        if ($i%2) { $bgcolorm="bgcolor=\"#DADFF7\""; } else { $bgcolorm="bgcolor=\"#B7BFE5\""; }

          $get_task_pc=mysql_query("select * from $db_tasks where page='wakeup' order by id");
          while($row2=mysql_fetch_array($get_task_pc))
            {
              $del_task = "$row2[tname]";
              $task_id = "$row2[tid]";
            }

          if($del_task==$row[pc_mac]) {
            $task_manager="<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=RemoveTask&id=$task_id\" onclick=\"return confirmSubmit()\"><img width=\"16\" height=\"16\" alt=\"Remove Task\" border=\"0\" src=\"/images/button_remove.png\"></a>";
          } else {
            $task_manager="<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=Task&id=$row[pc_mac]\"><img width=\"16\" height=\"16\" alt=\"Scheduled Task\" border=\"0\" src=\"/images/button_task.png\"></a>";
          }

        echo"
        <tr $bgcolorm>
          <td valign=\"top\" align=\"center\"><font face=\"$font_face\" size=\"$font_size\" color=\"$font_color\">$task_manager &nbsp;<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=Edit&id=$row[id]\"><img alt=\"Edit Computer\" border=\"0\" src=\"/images/button_edit.png\"></a>&nbsp;&nbsp;&nbsp;<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=Delete&id=$row[id]\" onclick=\"return confirmSubmit()\"><img alt=\"Delete Computer\" border=\"0\" src=\"/images/button_drop.png\"></a>&nbsp;</font></td>
          <td valign=\"top\" align=\"right\"><font face=\"$font_face\" size=\"$font_size\" color=\"$font_color\">$row[id]</a></font></td>
          <td valign=\"top\"><font face=\"$font_face\" size=\"$font_size\" color=\"$font_color\">$row[pc_name]</font></td>
          <td valign=\"top\"><font face=\"$font_face\" size=\"$font_size\" color=\"$font_color\">$row[pc_mac]</font></td>
        </tr>
        ";

        }

pete_bisby

It looks like you're setting the $orderby variable to the string "$orderby", which is why it isn't working correctly.

Try reversing the first if statement:

if (empty($orderby)) {
  $orderby = "id";
}

...

...

So, if $orderby already has a value, leave it alone, else order by id.

kumschick

no, the problem is coming from:
it doesn't show all data from mysql DB??? only the last value inserted into it

              $get_task_pc=mysql_query("select * from $db_tasks where page='wakeup' order by id"); 
              while($row2=mysql_fetch_array($get_task_pc)) 
                { 
                  $del_task = "$row2[tname]"; 
                  $task_id = "$row2[tid]"; 
                } 

          if($del_task==$row[pc_mac]) { 
            $task_manager="<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=RemoveTask&id=$task_id\" onclick=\"return confirmSubmit()\"><img width=\"16\" height=\"16\" alt=\"Remove Task\" border=\"0\" src=\"/images/button_remove.png\"></a>"; 
          } else { 
            $task_manager="<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=Task&id=$row[pc_mac]\"><img width=\"16\" height=\"16\" alt=\"Scheduled Task\" border=\"0\" src=\"/images/button_task.png\"></a>"; 
          }

pete_bisby

The if statement isn't placed within the while loop.

The while loop is running straight to the end of your recordset, then you're asking the if statement.

Place it inside the while loop, and you should see the correct results.

$get_task_pc=mysql_query("select * from $db_tasks where page='wakeup' order by id");
while ($row2=mysql_fetch_array($get_task_pc)) {
  $del_task = "$row2[tname]";  

  $task_id = "$row2[tid]";  

  if($del_task==$row[pc_mac]) {
    $task_manager="<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=RemoveTask&id=$task_id\" onclick=\"return confirmSubmit()\"><img width=\"16\" height=\"16\" alt=\"Remove Task\" border=\"0\" src=\"/images/button_remove.png\"></a>";  

  } else {
    $task_manager="<a href=\"/adm_content_pc_edit.mrm?mt=$mt&do=Task&id=$row[pc_mac]\"><img width=\"16\" height=\"16\" alt=\"Scheduled Task\" border=\"0\" src=\"/images/button_task.png\"></a>";  

  }
}