[Resolved] UPDATE not working - help please

cheese

Evening all,

I have written this UPDATE, but the table is not updating, any offers....


$link = mysql_connect($sql_server, $sql_username, $sql_password)
        or die("Could not connect : " . mysql_error());
    mysql_select_db($sql_database) or die("Could not select database");

$query = mysql_query (("UPDATE teams SET TeamNumber = $teamnumber, LastUpdated = $lastupdated, 
Teamname = $teamname, Division = $division, GroundName = $groundname, AddressOne = $addressone, 
AddessTwo = $addesstwo, Town = $town, County = $county, GroundTelephone = $groundtelephone, 
GroundFax = $groundfax, HomeColours = $homecolours, AwayColours = $awaycolours, 
History = $history, GroundMap = $groundmap, DirectionsNorth = $directionsnorth, DirectionsSouth = $directionssouth,
DirectionsEast = $directionseast, DirectionsWest = $directionswest, Website = $website 
WHERE TeamNumber = $teamnumber ") or die("Bug Report Please - " . mysql_error()));

There are no error reports and all of the variables 'seem' OK.... just doesn't update.

Regards,

Neil.

xblue

unless your variables are numbers only, you'd need to put them in single quotes.

apart from that, just wondering... may your parentheses be slightly disordered? the ' or die("Bug Report Please - " . mysql_error())' seems to be part of what is passed to mysql_query as argument.

try

$query = mysql_query ("UPDATE teams SET TeamNumber = $teamnumber, LastUpdated = '$lastupdated', 
Teamname = '$teamname', ...  

WHERE TeamNumber = $teamnumber ") or die("Bug Report Please - " . mysql_error());

or - what I prefer compose the sql statement first, then execute it (advantage: you can add it to the error message to see what's going on)

$sql = "UPDATE teams SET TeamNumber = $teamnumber, LastUpdated = '$lastupdated', 
Teamname = '$teamname', ...  

WHERE TeamNumber = $teamnumber ";
$query = mysql_query($sql) or die("Bug Report Please - " . mysql_error() . " - " . $sql);

(edit: forgot some quotes myself - my bad)

cheese

Thanks for that XBlue,

Found it in the end... spelling mistake......

I got down to just adding the statements one at a time ands with your comments about the quotes noted, all is working well.

At least I have learned that you should strart simple and build from there.

Thanks again,

Neil.