Columns Question???

[Ivains]

Hi Everyone,

I used the script below many years ago to achieve my objective, but now it doesn't want to cooperate with me. It would be gratefully appreciated if you can take a gander at it and maybe spot my error, cause I can't find it. Thanks for your inputs.

Oh, I almost forget to mention what I'm trying to do here: I'm trying to set it up so that if I chose to have let say 10 properties shown it will display 5 per row and go to the next row. And so on and so forth. I hope I explained it well.

# Module Parameter Settings
  $HowMany = @$params->HowMany ? $params->HowMany : '5';
  $Alignment =  @$params->Alignment ? $params->Alignment : '1';
  $LineColor1 = @$params->LineColor1 ? $params->LineColor1 : '#FFFFFF';
  $LineColor2 = @$params->LineColor2 ? $params->LineColor2 : '#EBE7E7';
  $ColumnSize =  @$params->ColumnSize ? $params->ColumnSize : '5';
  $ColumnWidth =  @$params->ColumnWidth ? $params->ColumnWidth : '100';

$query="SELECT t1.id, t1.obj_cat, t1.obj_title, t1.obj_publish, t1.obj_pub_start, t1.obj_pub_stop, t2.img_id, t2.obj_img1, t3.cat_id, t3.cat_name 
FROM #__estateagent_object AS t1 
LEFT JOIN #__estateagent_images AS t2 ON t2.img_id=t1.id 
LEFT JOIN #__estateagent_category AS t3 ON t3.cat_id=t1.obj_cat
WHERE ("
                . "\n   (((t1.obj_pub_start >= '0000-00-00 00:00:00' AND t1.obj_pub_start <= '$todate 23:59:59' ) AND (t1.obj_pub_stop <= '$todate 23:59:59' AND t1.obj_pub_stop >= '$todate 00:00:00'))"
                                 . "\n   OR ((t1.obj_pub_start >= '0000-00-00 00:00:00' AND t1.obj_pub_start <= '$todate 23:59:59' ) AND t1.obj_pub_stop >= '$todate 23:59:59')"
                                 . "\n    OR (t1.obj_pub_stop >= '$todate 00:00:00' AND t1.obj_pub_stop <= '$todate 23:59:59')"
                                 . "\n    OR (t1.obj_pub_start = '0000-00-00 00:00:00' AND t1.obj_pub_stop = '0000-00-00 00:00:00')"
                                 . "\n )"
                . "\n AND t1.obj_publish='1') 
ORDER BY t1.id DESC LIMIT $HowMany"; 

# Query the database       
$database->setQuery( $query );
$rows = $database->loadObjectList();
$row=$rows[0];

$content ="<div align='center'><table width='100%' border='1' cellspacing='2' cellpadding='0'><tr>";

$column=1;

if ($column>$HowMany) {
    $column=1;
$content .="</tr><tr>";
    }

if($id != $row->img_id) {
  $sm_pic = "<img src='".$picturepath."thmb_".$row->obj_img1."' border='0' alt='$row->obj_title'>"; 
} else {
  $sm_pic = "<img src='". $mosConfig_live_site."/components/com_estateagent/obj_pictures/nopic.png' border='0' alt='$row->obj_title'>"; 
}

$content .="<td align='center' width='$ColumnWidth'><a href='index.php?option=com_estateagent&Itemid=0&func=showObject&objid=$row->id'><b>$row->cat_name</b><br>$sm_pic<br><font size='1'>$row->obj_title</font></a></td>";

$column++;

if (substr($content, -$ColumnSize)!="</tr>") {
$content .="</tr>";
    }

$content .="</table></div>";

echo "$content";

[Weedpacket]

Um, you forgot to mention what it's doing instead of what it's supposed to.

Before embarking on debugging (which I can't do anyway, because I don't your class definitions, nor do I have your database), what have you tried so far and what were the results?

Let me just rewrite this a touch to make it a bit clearer:

# Module Parameter Settings
  $HowMany = @$params->HowMany ? $params->HowMany : '5';
  $Alignment =  @$params->Alignment ? $params->Alignment : '1';
  $LineColor1 = @$params->LineColor1 ? $params->LineColor1 : '#FFFFFF';
  $LineColor2 = @$params->LineColor2 ? $params->LineColor2 : '#EBE7E7';
  $ColumnSize =  @$params->ColumnSize ? $params->ColumnSize : '5';
  $ColumnWidth =  @$params->ColumnWidth ? $params->ColumnWidth : '100';

$query="SELECT
	t1.id, t1.obj_cat, t1.obj_title, t1.obj_publish,
	t1.obj_pub_start, t1.obj_pub_stop, t2.img_id, t2.obj_img1, t3.cat_id, t3.cat_name
FROM
	#__estateagent_object AS t1 
	LEFT JOIN #__estateagent_images AS t2 ON t2.img_id=t1.id 
	LEFT JOIN #__estateagent_category AS t3 ON t3.cat_id=t1.obj_cat
WHERE
	(
		(
			(
				(
					t1.obj_pub_start >= '0000-00-00 00:00:00'
					AND
					t1.obj_pub_start <= '$todate 23:59:59'
				)
				AND
				(
					t1.obj_pub_stop <= '$todate 23:59:59'
					AND
					t1.obj_pub_stop >= '$todate 00:00:00'
				)
			)
			OR
			(
				(
					t1.obj_pub_start >= '0000-00-00 00:00:00'
					AND
					t1.obj_pub_start <= '$todate 23:59:59'
				)
				AND
				t1.obj_pub_stop >= '$todate 23:59:59'
			)
			OR
			(
				t1.obj_pub_stop >= '$todate 00:00:00'
				AND
				t1.obj_pub_stop <= '$todate 23:59:59'
			)
			OR
			(
				t1.obj_pub_start = '0000-00-00 00:00:00'
				AND
				t1.obj_pub_stop = '0000-00-00 00:00:00'
			)
		)
		AND
			t1.obj_publish='1'
	)
ORDER BY t1.id DESC LIMIT $HowMany"; 

# Query the database       
$database->setQuery( $query );
$rows = $database->loadObjectList();
$row=$rows[0];

$content ="<div align='center'><table width='100%' border='1' cellspacing='2' cellpadding='0'><tr>";

$column=1;

if ($column>$HowMany) {
	$column=1;
	$content .="</tr><tr>";
}

if($id != $row->img_id) {
  $sm_pic = "<img src='".$picturepath."thmb_".$row->obj_img1."' border='0' alt='$row->obj_title'>"; 
} else {
  $sm_pic = "<img src='". $mosConfig_live_site."/components/com_estateagent/obj_pictures/nopic.png' border='0' alt='$row->obj_title'>"; 
}

$content .="<td
align='center' width='$ColumnWidth'><a
href='index.php?option=com_estateagent&Itemid=0&func=showObject&objid=$row->id'><b>$row->cat_name</b><br>$sm_pic<br><font
size='1'>$row->obj_title</font></a></td>";

$column++;

if (substr($content, -$ColumnSize)!="</tr>") {
	$content .="</tr>";
}

$content .="</table></div>";

echo $content;

[Ivains]

I apologize for not being clearer. The output is given is 2 rows, i column of the last entry in the database. The class definitions, I think you are talking about my parameters are:

HowMany = 3 // Limit number of entries you want to display.
Alignment = 1 // Display vertical or horizontal. Vertical=1 Horizontal=2
LineColor1 = #FFFFFF // Column color setting in Horizational alignment
LineColor2 = #EBE7E7 // Column color setting in Horizational alignment
ColumnSize = 3 // Number of columns per row in Horizational alignment
ColumnWidth = 100 // Size of each column in pixels in Horizational alignment

The code is only part of the script. The first part when the parameter is set to vertical display works perfect. But when I try to set the parameter to display horizontal is where I'm stuck. I did some search and found 4 snipplets that I thought might do the trick, but they were all failures. The one that I've shown here I've used it once a few years ago and it worked then, but the query was written a little different.

Here is the complete script:

# Don't allow direct acces to the file
defined( '_VALID_MOS' ) or die( 'Direct Access to this location is not allowed.' );

# Set path to config file
require($mainframe->getCfg( 'absolute_path' )."/administrator/components/com_estateagent/configuration.php");

# Module Parameter Settings 
  $HowMany = @$params->HowMany ? $params->HowMany : '5'; 
  $Alignment =  @$params->Alignment ? $params->Alignment : '1'; 
  $LineColor1 = @$params->LineColor1 ? $params->LineColor1 : '#FFFFFF'; 
  $LineColor2 = @$params->LineColor2 ? $params->LineColor2 : '#EBE7E7'; 
  $ColumnSize =  @$params->ColumnSize ? $params->ColumnSize : '5'; 
  $ColumnWidth =  @$params->ColumnWidth ? $params->ColumnWidth : '100'; 


### DONT EDIT BELOW THIS LINE #################################################

# Set path to thumbnails
$picturepath  = $mosConfig_live_site.$ea_picpath."/";

$query="SELECT 
    t1.id, t1.obj_cat, t1.obj_title, t1.obj_publish, 
    t1.obj_pub_start, t1.obj_pub_stop, t2.img_id, t2.obj_img1, t3.cat_id, t3.cat_name 
FROM 
    #__estateagent_object AS t1  

    LEFT JOIN #__estateagent_images AS t2 ON t2.img_id=t1.id  

    LEFT JOIN #__estateagent_category AS t3 ON t3.cat_id=t1.obj_cat 
WHERE 
    ( 
        ( 
            ( 
                ( 
                    t1.obj_pub_start >= '0000-00-00 00:00:00' 
                    AND 
                    t1.obj_pub_start <= '$todate 23:59:59' 
                ) 
                AND 
                ( 
                    t1.obj_pub_stop <= '$todate 23:59:59' 
                    AND 
                    t1.obj_pub_stop >= '$todate 00:00:00' 
                ) 
            ) 
            OR 
            ( 
                ( 
                    t1.obj_pub_start >= '0000-00-00 00:00:00' 
                    AND 
                    t1.obj_pub_start <= '$todate 23:59:59' 
                ) 
                AND 
                t1.obj_pub_stop >= '$todate 23:59:59' 
            ) 
            OR 
            ( 
                t1.obj_pub_stop >= '$todate 00:00:00' 
                AND 
                t1.obj_pub_stop <= '$todate 23:59:59' 
            ) 
            OR 
            ( 
                t1.obj_pub_start = '0000-00-00 00:00:00' 
                AND 
                t1.obj_pub_stop = '0000-00-00 00:00:00' 
            ) 
        ) 
        AND 
            t1.obj_publish='1' 
    ) 
ORDER BY t1.id DESC LIMIT $HowMany";  

# Query the database        
$database->setQuery( $query ); 
$rows = $database->loadObjectList(); 
$row=$rows[0]; 

# Put the output on screen
if ($Alignment == '1') {

foreach($rows as $row) {

$content .= "<center><a href='index.php?option=com_estateagent&Itemid=0&func=showObject&objid=$row->id'><b>$row->cat_name</b><br>";

if($id != $row->img_id) {
  $sm_pic = "<img src='".$picturepath."thmb_".$row->obj_img1."' border='0' alt='$row->obj_title'>"; 
} else {
  $sm_pic = "<img src='". $mosConfig_live_site."/components/com_estateagent/obj_pictures/nopic.png' border='0' alt='$row->obj_title'>"; 
}

$content .= "$sm_pic";

$content .= "<br><font size='1'>$row->obj_title</font></a></center><br>";

}
}

if ($Alignment == '2') {

$content ="<div align='center'><table width='100%' border='1' cellspacing='2' cellpadding='0'><tr>"; 

$column=1; 

if ($column>$HowMany) { 
    $column=1; 
    $content .="</tr><tr>"; 
} 

if($id != $row->img_id) { 
  $sm_pic = "<img src='".$picturepath."thmb_".$row->obj_img1."' border='0' alt='$row->obj_title'>";  

} else { 
  $sm_pic = "<img src='". $mosConfig_live_site."/components/com_estateagent/obj_pictures/nopic.png' border='0' alt='$row->obj_title'>";  

} 

$content .="<td 
align='center' width='$ColumnWidth'><a 
href='index.php?option=com_estateagent&Itemid=0&func=showObject&objid=$row->id'><b>$row->cat_name</b><br>$sm_pic<br><font 
size='1'>$row->obj_title</font></a></td>"; 

$column++; 

if (substr($content, -$ColumnSize)!="</tr>") { 
    $content .="</tr>"; 
} 

$content .="</table></div>"; 

echo $content;

}

You can see the output at My Temp Site .

[Ivains]

Still trying to work this out on/off... I rewrote some of it, but know I get NO images to display just the red cell bgcolor.

I think it has something to do with:

 for($i=0; $i < $query; $i++) 
{ 
    $row = mysql_fetch_array ($query);

But not sure...

Here is the code again after rewrite:

  $HowMany = @$params->HowMany ? $params->HowMany : '5'; 
  $NumberOfCols =  @$params->NumberOfCols ? $params->NumberOfCols : '3'; 
  $CSpace =  @$params->CSpace ? $params->CSpace : '3'; 
  $CPadding =  @$params->CPadding ? $params->CPadding : '3'; 
  $BorderThickness =  @$params->$BorderThickness ? $params->$BorderThickness : '1'; 

$query="SELECT 
    t1.id, t1.obj_cat, t1.obj_title, t1.obj_publish, 
    t1.obj_pub_start, t1.obj_pub_stop, t2.img_id, t2.obj_img1, t3.cat_id, t3.cat_name 
FROM 
    #__estateagent_object AS t1  

    LEFT JOIN #__estateagent_images AS t2 ON t2.img_id=t1.id  

    LEFT JOIN #__estateagent_category AS t3 ON t3.cat_id=t1.obj_cat 
WHERE 
    ( 
        ( 
            ( 
                ( 
                    t1.obj_pub_start >= '0000-00-00 00:00:00' 
                    AND 
                    t1.obj_pub_start <= '$todate 23:59:59' 
                ) 
                AND 
                ( 
                    t1.obj_pub_stop <= '$todate 23:59:59' 
                    AND 
                    t1.obj_pub_stop >= '$todate 00:00:00' 
                ) 
            ) 
            OR 
            ( 
                ( 
                    t1.obj_pub_start >= '0000-00-00 00:00:00' 
                    AND 
                    t1.obj_pub_start <= '$todate 23:59:59' 
                ) 
                AND 
                t1.obj_pub_stop >= '$todate 23:59:59' 
            ) 
            OR 
            ( 
                t1.obj_pub_stop >= '$todate 00:00:00' 
                AND 
                t1.obj_pub_stop <= '$todate 23:59:59' 
            ) 
            OR 
            ( 
                t1.obj_pub_start = '0000-00-00 00:00:00' 
                AND 
                t1.obj_pub_stop = '0000-00-00 00:00:00' 
            ) 
        ) 
        AND 
            t1.obj_publish='1' 
    ) 
ORDER BY t1.id DESC LIMIT $HowMany";  

# Query the database        
$database->setQuery( $query ); 
$rows = $database->loadObjectList(); 
$row=$rows[id]; 

$columns = $NumberOfCols; 
$count = 0; 

$content .= "<table width=100% border=$BorderThickness cellspacing=$CSpacing cellpadding=$CPadding>"; 
$content .= "<tr>"; 

for($i=0; $i < $query; $i++) 
{ 
    $row = mysql_fetch_array ($query);

if($i % $columns == 0 && $i != 0) 
{ 
    $content .= "</tr>"; 
    $content .= "<tr>"; 
    $count = 0; 
} 

		if($id == $row->img_id) { 
			$sm_pic = "<img src=".$picturepath."thmb_".$row->obj_img1." border='0' alt='$row->obj_title'>";  
		} else { 
			$sm_pic = "<img src='\". $mosConfig_live_site.\"/components/com_estateagent/obj_pictures/nopic.png' border='0' alt='$row->obj_title'>";  
		} 

$content .= "<td>" . $sm_pic . "</td>"; 
$count++; 
} 

if($columns != $count) 
{ 
    for($i = 0; $i < ($columns - $count); $i++) 
    { 
        $content .= "<td bgcolor=red>&nbsp;</td>"; 
    } 
} 

$content .= "</tr>"; 
$content .= "</table>"; 

}

Any help would be gratefully appreciated...

Thanks a bunch...

[Weedpacket]

for($i=0; $i < $query; $i++)

You're right about that being wrong. $query is a result set resource (as returned by mysql_query), not a number. If you want the number of rows in a MySQL result set, use [man]mysql_num_rows[/man].