[Resolved] Another issue with columns (skipping loop)

absolethe

I've been experimenting with this code for a few days while teaching myself to turn my site into a database driven site. I just leapt another hurdle, but noticed (because instead of using crap images for test purposes, I inserted a few 'real' images from my site) that this is skipping a loop.

The behavior is odd. If set at three, it skips the first image that would show up on the 2nd row. Ok, it's skipping.

img1 img2 img3
img5 img6

If set at two, it seems to count even images that it skips. Huh?
img1 img2
img4
img6

I'm a bit of a newbie, but I believe that break and continue don't work in if, else statements? I tried inserting them and it had no effect (course, if they are supposed to work, I easily could have done it wrong).

$count=0;

$table = mysql_query("SELECT * FROM $page");

echo("  <b>$page gallery</b><br><br>");

echo("<table border='0' cellspacing='1' cellpadding='1' width='300' align='center'><tr>");

while ( $r = mysql_fetch_array($table) ) :

if ($count==3){
echo ("</tr><tr><td span='4'><img src='images/spacer.gif' height='10'

width='1'></td></tr><tr>");
$count=1;
}else{
$id=$r["id"];
$pic=$r["pic"];
$thumb=$r["thumb"];
$pname=$r["pname"];
$pcom=$r["pcom"];
echo("<td align='center' valign='top' width='100'><a href='$pic' target='blank'><img src='$thumb'

border='0' align='left' alt='$pcom'></a><br clear='all'><a href='$pic' target='blank' alt='$pcom'

title='$pcom'><b>$pname</b></a></td>");
$count++;
}
endwhile;

echo ("</tr></table>");

😕

gufmn

First off you should put a { where you define your while loop.

Secondly, It doesn't look like your if statement will ever get called since you keep resetting $count to 1 in your while loop. Looks like that is where your problem is.

Weedpacket

To make it easier on my eyes:

$count=0;

$table = mysql_query("SELECT * FROM $page");

echo "  <b>$page gallery</b><br><br>";

echo "<table border='0' cellspacing='1' cellpadding='1' width='300' align='center'><tr>";

while($r = mysql_fetch_array($table))
{
	if ($count==3)
	{
		echo "</tr><tr><td span='4'><img src='images/spacer.gif' height='10' width='1'></td></tr><tr>";
		$count=1;
	}
	else
	{
		$id=$r["id"];
		$pic=$r["pic"];
		$thumb=$r["thumb"];
		$pname=$r["pname"];
		$pcom=$r["pcom"];
		echo "<td
align='center' valign='top' width='100'><a
href='$pic' target='blank'><img
src='$thumb' border='0' align='left' alt='$pcom'></a><br
clear='all'><a
href='$pic' target='blank' alt='$pcom' title='$pcom'><b>$pname</b></a></td>";
		$count++;
	}
}
echo "</tr></table>";

And I see what the problem is. When $count==1, you output a spacer instead of the data you retrieved in the while statement.
Easiest solution would be to just lose the "else" because you want to display every row of data - not skip over them if you're inserting a spacer instead. Maybe move that data display code up before the spacer as well (it does make a difference, try it both ways and see which one is more like what you want).

$count=0;

$table = mysql_query("SELECT * FROM $page");

echo "  <b>$page gallery</b><br><br>";

echo "<table border='0' cellspacing='1' cellpadding='1' width='300' align='center'><tr>";

while($r = mysql_fetch_array($table))
{
	$id=$r["id"];
	$pic=$r["pic"];
	$thumb=$r["thumb"];
	$pname=$r["pname"];
	$pcom=$r["pcom"];
	echo "<td
align='center' valign='top' width='100'><a
href='$pic' target='blank'><img
src='$thumb' border='0' align='left' alt='$pcom'></a><br
clear='all'><a
href='$pic' target='blank' alt='$pcom' title='$pcom'><b>$pname</b></a></td>";
	$count++;
	if ($count==3)
	{
		echo "</tr><tr><td span='4'><img src='images/spacer.gif' height='10' width='1'></td></tr><tr>";
		$count=1;
	}
}
echo "</tr></table>";

To be honest, I wouldn't even use a [man]while[/man] here; I'd use a [man]for[/man] instead.

$table = mysql_query("SELECT * FROM $page");

echo "  <b>$page gallery</b><br><br>";

echo "<table border='0' cellspacing='1' cellpadding='1' width='300' align='center'><tr>";

$count = mysql_num_rows($table);
for($i=0; $i<$count; $i++)
{
	$r = mysql_fetch_array($table);
	$id=$r["id"];
	$pic=$r["pic"];
	$thumb=$r["thumb"];
	$pname=$r["pname"];
	$pcom=$r["pcom"];
	echo "<td
align='center' valign='top' width='100'><a
href='$pic' target='blank'><img
src='$thumb' border='0' align='left' alt='$pcom'></a><br
clear='all'><a
href='$pic' target='blank' alt='$pcom' title='$pcom'><b>$pname</b></a></td>";
	if ($i%3==2) // The columns are numbered 0,1,2 - so the last column is column 2
	{
		echo "</tr><tr><td span='4'><img src='images/spacer.gif' height='10' width='1'></td></tr><tr>";
	}
}
echo "</tr></table>";

absolethe

I'd modified this--I'm a little (a little? very) wary of trying things I haven't seen done before in some fashion. But in reading php.net, I had thought using "for" would better--I just wasn't sure how to go about it.

Thank you VERY much for the two (well, three) suggestions. I like the for version much better, it looks neater to me and works perfectly.

Weedpacket

Originally posted by absolethe
Thank you VERY much for the two (well, three) suggestions. I like the for version much better, it looks neater to me and works perfectly.

As a bonus, you can now handle the case when no results are returned at all:

$count = mysql_num_rows($table);
if($count>0)
{ for($i=0;....)
   {....}
}
else
{
 // No results, do something else.
}