[Resolved] comparing array values

[knighthawk1337]

I am having problems with an array. The array is created from a list of filenames in a text file. I have a variable that i'm trying to find in an array and find the position of it. My code is not finding it at all and I don't know why. Here is the code.

$file = picture.jpg

$filename ="./gallery/photos/gallery.txt"; 
$picarray = file($filename);

	for($i=0; $i<count($picarray); $i++){
		if($file==$picarray[$i]){
			echo "found";
		}
	}

please let me know if i left any information out

[TheDefender]

First thing's first... put quotes around your value:

$file = "picture.jpg";

Secondly, have you run a print_r on the array to make sure it has things in it?

$filename ="./gallery/photos/gallery.txt";  

$picarray = file($filename); 

print_r($picarray); // add this to make sure it has values defined in it.

    for($i=0; $i<count($picarray); $i++){ 
        if($file==$picarray[$i]){ 
            echo "found"; 
        } 
    }

[knighthawk1337]

the original code is not really

$file = photo.jpg;

its accually

$file = $_GET['file'];

i just put what should be in there.

and yes i have already done the print_r and everything looks fine in the array.

[TheDefender]

OK, within the for loop then, echo the $file variable, and the $picarray[$i] variable to see what's actually being compared:

for($i=0; $i<count($picarray); $i++){  

echo $file." ".$picarray[$i]."<br />";
            if($file==$picarray[$i]){  

                echo "found<br />";  

            }  

        }

This may just point you in the direction to figuring out why it isn't behaving as expected.

[Paul_Jr]

What about the in_array(); function?

<?php
   $file = 'foo.jpg';
   $file_arr = file('dir/subdir/file.txt');
   if(in_array($file, $file_arr)) {
      echo 'Found!';
   }
   else {
      echo 'Not found';
   }
?>

Something smiliar to that.

EDIT
Okay, I wasn't able to get the above to work (maybe because there's a new-line appended to each array element in $file_arr), but this should work.

<?php
   $file = 'foo.jpg';
   $file_arr = file('files.txt');
   foreach($file_arr as $the_file) {
		if(trim($the_file) === $file) {
			echo 'Found!';
			break;
		}
		else {
			echo 'Not found';
			break;
		}
	}
?> 

[knighthawk1337]

I knew i was forgetting one little thing. I left out the trim. In my file the lines were terminated with a \r\n. That did it. Thanks for your help guys.

[TheDefender]

Be sure to mark the thread resolved using the "Mark Thread Resolved" link at the bottom. Have a nice week.