[Resolved] checkbox question

[commandonz]

I have an approval page for approving reviews, and the current way I work out if checkboxes is pretty crappy.

HTML

<input type="checkbox" name="1">(html removed)
<input type="checkbox" name="2">(html removed)

PHP

$approveArray = array();
      for ($i = 1; $i <= 1000; $i++) {
         $x = $_POST[$i];
         if ($x == 'on') {
            array_push($approveArray, $i);
         }
      }

Can anyone suggest a better way to do this? The id's i'm dealing with could get high enough, into the tens of thousands, so this could be a bit performance hit.

Thanks for any suggestions.

[zhabala]

<input type="checkbox" name="approvedArray[1]">(html removed)
<input type="checkbox" name="approvedArray[2]">(html removed)

Then after submit the $_POST['approvedArray'] is filled just as an array for those checkboxes which were checked on.

Zdenek

[TheDefender]

Actually, you don't want to define any index...

<input type="checkbox" name="approvedArray[]">(html removed) 
<input type="checkbox" name="approvedArray[]">(html removed)

Then, on your calling page, use a for loop to loop through the approvedArray that comes into the resulting POST array.

[zhabala]

You don't want to define an index only when the order of checkboxes corresponds with the index. And then it starts from index 0 not from index 1.

Zdenek

[commandonz]

Excellent, thanks guys. One follow up question. If I wanted values 2, 4, and 17 in the submitted array, i'd just do this?

<input type="checkbox" name="approvedArray[2]">(html removed)
<input type="checkbox" name="approvedArray[4]">(html removed)
<input type="checkbox" name="approvedArray[17]">(html removed)

Thanks

C

[TheDefender]

Yeah... that's how you'd go about it.

[commandonz]

Thanks for your help zhabala, TheDefender, people here are always great 🙂