Simple way to count # of all files in a folder

[scrupul0us]

Ive been told i can use glob() for this, but after spending sometime on php.net i cant seem to get a grasp on it

[epp_b]

If you are just counting the files in the current directory (and not recursing to sub-directories), then it's easy! 🙂

$dir = readdir("mydir");
while ($file = opendir($dir)) {
  if ($file != "." && $file != ".." && !is_dir("mydir/$file"))
    $num_files++;
}

Or better yet, if you're on a Linux box

$files = explode("\n", shell_exec("ls -1"));
$num_files = (count($files) - 1);

(Note, above code is ls -1 where "-1" is the number ONE, NOT a lowercase "L")

If you want to read all of the files in the directory and its sub-directories, you'll need to write a recursive function for that.

The pseudo code routine would be something like this:

function listFilesInDir {
  global $num_files
  $file = list_files_in_dir
  if (is_dir)
    listFilesInDir
  else
    $num_files++;
}

[scrupul0us]

$dir = readdir("mydir");
while ($file = opendir($dir)) {
  if ($file != "." && $file != ".." && !is_dir("mydir/$file"))
    $num_files++;
}

my adaptation:

<?
$file_dir = "./";
echo "<div id=\"objects\"><div align=\"left\">";
while ($file = opendir($file_dir)) {
  if ($file != "." && $file != ".." && !is_dir("$file_dir/$file"))
    $num_files++;
}
echo $num_files . " Files";
echo "</div></div>";
?>

causes timeout on the page

[scrupul0us]

bump

[Weedpacket]

Here's what comes of cut-and-pasting code without trying to understand what it does - you go crashing into brick walls on every little typo. Look up [man]readdir[/man] and [man]opendir[/man] and see if you can't figure out where the typos are.

[drawmack]

$dir = readdir("mydir");
while ($file = opendir($dir)) {
  if ($file != "." && $file != ".." && !is_dir("mydir/$file"))
    $num_files++;
}

Since you're including two special cases (which will always occur exactly once) you're forcing your processor to do 3 checks on every file, except for twice. Wouldn't it be more efficient to do this:

$dir = readdir("mydir");
while ($file = opendir($dir)) {
  if (!is_dir("mydir/$file"))
    $num_files++;
}

This way you're only performing a single check on each file in the directory. I think that should speed things up considerably on a large directory.

NOTE: I intentionally did not remove the bug that's throwing the original poster off as we learn more through debugging then through any other process.

[devinemke]

if you have PHP5 you can use [man]scandir[/man].

[scrupul0us]

as of right now

<?
$file_dir = "c:\\";
echo "<div id=\"objects\"><div align=\"left\">";
$dir = @readdir("$file_dir") or die ("error");
while ($file = @opendir($dir)) {
  if (!is_dir("$file_dir/$file"))
    $num_files++;
}
echo $num_files . " Files";
echo "</div></div>";
?>

spits out error.. but i dont see how its an invalid dir

[Installer]

You should re-read Weedpacket's post