Cant redirect using header() when including a certain file

[harman]

hi!
I have a include file (inc-common_func.php) with the following functions:

function fix_input ($string){
  $string = trim ($string);
  $string = str_replace("\r\n", "\n", $string);
  $string = str_replace("\r", "\n", $string);
  $string = addslashes ($string);
  $string = mysql_escape_string ($string);
  $string = nl2br($string);
  $string = str_replace('2 back slashes here','',$string); //cant show 2 back slashes so
  $string = addslashes($string);
  return $string;
}

function fix_output ($string){
    $string = nl2br($string);
    $string = str_replace('\\','',$string);
    $string = stripslashes($string);
    $string = htmlspecialChars($string);
    return $string;
}

i have included this file in image_add_edit.php
in the page when i try to redirect:
header('Location: mng_prod_image.php?flag=1');

i get the following error:

Warning: Cannot modify header information - headers already sent by (output started at /home/tpsadmin/inc-common_func.php:43) in image_add_edit.php on line 68

Does anybody know why??

[TheDefender]

It means you are outputting something to the browser before your header call...
Check here in this file (inc-common_func.php) and see if one of your functions (around line 43) is outputting something to the browser... The code you posted doesn't even have 43 lines, so sorry I can't give more specific help. Post more code.

[harman]

<?
function fix_input ($STR){
  $STR = trim ($STR);
  $STR = str_replace("\r\n", "\n", $STR);
  $STR = str_replace("\r", "\n", $STR);
  $STR = addslashes ($STR);
  $STR = mysql_escape_string ($STR);
  //$STR = htmlspecialchars ($STR);
  $STR = nl2br($STR);
  $STR = str_replace('\\','',$STR);
  $STR = addslashes($STR);
  return $STR;
}

function fix_output ($STR){
    $STR = nl2br($STR);
    $STR = str_replace('\\','',$STR);
    $STR = stripslashes($STR);
    $STR = htmlspecialChars($STR);
     return $STR;
}

function checkUserId($uid){
	$sql = "SELECT user_name FROM customer WHERE user_name='".$uid."'";
	$result = mysql_query($sql);// or die(mysql_error());
	if(mysql_num_rows($result) > 0){
		return false;
	}else{
		return true;
	}
}//end checkUserId 

//functions to create an image drop down
function createImageList($i_id){
	$list .= '<option value=""> </option>';
	$sql = "SELECT * FROM prd_image ORDER BY img_name";
	$result = mysql_query($sql) or Die($sql);
	while($print = mysql_fetch_object($result)){
		$select = ($i_id==$print->img_id)?'selected':'';
		$list .= "<option value=\"$print->img_id\" $select>".stripslashes($print->img_name)."</option>";
	}
	return $list;
}
?>//this is line 43

[TheDefender]

Well, looking through your functions, it looks as though you are calling function createImageList($i_id), since that is the only function outputting to the browser... If you send output to the browser (ie, the HTML for the <option> tags, then you can't modify the headers using a header() call.

What is line 68 in image_add_edit.php? (along with a few lines before that and after)

[harman]

if(!$err){ //passed all stages
    $msg = $file_name.' has been uploaded';
    header('Location: mng_prod_image.php?flag=1');//line 68
}

line 68 is the header call. I think the prob is with the two functions fix_output ($STR) and fix_input($STR), cos when i remove them it works fine.

[TheDefender]

Try changing the single-quotes to double-quotes in the str_replace functions... See how my color coding looks right, and yours turns red at the first str_replace with the single-quotes?

function fix_input ($STR){ 
  $STR = trim ($STR); 
  $STR = str_replace("\r\n", "\n", $STR); 
  $STR = str_replace("\r", "\n", $STR); 
  $STR = addslashes ($STR); 
  $STR = mysql_escape_string ($STR); 
  //$STR = htmlspecialchars ($STR); 
  $STR = nl2br($STR); 
  $STR = str_replace("","",$STR); 
  $STR = addslashes($STR); 
  return $STR; 
} 

function fix_output ($STR){ 
    $STR = nl2br($STR); 
    $STR = str_replace("","",$STR); 
    $STR = stripslashes($STR); 
    $STR = htmlspecialChars($STR); 
     return $STR; 
}

[harman]

no nothing, still get the same error...by the way
$STR = str_replace("","",$STR);
is
$STR = str_replace("\"," ",$STR);
i.e with 2 backslash, here are not being shown for some reason

[alvinkoh]

harman,

Just eliminating the possibilities, another check to look out for is ensuring that there isn't any white space before/after your PHP tags.

<?php
  // code starts here
?>

versus

[line break] <-- don't want any of these either
<?php
  // code starts here
?>[space] <-- check that there isn't any white space characters or line breaks after the php closing tag.

[harman]

When i use include_once() instead of include() it works...can any body explain this...

[SD-Syndicate]

Hi harman,

Im not sure if this will work for you but you can always try it.

What I had to do was make sure to remove all the <head> and </head>`s from all my include pages but the main page. And I stopped getting those errors 🙂

Hope it works for you.

[harman]

Hi SD,
I got it to work, i used include_once instead of include. Now i dont get that error. But i cant seem to understand why it would work with include_once() and not include()...thanks for your suggestion though.

[alvinkoh]

Originally posted by harman
Hi SD,
I got it to work, i used include_once instead of include. Now i dont get that error. But i cant seem to understand why it would work with include_once() and not include()...thanks for your suggestion though.

Harman,

Strange indeed. Do you have recursive includes, or perhaps functions with the same names in your scripts?

If you have functions with identical names, the error produced would most certainly be different as well, e.g. "cannot redeclare function, etc".