[Resolved] getting weird problem (1064) in db query

phpjaco

Have the following problem whenever I update:

I get a 1064 error but this is weird bacause here is my statement:

if ($newtext2) {
$writetext = "<p>".ereg_replace("(\n|\r)+","<p></p>",$newtext)."</p>";
} else $writetext = $row['pub_text'];

if i comment out the else statement the error is no longer there.

but i use $row['pub_text'] in alot of other places and this doesnt seem to ever give a problem.

what could this be?!:rolleyes:

thank you in advance

this problem actually started when I removed fields from my table and the ones (tables) that have fields removed seem to give me this problem.

TheDefender

Error 1064... Is that something like this:

"ERROR 1064: You have an error in your SQL syntax near......."

Give the exact error you are getting, because if that is the error, it shouldn't have anything to do with the code you provided here. It has everything to do with your SELECT MySQL statement.

phpjaco

Could not update : 1064 You have an error in your SQL syntax near 'Turbanators" And The Terrorists: War Crimes And Media Omissions

1.9 Media ' at line 1

this is my update query :

$sql = "update publications set heading = \"$writeheading\", subheading = \"$writesub\", pub_text = \"$writetext\", date_pub = \"$writedate\",image = \"$writeimg\", image_type = \"$writeimg_type\", image_size=\"$writeimg_size\", contact_name = \"$writename\", contact_email = \"$writeemail\", contact_number = \"$writenumber\" where heading = \"$heading\"";

$rs = mysql_query($sql,$conn);
if ($rs) {
header("Location:website_change_publications.php");
} else $msg2 = "Could not update : ". mysql_errno(). " " .mysql_error();
}

btw - how do you guys get your code in php in here, cause if i use the php button it only gives an option to paste one line in at a time?!

TheDefender

Try this instead:

$sql = "UPDATE publications SET heading = '".$writeheading."', subheading = '".$writesub."', pub_text = '".$writetext."', date_pub = '".$writedate."',image = '".$writeimg."', image_type = '".$writeimg_type."', image_size='".$writeimg_size."', contact_name = '".$writename."', contact_email = '".$writeemail."', contact_number = '".$writenumber."' WHERE heading = '".$heading."'";

xblue

while this is definitely cleaner - may there be a problem with unescaped quotes? phpjaco, what does the complete (parsed) query look like?

for your other question, you can simply type
[ PHP ][ /PHP ] (w/o spaces). I never used the button 😉

phpjaco

hello

I have tried the cleaner code the defender posted but this made no difference.

$list .= "<tr valign=\"top\"><td bgcolor=\"#DBDBDB\" class=\"tableheaders\"><b>Publication text:</b></td><td bgcolor=\"#F2F2F2\" class=\"tablecopy\">".$row['pub_text']."</td><td bgcolor='#DBDBDB' class=\"tableheaders\"><b>New publication text:</b></td><td bgcolor=\"#F2F2F2\" class='tablecopy'><textarea name=\"newtext2\" cols='60' rows='80' style=\"overflow:auto; padding-left:3px; font-family: Arial, Helvitica, sans-serif; font-size: 7pt; color:#7F7F7F; background: #FAFAFA;  border-style: solid; border-width: 1px ;border-color: #999999;\"></textarea></td></tr>";

this is the code on my form (the page before the error page) have tried both $row['pub_text'] and $row["pub_text"] both result in an error.

ok moving on the next page:

if ($newtext2) {
		  $writetext = "<p>".ereg_replace("(\n|\r)+","<p></p>",$newtext)."</p>";
		 } else $writetext = $row["pub_text"];

this basically checks if a user has entered something in the field if not put writetext to the current field.

then my update query:

$sql = "update publications set heading = \"$writeheading\", subheading = \"$writesub\", date_pub = \"$writedate\",image = \"$writeimg\", image_type = \"$writeimg_type\", image_size=\"$writeimg_size\", contact_name = \"$writename\", contact_email = \"$writeemail\", contact_number = \"$writenumber\", pub_text = \"$writetext\" where heading = \"$heading\"";

	$rs = mysql_query($sql,$conn) or die(mysql_errno() . mysql_error());
	if ($rs) { ....

it is an unescaped " or ' that causes the error because when it gives me an error it says:

1064You have an error in your SQL syntax near 'Turbanators" And The Terrorists: War Crimes And Media Omissions

1.9 Media ' at line 1

so obviously the Media' breaks the code but dont underestand this never had this problem before?

TheDefender

Go back and edit your post to change the <php> to

Do the same with the </php>, so we can get a quick glance at your code.  In a little bit, I will copy and paste your code into my IDE for color coding, but in the mean time, make that change for others.

phpjaco

i had :

  if ($newtext2) {
		  $writetext = "<p>".ereg_replace("(\n|\r)+","<p></p>",$newtext)."</p>";
		 } else $writetext = $row["pub_text"];

instead of :

  if ($newtext2) {
		  $writetext = "<p>".ereg_replace("(\n|\r)+","<p></p>",$newtext2)."</p>";
		 } else $writetext = $row["pub_text"];

strange that it gave me the error that it did but damn such a stupid error.

thanks for all the help tho.