Weird Movement Problem

GundamSV7

Hey there, I'm having a really weird movement problem in a script I'm writing that I just can't seem to figure out. Here is the code for it:

if($move == up) {
	if($world[y]+1 == "") {
	} else {
	mysql_query("UPDATE players SET y=(y+1) WHERE username = '$userinfo[username]'");
	}
} elseif($move == left) {
	if($world[x]-1 == "") {
	} else {
	mysql_query("UPDATE players SET x=(x-1) WHERE username = '$userinfo[username]'");
	}
} elseif($move == right) {
	if($world[x]+1 == "") {
	} else {
	mysql_query("UPDATE players SET x=(x+1) WHERE username = '$userinfo[username]'");
	}
} elseif($move == down) {
	if($world[y]-1 == "") {
	} else {
	mysql_query("UPDATE players SET y=(y-1) WHERE username = '$userinfo[username]'");
	}
}

On the game screen, I simply have 4 arrows that link to game.php?move=x. Now, this script should in theory simply move the character once in the direction they click, but here's the weird part, lets say I click up, it'll add +1 to the Y variable, but then I click right next, it'll still add +1 to Y, it's only after the 2nd time I click right that it'll add +1 to X. Same thing happens no matter what direction I go. Any clue what I'm doing wrong?

TheDefender

Quote the directions in your if and elseif statements...

if($move == "up") {

Also, if your register globals is off, then you need to refer to the $move variable from the $GET array... so before the if/else, do something like this:

$move = $_GET['move'];

Or in each case, refer to it from the array:

if($_GET['move'] == "up") {

GundamSV7

Hey, I tried both ways and none worked. I did notice something else I forgot to mention though. After the first time I click up, for example, the page still says im at coord 1,1 but the mysql table says im at 1,2. Any idea why the array would say I'm at 1,1 and not 1,2?

GundamSV7

I think I found the problem, whenever a user clicks a direction, it sets the URL game.php?move=direction. Therefore it's not processing the commands until that variable hits the chains of if-then statements. Any idea how to fix this problem? 🙂

tsinka

Hi,

it's hard to say anything ... we need more code. One problem might be that the code that updates the tables comes after the code that displays the game screen. Move the update code on top of the script if that is the case. Or post more code so we can see what might be wrong.

Thomas