problems retrieving db fields

[raymie7]

Hi,
I'm using the following php code to try and retrieve some fields from a db but I keep getting the message:
mysql_fetch_array(): supplied argument is not a valid MySQL result resource.

This is what I have so far..
<?php
$result=mysql_fetch_array(mysql_query("SELECT c.accession_number, location_id
FROM CARDBOX c, PRODUCT_LOOKUP pl, PRODUCTS p
WHERE p.product_id = $td[$i]['product_id']
AND pl.product_id = p.product_id
AND c.cardbox_id = pl.cardbox_id "));

mysql_close(); ?>
<td <?php echo $style ?>><?php echo $result[accession_number];?>_</td>

Thanks for any help.

[jonno946]

That query does not look right at all.

Reconsider it.

I would give it a go myself but im not too sure where 2 start 😕

Also your coding seems to be a right mess.

Try this

<?php

$query = mysql_query("Query Here");

$result = mysql_fetch_array($query);

mysql_close();

echo "<td " . $style . ">" . $result[accession_number] . "</td>";

?>

[raymie7]

I've tidied the code up a bit using your structure, thanks. Still doesn't work though. Is the problem with my query then given the error message I'm receiving?

Code is now..
<?php
$query = mysql_query("SELECT c.accession_number, location_id
FROM CARDBOX c, PRODUCT_LOOKUP pl, PRODUCTS p
WHERE p.product_id = $td[$i]['product_id']
AND pl.product_id = p.product_id
AND c.cardbox_id = pl.cardbox_id ");

$result = mysql_fetch_array($query);
mysql_close(); ?>

<td <?php echo $style ?>><?php echo $result[accession_number];?>_</td>

[Weedpacket]

<?php
$result=mysql_fetch_array(mysql_query("SELECT c.accession_number, location_id
FROM CARDBOX c, PRODUCT_LOOKUP pl, PRODUCTS p
WHERE p.product_id = ".$td[$i]['product_id']."
AND pl.product_id = p.product_id
AND c.cardbox_id = pl.cardbox_id "));

mysql_close(); ?>
<td <?php echo $style?>><?php echo $result['accession_number']?>_</td> 

When having trouble with your queries, try using mysql_error(). Other tips that could have saved you some trouble can be found in the Debugging 101 thread over in the Echo Lounge (it's stuck to the top of the forum). One thing to consider doing is putting the query into a variable, and then putting the variable into mysql_query(). Then, if things go wrong, you can look in that variable to see what the query was that you actually sent to the DBMS (the aforementioned Debugging thread suggests a rather elegant way of doing this).

PS: and when writing PHP code here, try using &#91;php] tags - it makes the stuff a lot easier to read.