[Resolved] Passing hidden values

lsh

I have a form whereby it will first echo out the message in the textarea. Users can make any changes to the message in the textarea. Afterwhich, the updated message is sent to the database.

I used hidden values to determine whether the message is to be echo out or needs to be edited. The error is that the form cannot read the hidden value for updating the article .

Any help would be much appreciated.

Below shows parts of the code:

<? require('e:\inetpub\ftproot\Dumexadmin\wwwroot\revamproot\include\common.php');
  function replaceQuote($text)
{
	$text=str_replace("\'", "'", $text);
	$text=str_replace("'", "&#39;", $text);
	$text=str_replace('\"',"&#34;",$text);
	$text=str_replace('"',"&#34;",$text);
	return $text;
}

db_connect($conn);

$summary = trim(replaceQuote($summary));
$body = trim(replaceQuote($body));
$datesubmitted = date("m-d-Y H:i:s");
if(!IsSet($stage)) { 
?>

// this part of the form uses the article id to determine which article to be edited

<form method="post" name="form1" action="<?php print ("$PHP_SELF");?>" onSubmit="return confirmSubmit();">
						  <TR> 
<TD valign=top align=left bgcolor="#FDEBEC"><b>Article ID: </b></TD></TR>
<TR> 
<TD valign=top align=left> 
     <input type="text" name="art_id">
     <input type="hidden" name="stage" value="1">
    <input name="submit" type="submit" id="submit_id" value="Submit">
 </TD>
 </TR></form>
						  <? } else if ($stage == 1)
       {$query = "Select summary,body from healthnews where art_id = '$art_id'";
         $rsc = odbc_exec($conn, $query);
         $summary = odbc_result($rsc,"summary");
         $body = odbc_result($rsc,"body");
?>

// this part of the form echo out the summary and body text of the article

<form name="form2" method="post" action="body_update.php">
<TR>  

<TD valign=top align=left bgcolor="#FDEBEC">
  <p align="center"><strong>Article ID: <? echo $art_id ?></strong>
 <br>  

<strong>Summary:</strong></p></TD>
</TR>

<TR> 
<TD valign=top align=center> <p align="center"> 
<textarea name="summary" cols="80" rows="5" id="summary"><? echo $summary?></textarea>
</p> </TD>      

</TR>

<TR> 
<TD valign=top align=center bgcolor="#FDEBEC"><b><p align="center">Body:</p></b></TD>
</TR>

<TR> 
<TD valign=top align=left> <p align="center"> 
<textarea name="body" cols="80" rows="30" id="textarea"><? echo $body ?></textarea>
 </p>
<p align="center"> 
<input type="hidden" name="stage" value="2">
<input type="submit" name="Submit" value="Submit">
</p></TD> 
</TR>
</form>

//this part of the form should update the article

<? } else if ($stage==2)
 {$sqls = "update healthnews set summary='$summary', body='$body' where art_id='$art_id'";
$result = odbc_exec($conn,$sqls);	

  if ($result == 0)
    print ("Data is not inserted.");	
  else
    print ("Article has been updated.");
}?>

😕 lsh

PallaviDalvi

well when i tried ur peice of code... it did take the value of the hidden field...but with slight changes. i assume the same reason applies to ur case.
in ur php.ini the register_global directive is set to off and u are using $stage... in which case $stage is considered as a normal variable and not the one being posted. so u need to access it as $_POST['stage'] and so on for the other posted variables. or u cud turn the directive to on(which is not a good practise ... as suggested by the PHP gurus on this forum. ) apart from that i dont see any thing amiss in the code...

lsh

I appreciate your reply.
I tried your metnod, it still didn't work. It captures the hidden value of stage==1 but not stage==2. Even though it shows "Article has been updated", the article in the database is still the same.
Initially I wanted to pass the hidden value of stage==2 to the next page. But it seems like the value didn't managed to pass through. Is there any way to solve it?

Thanks
Below is are my codes(full):

body_update.php

<? require('e:\inetpub\ftproot\Dumexadmin\wwwroot\revamproot\include\common.php');
  function replaceQuote($text)
{
	$text=str_replace("\'", "'", $text);
	$text=str_replace("'", "&#39;", $text);
	$text=str_replace('\"',"&#34;",$text);
	$text=str_replace('"',"&#34;",$text);
	return $text;
}

db_connect($conn);

$summary = trim(replaceQuote($summary));
$body = trim(replaceQuote($body));
$datesubmitted = date("m-d-Y H:i:s");
if(!IsSet($stage)) { 
?>
<html>
<head>
<title>YoungNutrition.net</title>
<script language="JavaScript">
function confirmSubmit(){
if (confirm("Are you sure you want to submit?"))
	return true;
else 
	return false;
}
</script>
 <script src="login_update.js"></script>
 <script language="JavaScript">
  checkCookie();
 </script>
</head>
<body bgcolor="#FDEBEC" leftmargin="0" topmargin="0" marginwidth="0" marginheight="0">
<table border="0" cellspacing="0" cellpadding="10" align=center valign=middle width=100% height=100%>
  <tr>
    <td>
      <table border="0" cellspacing="0" cellpadding="0" bgcolor=#FFFFFF width=590 align=center>
        <tr> 
          <td valign="top" align="center"> 
            <table width="93%" border="0" cellspacing="0" cellpadding="0">
         <tr> 
                <td valign="top"> 
                  <div class="hometext"> 
                    <p align="left">Fill in the article ID and the body text for Health News section: <br>
                      <table width="100%" border=1 cellspacing=0 cellpadding=3 bordercolor="#F0EBEC">
                        <form method="post" name="form1" action="<?php print ("$PHP_SELF");?>" onSubmit="return confirmSubmit();">
						  <TR> 
                            <TD valign=top align=left bgcolor="#FDEBEC"><b>Article 
                              ID: </b></TD>
                          </TR>
                          <TR> 
                            <TD valign=top align=left> 
                              <input type="text" name="art_id">
							  <input type="hidden" name="stage" value="1">
						  <input name="submit" type="submit" id="submit_id" value="Submit">
                            </TD>
                          </TR></form>
						  <? } else if ($stage == 1)
					  	{$query = "Select summary,body from healthnews where art_id = '$art_id'";
					  	$rsc = odbc_exec($conn, $query);
						$summary = odbc_result($rsc,"summary");
						$body = odbc_result($rsc,"body");
?>
<form name="form2" method="post" action="body_update.php">
 <TR> <TD valign=top align=left bgcolor="#FDEBEC">
<p align="center"><strong>Article ID: <? echo $art_id?></strong><br><br>
  <strong>Summary:</strong></p></TD>
 </TR>
                          <TR> 
                            <TD valign=top align=center> 
                              <p align="center"> 
                                <textarea name="summary" cols="80" rows="5" id="summary"><? echo $summary?></textarea>
                              </p>
                            </TD>
                          </TR>
                          <TR> 
                            <TD valign=top align=center bgcolor="#FDEBEC"><b><p align="center">Body:</p></b></TD>
                          </TR>
                          <TR> 
                            <TD valign=top align=left> 
                              <p align="center"> 
                                <textarea name="body" cols="80" rows="30" id="textarea"><? echo $body ?></textarea>
                              </p>
                              <p align="center"> 
	  <input type="hidden" name="stage" value="2">
	<input type="submit" name="Submit" value="Submit">
</p>   </TD> </TR><br></form>
</table>
                    </div>
                  </div>
                </td>
              </tr>
            </table>

      </td>
    </tr>
    <tr> 
      <td>&nbsp;</td>
    </tr>
    <tr> 
      <td valign=top>&nbsp;</td>
    </tr>
  </table>
</td>
  </tr>
</table><? } ?>

</body>
</html>

Here's the next page; body_update_submit.php

<?
require('e:\inetpub\ftproot\Dumexadmin\wwwroot\revamproot\include\common.php');

function replaceQuote($text)
{
	$text=str_replace("\'", "'", $text);
	$text=str_replace("'", "&#39;", $text);
	$text=str_replace('\"',"&#34;",$text);
	$text=str_replace('"',"&#34;",$text);
	return $text;
}
    db_connect($conn);

$summary = trim(replaceQuote($summary));
$body = trim(replaceQuote($body));


if(IsSet($stage==2)) { 
	$sqls = "update healthnews set summary='$summary', body='$body' where art_id='$art_id'";
	$result = odbc_exec($conn,$sqls);	

?>	
<html>
<head>
<title>YoungNutrition.net</title>
<script language="JavaScript" src="/include/global.js"></script> 
</head>
<body bgcolor="#FDEBEC" leftmargin="0" topmargin="0" marginwidth="0" marginheight="0">
<table border="0" cellspacing="0" cellpadding="10" align=center valign=middle width=100% height=100%>
  <tr>
    <td>
      <table border="0" cellspacing="0" cellpadding="0" bgcolor=#FFFFFF width=590 align=center>
        <tr>
          <td rowspan="9" valign=top bgcolor=#FA3E40><img src="/corporate/images/1pixel.gif" width="1" height="1"></td>
          <td bgcolor=#EA3E40><img src="/corporate/images/1pixel.gif" width="1" height="1"></td>
          <td rowspan="9" valign=top bgcolor=#EA3E40><img src="/corporate/images/1pixel.gif" width="1" height="1"></td>
        </tr>
        <tr>
          <td valign="top" align="center">
            <table width="93%" border="0" cellspacing="0" cellpadding="0">
  <tr><td valign="top"><div class="hometext"><p align="left"><br>  

<form method="post" action="body_update.php">  Would you like to make more updates?  

<input type="text" name="art_id">  

<input type="hidden" name="stage" value="1">
<input name="submit_more" type="submit" id="submit_more">
 </form>	
<? if ($result == 0)
print ("Data is not inserted.");
else
print ("Article has been updated.");
?>
   <p align="left">Date Submitted <?=$datesubmitted = date("m-d-Y H:i:s")?>
                    </div>
                  </td>
              </tr>
            </table>
          </td>
        </tr>
        <tr>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td valign=top><form action="" name="frmLogoff">
  						<input type="button" name="btLogoff" value="log out" onclick="logout();">
						</form></td>
        </tr>
 </table>
    </td>
  </tr>
</table><? } ?>
</body>
</html>

😕 lsh

PallaviDalvi

am not sure... but try removing the single quotes in the query...
$sqls = "update healthnews set summary='$summary', body='$body' where art_id='$art_id'";
variable substituition does not take place in single quotes....and maybe thats the reason why the query is executing succesfully but the results are not actually moved to the database.
if this doesnt solve the prob....let me know exactly whats going to the database.

lsh

The article still doesn't get updated in the database.
It remains the same as it is when I first added the article.
The content only gets updated when i manually key in the art_id in the code.
Any solutions to this?

PallaviDalvi

well...this is kind of crude...but i do it and suggest when the query doesnt seem to be doing its work acc. to wishes!
1. echo the output of the substituited query string...ie. $sqls
2. copy the contents and execute the query in the sql environment.
this way u wud know the database errors if any.
also use error_repoting(E_ALL); in the PHP file to see if there are errors.
atleast i cant spot any logical or syntax errors but then i'm short sighted!
get back if this doesnt help u any further. 🙂

lsh

I did an echo on the sql statement. The values of $summary and $body can be passed over from body_update.php to body_update_submit.php but not the art_id.
Hence, the database is not updated even though the sql is executed sucessfully.

Below shows the code and output

	$sqls = "update healthnews set summary=$summary, body=$body where art_id=$art_id";
	$result = odbc_exec($conn,$sqls);	
	echo $sqls;
	error_reporting(E_ALL);

Result:
Warning: odbc_exec(): SQL error: [Microsoft][ODBC SQL Server Driver]COUNT field incorrect, SQL state 07001 in SQLExecDirect in e:\inetpub\ftproot\dumexadmin\wwwroot\revamproot\parents\healthnews\body_update_submit.php on line 20

update healthnews set summary=this is only a test, body=
This is only a test

This is only a test

where art_id=

So, is there any way that i can retain the value of art_id from body_update.php to be passed to boby_update_submit.php?

Really appreciate your help very much.Thanks!

lsh

PallaviDalvi

where and how are u passing values from body_update.php to body_update_submit.php? if u cud just highlight that part in ur posted code... wud be easier for me 😉
ps: i'm sorry but the sql does need the quotes around the variables....

PallaviDalvi

ok i assume that form2 is posting to body_update_submit.php.
in the body_update.php write the value of $art_id in a textbox(or hidden field). then it will be posted to the body_update_submit.php. only controls and their values are posted.... in the current situation $art_id is not stored in any control of body_update.php and hence is not posted! hopefully this solves the prob. 🙂

lsh

IT WORKS!!!
Thank you so much!!!
I couldn't have solved it without your very much appreciated help.
Thanks for taking the time to look at my long codes and helping me to debug.
Thanks again!!

lsh

PallaviDalvi

u embarass me! :o Ur obviously welcome!!