Adding Issue

NZ_Kiwi

I have two problems with this code
1/ Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/httpd/vhosts/site.com/httpdocs/counter2.php on line 11 (line 11 starts $row = mysql

2/ it does not stop adding my IP evertime i goto the page...

connect stuff

$newIP = $_SERVER['REMOTE_ADDR'];
$self = $_SERVER['PHP_SELF'];
$time = time();

$result = mysql_query ("SELECT * from counter where IP = $newIP"); 
$row = mysql_fetch_array($result);

$timestamp = $row["timestamp"];


if ($timestamp  >= $time - 600)
{
exit();

} else {
$result2 = mysql_query ("INSERT INTO counter (`id`,`IP`,`page`,`timestamp`) Values ('','$newIP','$self','$time')") or die("INSERT error: ".mysql_error()); 
}

?>

laserlight

$newIP is a string, you need to enclose it in (single) quotes.

NZ_Kiwi

Originally posted by laserlight
$newIP is a string, you need to enclose it in (single) quotes.

:p of course

what about the if statement??? what is wrong there?

TheDefender

Before your if statement, to debug a bit, echo your $timestamp and $time variables to see what is actually being compared.

It looks like once you implement laserlight's fix, it should resolve the problem with the if statement, since you should be getting a proper value pulled from the DB.

Also, in your query, why do SELECT *... when you are only using the timestamp field? Change your select statement to SELECT timestamp... instead.

NZ_Kiwi

Originally posted by TheDefender
Before your if statement, to debug a bit, echo your $timestamp and $time variables to see what is actually being compared.

It looks like once you implement laserlight's fix, it should resolve the problem with the if statement, since you should be getting a proper value pulled from the DB.

Also, in your query, why do SELECT *... when you are only using the timestamp field? Change your select statement to SELECT timestamp... instead.

yeah works well with a do echo for the $timestamp problem is i don't want users to see this, any other options?

NZ_Kiwi

Originally posted by NZ_Kiwi
yeah works well with a do echo for the $timestamp problem is i don't want users to see this, any other options?

Any Ideas?