if (statement && statement) fails always

[phonnold]

Newbie here so hopefully I am just missing something simple here.

Why does the following code always say that it passed the check

$clientnum = "12345";

if (ereg('[^0-9]', $clientnum) && strlen($clientnum) !== 4){
  echo "Check failed";
}
else {
  echo "Check passed";    

}
[code=php]

$clientnum = 1a345 it fails as it should
$clientnum = 12345 if passes it and should not

I want to make sure that $clientnum is only 4 numbers long and is only numbers.  If fails I will have a error appear and have the user fix the problem.  It works if I only do 1 check but not if I do both of them.

What am I missing here?

Thanks in advance

[TheDefender]

No need for ereg. [man]is_numeric[/man] will do the trick.

$clientnum = "12345"; 

if (is_numeric($clientnum) && strlen($clientnum) == 4) { 
echo "Check Passed"; 
} else { 
echo "Check Failed"; 
}

[phonnold]

Here is what I got working.

if (ereg("[^0-9]", $clientnum) || strlen($clientnum) !== 4)
{
	echo 'go back and fix error';
	exit;
}

//Run this code as the clientnum is correct
[code=php]

Thanks for the idea TheDefender, you got me looking at this problem in a different way and that is what I needed.

[TheDefender]

No problem... Be sure to mark the thread resolved using the "Mark Thread Resolved" link located at the bottom of the page.

[jpmoriarty]

Also, I think it should be != and not !==. But if it's working then no probs!