Image uploads from form

ajdegans

Ok first, i know this has been asked over and over but none of that worked for me so im making a new thread <-- this one

Im developing a simple photo album and need some help with the uploading of images from the admin area.

i wrote this:

$getalbum="SELECT albummap FROM albums";
$getalbum2=mysql_query($getalbum) or die("Could not get albums");
$getalbum3=mysql_fetch_array($getalbum2);
$album=$_POST['album'];
$picture=$_POST['picture'];
$description=$_POST['description'];
if(strlen($_POST['picture'])>1) {
    $new_picture = "lg_$picture";
    copy(stripslashes($picture), "$getvars3[serverpath]images/gallery/$getalbum3[albummap]/$new_picture");
}
$insertphoto="INSERT INTO photos (album,picture,description) VALUES ('$album','$picture','$description')";
mysql_query($insertphoto)or die("Could not insert photo");
//print "<META HTTP-EQUIV = 'Refresh' Content = '1; URL =index.php'>";
print "Photo inserted.";

all i get is that the path is not valid in the line where copy is...

really weird since i have no clue how to solve it🙁

Anyway, all things are grabbed from a form that form is working well. ONLY the copy line doesnt work!

If someone can help, THANKS! 😃

ajdegans

alright now i found out the complete upload path (e:\docs\pics\vblah.jpg) is put in the database.

Then when i call the file to show it, obviously the path is wrong...

How do i fix that?

:quiet:

ajdegans

if i get this:

Warning: copy(E:\mijn documenten\Mijn afbeeldingen\cam\arnancam4.jpg): failed to open stream: No such file or directory in c:\program files\apache group\apache\htdocs\admin\addphoto.php on line 37

where is the fault?

source or destination!? 😕

rachel2004

check that the source file exists at the path that the PHP server is telling you in the error message that you posted.
you're right, uploading images is a common script. You are better served using an existing script than what you are using right now. You do not have any error checking and I'm not quites usre your first line of code is a SELECT statement.

Look at the functions:

move_uploaded_file
is_uploaded_file

in the PHP manual and you'll even see snippets of code on how to do what you're attempting.

Hope this helped.

ajdegans

hi rachel

i looked into the functions you suggested, i dont really see what youre up to since both dont make sense to me

is_uploaded_file .. checking if the file was uploaded, well obviously its not since the copy command does not work...

second, move_uploaded_file why would i do that i dont want to move a file on a server i want to upload (copy) it from my pc to a server...

enlighten me please 🙂

rachel2004

I don't know what you're using for your HTML form, but let's say you have an input field as follows:

Once you've selected the file on your PC to upload to the web server, your PHP script will process it. That's where the two functions that I mentioned:

is_uploaded_file
move_uploaded_file

come into work. The function is_uploaded_file verifies that you file has been uploaded as specified in the superglobal $FILES. Example:

if ( (isset($_FILES['picture']['name']) && 
      is_uploaded_file($_FILES['picture']['tmp_name']))) 
{ // more code to follow

Assuming you the condition is true, you next move your file to a permenant location on your web server since you do not want to simply dumpy all uploaded file to one place on your web server and leave it there. example:

move_uploaded_file($_FILES['picture']['tmp_name'], $base_dir.$filename);

At this point, you can use an INSERT statement to insert into the db with the variable $filename (in my example) being the path to your file. You are not INSERTing the actual image, but the reference (path) that points to the image.

Take a look again at the manual. The PHP manual has pretty clean examples and if you Google a little bit, you should be able to piece these suggestions together. Also, search PHPBuilder forums since, as you know, this is not an uncommon script.

HTH.

ajdegans

i see what you mean now 🙂
I will look into it soon ... keep you posted 😃

rachel2004

Please be sure to post back so your solution gets archived and someone else can benefit from it (giving back to the community).

ajdegans

i meant that in my last post 🙂

ajdegans

i still do not have it working.... for some reason the paths are wrong all the time...

i took a piece of code from a simple forum thing:

	
<?php
	$userfile = $_POST['userfile'];
		$album = $_POST['album'];
		$description = $_POST['description'];
		if (is_uploaded_file($userfile)) {

		$filename=$HTTP_POST_FILES['userfile']['name'];
		$type=pathinfo($filename);
		$ext=$type[extension];

		if($ext=="jpg" or $ext=="gif"){}
		else{ echo"error, file extension wrong!"; exit;  }
		$getvars="SELECT serverpath FROM bl_vars"; //get current variable values
		$getvars2=mysql_query($getvars) or die("Could not get variables");
		$getvars3=mysql_fetch_array($getvars2);
		$getalbum="SELECT albummap FROM albums"; 
		$getalbum2=mysql_query($getalbum) or die("Could not get albums"); 
		$getalbum3=mysql_fetch_array($getalbum2); 

		move_uploaded_file($userfile, $getvars3[serverpath]."/images/gallery/".$getalbum3[albummap]."/".$type['basename']);
		$avatar_addr=$getvars3[serverpath]."/images/gallery/".$getalbum3[albummap]."/".$type['basename'];
		$avatar_dim=GetImageSize($getvars3[serverpath]."/images/gallery/".$getalbum3[albummap]."/".$type['basename']);
		$av_w=640;
		$av_h=480;
		if(($av_w>$avatar_width)or($av_h>$avatar_height)){
			unlink($getvars3[serverpath]."/images/gallery/".$getalbum3[albummap]."/".$type['basename']);
			echo "picture to big";
			exit;
		}

	} else {
		echo"Sorry , there were problems uploading or you didn't fill in the right path...";exit;

	}
?>

I edited it a little but most is intact ... i only changed the vars to fit it in my site...

It gets stuck on the $http_post_files i think
though im not sure about that 🙁

any help appreciated