[Resolved] arrays merge/push question

[commandonz]

Gidday,

Can anyone suggest a better way to do this? I'm still not completely up to speed on php arrays.

$results = array();
while ($line = mysql_fetch_array($result, MYSQL_ASSOC)) {
   $count = getReviewCount($line['id'], $STATE_ACTIVE);
   $line2 = array_merge($line, array('reviewCount' => $count));
   array_push ($results, $line2);
}

TIA

C

[Weedpacket]

Hard to say if there's a "better way" without knowing what it's actually supposed to be doing.

But I'm going to take a punt:

$results = array();
while($line = mysql_fetch_assoc($result))
{
    $line['reviewCount'] = getReviewCount($line['id'], $STATE_ACTIVE);
    $results[] = $line;
}

[commandonz]

Yep, perfect thanks Weedpacket 🙂 I didn't know you could do that. Are there any good php arrays tutorials around? To me they're one of the more complex things in PHP. I'm used to Java arrays, or Pascal, or C.... PHP is just a little different.

What it's doing is getting data back from the database, then adding one more piece of data - the review count. It'd be better to do it in sql obviously, but what i'm trying to do makes it too hard. I'm not even sure it can be done. I got to the point where I had 2 inner joins and a couple of group bys, and i'd spent a fair bit of time on it, i'll take the performance hit to call the database 10 times instead of spending my time on it.

Thanks 🙂