uploading file

mohamad_1978

hello guys i use this code for uploading file


<?

if ($userfile_size > 30000) {
    print "Your file is too large. Please use your back button.";
    exit;

}



if (@copy ($userfile, "c:\uploads/$userfile_name")) {

# Delete the temporary file
unlink ($userfile);

# Thank the user
print "Thank you for your submission of $artist's $songname.
We have saved it in our temporary directory and will 
post it to our page shortly.";

} else {

# If the file couldn't be moved, we tell the user:
print "An error occurred during your submission.";



}

?>

first i want to make sure it is right or not

other think .. i use an apache in my windows xp as a server to run the php

and i want to upload the files to this folder (c:\uploads) what a steps i need to do ?

plz help me as soon as possible

thanks

PallaviDalvi

Buddy...best way to find out if ur code is correct or not...execute it and see if it does what u wanted it to... if it does...its correct...or else its not!
to upload to any dir...u need to have permissions to create a file. apart from that i dont think u need to do any thing. am not sure abt apache ...

mohamad_1978

i did run the code and i get this message

An error occurred during your submission.

this mean it is not upload the file

PallaviDalvi

well.... firstly, when u are in the testing phase...its a bad idea to use @ ...

if (@copy ($userfile, "c:uploads/$userfile_name"))

if u remove it... many more specific errors wud be displayed to u. also use error_reporting(E_ALL).
and to know exactly how PHP lets u handle file uploads...consult this on PHP.net

mohamad_1978

thanks alot for trying to help

i try to remove the test and stell nothing happent

....

now i try the page u gave me and stell not upload the file and give me this message

Possible file upload attack!
Here is some more debugging info:

PallaviDalvi

donno whats wrong ... maybe the permissions...check them once again...
however heres the code that does work in my case... maybe it cud help in some way.
the HTML

<font>Upload your Picture</font><br>
<input type="hidden" name="MAX_FILE_SIZE" value="9999999">
<input type=file name="userfile" >

the PHP part

$uploaded_name="test.jpg";
if (move_uploaded_file($_FILES['userfile']['tmp_name'], $upload_name))
{
	echo "file uploaded successfully";
}
else
{
	echo "oh oh ...some problem!";
}

try pasting this code in a dummy file and test for the dir and file that u want to upload...