Help with if statement

[C__Casey]

I have a query where I'm trying to limit the number of login attempts to 5. I need help writing my "if statement". What I have isn't working any advice would be appreciated.

<?
$query_rsquery = "SELECT credits FROM USERS WHERE username='$loginUsername'";
$rsquery = mysql_query($query_rsquery, $Users) or die(mysql_error());
$row_rsquery = mysql_fetch_assoc($rsquery);
$totalRows_rsquery = mysql_num_rows($rsquery);

	$row=mysql_fetch_assoc($rsquery);

if ($row >5) {
echo "Number of credits have exceeded 5";
header("Location: ". $MM_redirectLoginFailed );
}
else {
$updateSQL ="UPDATE USERS SET credits=credits+1 WHERE username='$loginUsername'";
header("Location: " . $MM_redirectLoginSuccess );
}

  mysql_select_db($database_Users, $Users);
  $Result1 = mysql_query($updateSQL, $Users) or die(mysql_error());

?>

[chintupintu03]

Hi C++Casey,

Regarding your "IF statement" :

---

$row_rsquery = mysql_fetch_assoc($rsquery);
$totalRows_rsquery = mysql_num_rows($rsquery);

$row=mysql_fetch_assoc($rsquery);

---

Why are you using "mysql_fetch_assoc" twice with separate variables ? As you are using a field to store the "credits",

after the statement :
$row_rsquery = mysql_fetch_assoc($rsquery);

use statement :
$row = $row_rsquery[0];

and use this ($row) for comparison in the "IF statement" :
if ($row >5)

[C__Casey]

Thanks for the help...it still didn't stop the user that had over 5 credits from logging in. I'll attach my login script, I don't know maybe somehow thats overiding the other query....

Login script below:

<?php
// *** Validate request to login to this site.
session_start();

$loginFormAction = $_SERVER['PHP_SELF'];
if (isset($accesscheck)) {
  $GLOBALS['PrevUrl'] = $accesscheck;
  session_register('PrevUrl');
}

if (isset($_POST['username'])) {
  $loginUsername=$_POST['username'];
  $password=$_POST['password'];
  $MM_fldUserAuthorization = "";
  $MM_redirectLoginSuccess = "http://yahoo.com";
  $MM_redirectLoginFailed = "login.php";
  $MM_redirecttoReferrer = false;
  mysql_select_db($database_Users, $Users);

  $LoginRS__query=sprintf("SELECT username, password FROM USERS WHERE username='%s' AND password='%s'",
    get_magic_quotes_gpc() ? $loginUsername : addslashes($loginUsername), get_magic_quotes_gpc() ? $password : addslashes($password)); 

  $LoginRS = mysql_query($LoginRS__query, $Users) or die(mysql_error());
  $loginFoundUser = mysql_num_rows($LoginRS);
  if ($loginFoundUser) {
     $loginStrGroup = "";

//declare two session variables and assign them
$GLOBALS['MM_Username'] = $loginUsername;
$GLOBALS['MM_UserGroup'] = $loginStrGroup;	      

//register the session variables
session_register("MM_Username");
session_register("MM_UserGroup");

if (isset($_SESSION['PrevUrl']) && false) {
  $MM_redirectLoginSuccess = $_SESSION['PrevUrl'];	
}
header("Location: " . $MM_redirectLoginSuccess );
  }
  else {
    header("Location: ". $MM_redirectLoginFailed );
  }
}
?>

script to limit login attempts by credits

<?
$query_rsquery = "SELECT credits FROM USERS WHERE username='$loginUsername'";
$rsquery = mysql_query($query_rsquery, $Users) or die(mysql_error());
$row_rsquery = mysql_fetch_assoc($rsquery);
$totalRows_rsquery = mysql_num_rows($rsquery);

$row = $row_rsquery[0];

if ($row >5) {
echo "Number of credits have exceeded 5";
}
else {
$updateSQL ="UPDATE USERS SET credits=credits+1 WHERE username='$loginUsername'";
}

$Result1 = mysql_query($query_rsquery, $Users) or die(mysql_error());
  $Result2= mysql_query($updateSQL, $Users) or die(mysql_error());

?>

[sidney]

your using mysql_fetch_assoc so the array is an associative one

$row_rsquery = mysql_fetch_assoc($rsquery);  

    if ($row_rsquery['credits']>5) { 
    echo "Number of credits have exceeded 5"; 
    } 
    else { 
    $updateSQL ="UPDATE USERS SET credits=credits+1 WHERE username='$loginUsername'"; 
    } 
 

[C__Casey]

Thanks for the feedback...The code still doesn't work...it doesn't stop the user who was over 5 credits from logging in. Any feedback is appreciated...this is driving me nuts!

[herve]

May be something like that :

<?PHP
$query_rsquery = "SELECT credits FROM USERS WHERE username='$loginUsername'";
$rsquery = mysql_query($query_rsquery, $Users) or die(mysql_error());

$row_rsquery = mysql_fetch_array($rsquery);

if ($row_rsquery)
{
	$row = $row_rsquery[0];

	if ($row > 5) 
	{
		echo "Number of credits have exceeded 5";
	}
	else 
	{
		$updateSQL ="UPDATE USERS SET credits=credits+1 WHERE username='$loginUsername'";
	$Result2= mysql_query($updateSQL, $Users) or die(mysql_error());    		
	}
}
else
{
	echo "User unknown ?";
}                     

?>

If it doesn't work too : what's happening to the "credits" value inside the table ? Climbing to 6,7, ... or ?

[C__Casey]

ok with the last post...the credits didn't increment at all, they are suppose to increment by 1....with the previous posts the credits incremented as they were suppose to....with all posts the user who logged in had credits over 5 and they were still able to login successfully...please help... my test user is up to 58 logins and counting...they were suppose to be crushed at 5....thanks again for all your posts ...keep them coming until this is solved...help

[chintupintu03]

Hello C++Casey,

With these round of exchanges of code, you must be now restless for getting the anaswer, isn't it?

Please find the following code ( though it may be simple one).

---

$query = "SELECT contact_id FROM member_d WHERE login_name like '";
$query = $query . $login_v;
$query = $query . "'";

$result = mysql_query($query) or die ("SELECT failed.");
$res = mysql_fetch_array($result);
$numrows=$res[0];
echo " <br>" ; echo "First time THE numrows has the value " ; echo $numrows ; echo "<br>" ;

if ($numrows > 100)
{
echo " contact ID is greater than ONE hundred" ; echo "<br>" ;

}
else
{
echo "contact ID is smaller than 100 " ; echo "<br>" ;
}

---

In the above case, $login_v contains the value given by the user. The query checks whether the entered login has ID value gretaer than 100 or not.

Hope this example is closer to your requirement. One more thing, display the field value you are referring in the IF statement.

Write echo $your_variable_name ;
before your IF condition.

[herve]

Ok, so let's try something more complete :

<?PHP

$mysql_login   = "your_MySQL_login_here";
$mysql_pwd     = "your_MySQL_password_here";
$database_name = "your_MySQL_database_name_here";

$db=mysql_connect("localhost",$mysql_login,$mysql_pwd);
mysql_select_db($database_name, $db); 

$query = "SELECT credits FROM USERS WHERE username='$loginUsername'";
$result = mysql_query ($query, $db);
$row = mysql_fetch_array($result);

if ($row)
{
	$credits = $row["credits"];

	if ($credits > 5) 
	{
		echo "Number of credits have exceeded 5";
	}
	else 
	{
		$query ="UPDATE USERS SET credits=credits+1 WHERE username='$loginUsername'";
	$result2= mysql_query($query, $db)

	if (!$result2)
	{	
		echo "Error when trying to update DB";
		echo "SQL was : $cmd<BR>";
		echo mysql_error();
		exit;
	}
	else
	{	echo "Update done, credits increased";
	}
	}
}
else
{
	echo "User unknown ?";
}                     

?>

and you can also check that $loginUsername (*)
has a value before the first request
otherwise ...

(*) a simple

print $loginUsername;

before will be enough.

[C__Casey]

Herve you are the man....it works...the final code is as follows:

<?PHP

$query = "SELECT credits FROM USERS WHERE username='$loginUsername'";
$result = mysql_query ($query, $Users);
$row = mysql_fetch_array($result);

if ($row)
{
	$credits = $row["credits"];

	if ($credits > 5) 
	{
		echo "Number of credits have exceeded 5";

		}
	else 
	{
		$query ="UPDATE USERS SET credits=credits+1 WHERE username='$loginUsername'";
	$result2= mysql_query($query, $Users);

	if (!$result2)
	{	
		echo "Error when trying to update DB";
		echo "SQL was : $cmd<BR>";
		echo mysql_error();
		exit;
	}
	else
	{	echo "Update done, credits increased";
	}
	}
} 
else
{ 
if ($loginUsername=="") {

echo "User does not exist";
}
}
?>

I dont know what you meant by your quote "and you can also check that $loginUsername (*)
has a value before the first request
otherwise ...

(*) a simple"

please explain. Thanks again

[herve]

I dont know what you meant by your quote "and you can also check that $loginUsername (*)
has a value before the first request
otherwise ...

(*) a simple"

please explain. Thanks again [/B]

It was just for debugging purpose.

If the $loginUsername has no value, then
the first query can't work.

Sometime for scope reason (local variable
vs global variable) variables haven't the
content you think they should have 🙂

[C__Casey]

Hi Herve

I'm looking for a few PHP/mySQL programmers are you available for side jobs? If you can send me a private message I'll have more details if you're interested.
Thanks
Casey