images into mysql

chrislive

I have used the tutorial off of this website to create the scripts to upload images to a mysql DB... and I know that people say its better not to but these will just be small images. nothing too excessive.

i have two pages
store.php and getdata.php the storing SEEMS to work but when i use the getdata.php it will not give me the image output.

any clues what im doing wrong here? it is exactly as the tutorial says but i cant get it working.

store.php

<?php

// store.php3 - by Florian Dittmer <dittmer@gmx.net>
// Example php script to demonstrate the storing of binary files into
// an sql database. More information can be found at [url]http://www.phpbuilder.com/[/url]
?>

<html>
<head><title>Store binary data into SQL Database</title></head>
<body>

<?php
// code that will be executed if the form has been submitted:

if ($submit) {

// connect to the database
// (you may have to adjust the hostname,username or password)

MYSQL_CONNECT("localhost","username","password");
mysql_select_db("binary_data");

$data = fread(fopen($form_data, "rb"), filesize($form_data));

$result=MYSQL_QUERY("INSERT INTO binary_data (description,bin_data,filename,filesize,filetype) ".
    "VALUES ('$form_description','$data','$form_data_name','$form_data_size','$form_data_type')");

$id= mysql_insert_id();
print "<p>This file has the following Database ID: <b>$id</b><br>";
print "<a href=\"store.php\">BACK</a>";
MYSQL_CLOSE();

} else {

// else show the form to submit new data:
?>

<form method="post" action="store.php" enctype="multipart/form-data">
File Description:<br>
<input type="text" name="form_description"  size="40">
<input type="hidden" name="MAX_FILE_SIZE" value="1000000">
<br>File to upload/store in database:<br>
<input type="file" name="form_data"  size="40">
<p><input type="submit" name="submit" value="submit">
</form>

<?php

}

?>
</body>
</html>

getdata.php

<?php
if($id) {

// you may have to modify login information for your database server:
MYSQL_CONNECT("localhost","username","password");

mysql_select_db("binary_data");


$query = "select bin_data,filetype from binary_data where id=$id";
$result = MYSQL_QUERY($query);

$data = MYSQL_RESULT($result,0,"bin_data");
$type = MYSQL_RESULT($result,0,"filetype");
$filename = MYSQL_RESULT($result,0,"filename");

Header( "Content-type: $type");
//Header( "Content-Disposition: attachment; filename=$filename");

echo $data;

};
?>

poisa

Hmmm...

Make sure your table fileds that hold the image data are of BLOB type...

Also, in getdata.php make sure $type is outputting something like "image/jpeg" or the gif/png alternatives. Without this it won't work.

FYI: The header you commented out (Content-Disposition: attachment) is used when you want to force the browser to download an image insted of displaying it.

chrislive

The DB i think is fine. This is the SQL i used to create:

CREATE TABLE binary_data (
id INT(4) NOT NULL AUTO_INCREMENT PRIMARY KEY,
description CHAR(50),
bin_data LONGBLOB,
filename CHAR(50),
filesize CHAR(50),
filetype CHAR(50)
);

The $type seems to work fine and yes I know about the head I commented. I want to print the image on screen. I suspect the data is being damaged while uploading. not sure whats wrong though.

poisa

chris,

Let's try one thing at a time. See if you can output any image to the browser.
Drop this script somewhere, name it thumbnail.php, and call it from another page, like this:

<img src="thumbnail.php?src=somefile.jpg" />

This should create a thumbnail of your file. If this works, then you know that your client supports the method you are using (sending image headers and such). If this doesn't work, then you definitely have a problem with the client you are using, since I have tested this file in many browsers and it works.

<?php

$src = $_GET['src']; 
// create and return a thumbnail version of a jpg image 
// $src is passed in URL 

// set up height and width of the created thmbnail 
$newWidth = 200; 
$newHeight = 200; 

// read in the passed image 
$im = imagecreatefromjpeg ("$src"); // Attempt to open 

//obtain the original image Height and Width
$srcWidth = imagesx($im);
$srcHeight = imagesy($im);

// start by using width for calculations
$percentage = (double)$newWidth / $srcWidth;
$destHeight = round($srcHeight * $percentage) + 1;
$destWidth = round($srcWidth * $percentage) + 1;

if($destHeight > $newHeight){
    // if the width produces a height bigger than we want,
    // calculate based on height
    $percentage = (double)$newHeight / $srcHeight;
    $destHeight = round($srcHeight * $percentage) + 1;
    $destWidth = round($srcWidth * $percentage) + 1;
}

// create a blank image of the required size 
$new = imagecreatetruecolor ($destWidth, $destHeight); 

// copy a resied version of the original to the new image
imagecopyresampled($new, $im, 0, 0, 0, 0, $destWidth, $destHeight, $srcWidth, $srcHeight); 

// output header and file 
header ("content-type: image/jpeg"); 
imagejpeg ($new, '', 100); 

// clear the image buffers 
imagedestroy ($im); 
imagedestroy ($new);
?>

If the image outputting part is not the problem, then you should check to see if the amount of data in you DB matches the amount of data in the file. This is probably the first thing you should do if you suspect that the uploading is getting screwed up.

Oh, by the way, if you are going to limit the uploaded fil with the HTML, bear this in mind (out of the PHP manual):

The MAX_FILE_SIZE is advisory to the browser. It is easy to circumvent this maximum. So don't count on it that the browser obeys your wish! The PHP-settings for maximum-size, however, cannot be fooled.

You probably knew that but it was worth mentioning.