Script Question

[GundamSV7]

Hi there,

I'm trying to make the following code more efficient:

if($block1[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$emptycolor></td>";
} elseif($block1[x] == $flaginfo[x] && $block1[y] == $flaginfo[y]) {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><a href=game.php?pickflag=1><img src=images/flag.gif border=0></a></td>";
} elseif($block1[type] == 1 && $player1[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor></td>";
} elseif($block1[type] == 2 && $player1[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor></td>";
} elseif($block1[type] == 1 && $player1[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><center><a href=\"game.php?view=attack&enemy=$player1[username]\"><img src=images/$player1[class]_$player1[dir].gif border=0></a><br><center>$player1[username] ($player1[bty])</td>";
} elseif($block1[type] == 2 && $player1[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor><center><a href=\"game.php?view=attack&enemy=$player1[username]\"><img src=images/inf_$player1[dir].gif border=0></a></td>";
}
if($block2[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$emptycolor></td>";
} elseif($block2[x] == $flaginfo[x] && $block2[y] == $flaginfo[y]) {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><a href=game.php?pickflag=1><img src=images/flag.gif border=0></a></td>";
} elseif($block2[type] == 1 && $player2[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor></td>";
} elseif($block2[type] == 2 && $player2[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor></td>";
} elseif($block2[type] == 1 && $player2[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><center><a href=\"game.php?view=attack&enemy=$player2[username]\"><img src=images/$player2[class]_$player2[dir].gif border=0></a><br><center>$player2[username] ($player2[bty])</td>";
} elseif($block2[type] == 2 && $player2[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor><center><a href=\"game.php?view=attack&enemy=$player2[username]\"><img src=images/inf_$player2[dir].gif border=0></a></td>";
}
if($block3[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$emptycolor></td>";
} elseif($block3[x] == $flaginfo[x] && $block3[y] == $flaginfo[y]) {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><a href=game.php?pickflag=1><img src=images/flag.gif border=0></a></td>";
} elseif($block3[type] == 1 && $player3[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor></td>";
} elseif($block3[type] == 2 && $player3[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor></td>";
} elseif($block3[type] == 1 && $player3[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><center><a href=\"game.php?view=attack&enemy=$player3[username]\"><img src=images/$player3[class]_$player3[dir].gif border=0></a><br><center>$player3[username] ($player3[bty])</td>";
} elseif($block3[type] == 2 && $player3[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor><center><a href=\"game.php?view=attack&enemy=$player3[username]\"><img src=images/inf_$player3[dir].gif border=0></a></td>";
}
if($block4[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$emptycolor></td>";
} elseif($block4[x] == $flaginfo[x] && $block4[y] == $flaginfo[y]) {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><a href=game.php?pickflag=1><img src=images/flag.gif border=0></a></td>";
} elseif($block4[type] == 1 && $player4[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor></td>";
} elseif($block4[type] == 2 && $player4[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor></td>";
} elseif($block4[type] == 1 && $player4[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><center><a href=\"game.php?view=attack&enemy=$player4[username]\"><img src=images/$player4[class]_$player4[dir].gif border=0></a><br><center>$player4[username] ($player4[bty])</td>";
} elseif($block4[type] == 2 && $player4[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor><center><a href=\"game.php?view=attack&enemy=$player4[username]\"><img src=images/inf_$player4[dir].gif border=0></a></td>";
}
if($block5[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$emptycolor></td>";
} elseif($block5[x] == $flaginfo[x] && $block5[y] == $flaginfo[y]) {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><a href=game.php?pickflag=1><img src=images/flag.gif border=0></a></td>";
} elseif($block5[type] == 1 && $player5[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor></td>";
} elseif($block5[type] == 2 && $player5[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor></td>";
} elseif($block5[type] == 1 && $player5[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><center><a href=\"game.php?view=attack&enemy=$player5[username]\"><img src=images/$player5[class]_$player5[dir].gif border=0></a><br><center>$player5[username] ($player5[bty])</td>";
} elseif($block5[type] == 2 && $player5[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor><center><a href=\"game.php?view=attack&enemy=$player5[username]\"><img src=images/inf_$player5[dir].gif border=0></a></td>";
}

and here's what I have so far, but it doesn't work, any idea why?

for($i=1;$i<5;$i++) {
$block = 'block' . $i;
$player = 'player' . $i;
if($$block[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$emptycolor></td>";
} elseif($$block[x] == $flaginfo[x] && $$block[y] == $flaginfo[y]) {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><a href=game.php?pickflag=1><img src=images/flag.gif border=0></a></td>";
} elseif($$block[type] == 1 && $$player[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor></td>";
} elseif($$block[type] == 2 && $$player[num] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor></td>";
} elseif($$block[type] == 1 && $$player[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><center><a href=\"game.php?view=attack&enemy=$$player[username]\"><img src=images/$$player[class]_$$player[dir].gif border=0></a><br><center>$$player[username] ($player1[bty])</td>";
} elseif($$block[type] == 2 && $$player[num] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor><center><a href=\"game.php?view=attack&enemy=$$player[username]\"><img src=images/inf_$$player[dir].gif border=0></a></td>";
}
}

[tekky]

easiest way...

get away and stay away from using $varX['keys'] names instead use $var[x]['keys']

then you can just use 1 loop with no fancy $$var attempts and simple arrays to mess with 😉

and I would recommend (for readibilty sake)

if ($reading == $true)
{
  echo 'this is easier to read';
}
else if ($reading == $false)
{
  echo 'no reason to be too neat';
}
else
{
  echo 'otherwise your way is much harder to read....';
}

[GundamSV7]

so u mean like use $block['$i'][num]?

[tekky]

Originally posted by GundamSV7
so u mean like use $block['$i'][num]?

well in the case of using variables it would just be

$block[$i]['num']

single quotes around strings, no quotes around $vars

[GundamSV7]

so, like this:

for($i=1;$i<5;$i++) {
//$block = 'block' . $i;
//$player = 'player' . $i;
if($block[$i]['num'] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$emptycolor></td>";
} elseif($block[$i]['x'] == $flaginfo[x] && $block[$i]['y'] == $flaginfo[y]) {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><a href=game.php?pickflag=1><img src=images/flag.gif border=0></a></td>";
} elseif($block[$i]['type'] == 1 && $player[$i]['num'] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor></td>";
} elseif($block[$i]['type'] == 2 && $player[$i]['num'] == "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor></td>";
} elseif($block[$i]['type'] == 1 && $player[$i]['num'] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$tilecolor><center><a href=\"game.php?view=attack&enemy=$player[$i]['username']\"><img src=images/$player[$i]['class']_$player[$i]['dir'].gif border=0></a><br><center>$player[username] ($player[$i]['bty'])</td>";
} elseif($$block[$i]['type'] == 2 && $player[$i]['num'] != "") {
echo "<td width=$dimensions height=$dimensions bgcolor=$safecolor><center><a href=\"game.php?view=attack&enemy=$player[$i]['username']\"><img src=images/inf_$player[$i]['dir'].gif border=0></a></td>";
}
}

I tried that and it's still doing the same thing as the original code.