[Resolved] num_rows prob?

[Dolemite50]

Hello,
i am trying to follow a tutorial for pagination.

tutorial

For some reason my query isnt working.
The code says to do this:

    

$limit          = 5;                

    $query_count    = "SELECT count(*) FROM reviews";     

    $result_count   = mysql_query($query_count);     

    $totalrows      = mysql_num_rows($result_count); 

I noticed that if I echo the $totalrows after that it is blank. The table is def called reviews and the there are def values in it. I also am sure I am connected correctly to the db because this works fine right after it:

    $query  = "SELECT loginName,  review FROM reviews WHERE songid = '$songid'         

What could I be doing wrong?
Thanks for any help.

[Weedpacket]

mysql_num_rows() should return 1, because your query will return one row with one field, which contains the count you're after. You'll want to use [man]mysql_result[/man] instead to get the value contained in the field.

If mysql_num_rows() is not returning 1 (you say it's blank), um... I presume MySQL's keywords are (as per SQL spec) case-insensitive so that count would work just as well as COUNT. tack an "or die(mysql_error())" after the mysql_query() clause and see if it's choking on anything (though I'd expect PHP to trigger a warning on the mysql_num_rows() call in that case).

[Dolemite50]

Thanks alot weedpacket. mysql_result seems to be working.

Have you ever seen that tutorial? Is there a reason why he used num_rows?

Anyhoo, you da man, thanks alot.

[Dolemite50]

AARRRRGHHH

This tutorial is driving me batty. Its actually darn close but I just need a little help. I'm sorry but I am going to post it so that I can explain it better.

    

$limit = 5;                

    $query_count = "SELECT COUNT(*) FROM reviews WHERE songid='$songid'";     

    $result_count = mysql_query($query_count, $conn);     

    //$totalrows = mysql_num_rows($result_count) or die(mysql_error()); 
	$totalrows = mysql_result($result_count, 0) or die(mysql_error()); 
	//exit($totalrows);


$limitvalue = $page * $limit - ($limit); 
$query  = "SELECT loginName, DATE_FORMAT(rdate, '%c/%e/%Y') AS rdate, rtitle, review FROM reviews WHERE songid = '$songid' ORDER BY rdate DESC LIMIT $limitvalue, $limit";         
$result = mysql_query($query) or die("Error: " . mysql_error()); 

if(mysql_num_rows($result) == 0){ 
    echo("No reviews available."); 
}      
while($row = mysql_fetch_array($result)){ 
    $loginName = prepOut($row['loginName']);
	$rdate = $row['rdate'];
	$rtitle = prepOut($row['rtitle']);
	$review = prepOut($row['review']);

             echo "<tr>
               TABLE INFORMATION WHICH PRINTS FINE
 }
  echo("</table>"); 

if($page != 1){ 
    $pageprev = $page--; 
echo("<a href=\"reviews.php?songid=$songid&stitle=$stitle&page=$pageprev\"><u>prev".$limit."</u></a>&nbsp; &nbsp;"); 
    }else{ 
        echo("prev".$limit."&nbsp; &nbsp;"); 
    } 

$numofpages = $totalrows / $limit; 

for($i = 1; $i <= $numofpages; $i++){ 
    if($i == $page){ 
        echo($i."&nbsp; &nbsp;"); 
    }else{ 
        echo("<a href=\"reviews.php?songid=$songid&stitle=$stitle&page=$i\"><u>$i</u></a>&nbsp; &nbsp;"); 
    } 
} 


if(($totalrows % $limit) != 0){ 
    if($i == $page){ 
        echo($i."&nbsp; &nbsp;"); 
    }else{ 
        echo("<a href=\"reviews.php?songid=$songid&stitle=$stitle&page=$i\"><u>$i</u></a>&nbsp; &nbsp;"); 
    } 
} 

if(($totalrows - ($limit * $page)) > 0){ 
    $pagenext = $page++; 

    echo("<a href=\"reviews.php?songid=$songid&stitle=$stitle&page=$pagenext\"><u>next".$limit."</u></a>"); 
}else{ 
    echo("next".$limit); 
} 

mysql_free_result($result); 
?>

Ok, first off, I noticed that nowhere in the script does it say to use a $get statement to retieve $page? I tried it with $page = $GET['page']; but it didnt help. This is the issue:

I have 12 reviews. I have limit set to display 5 results per page. On the first visit it displays this after the table echo:
prev5 1 2 3 next5
which is perfect, but for some reason the next5 link points to ...php?page=1 when it should be 2.

I apologize if this post is a clusterf***. 🙂

Thanks for any help.

[Dolemite50]

Well, you got me. For some reason it worked when I switched
$page++ to $page+1
and
$page-- to $page-1

[laserlight]

There's a good reason why

$pagenext = $page++;

is equivalent to
$pagenext = $page;
$page = $page + 1;

You would use
$pagenext = ++$page;
instead, but then avoiding such nuances may be better altogether in the long run, so I would use:

$page++;
$pagenext = $page;

for the same effect.

[Dolemite50]

Thanks alot laser,
I think I just downloaded a bum tutorial. Its working like a champ now, though. Thanks to the help of the fine folks on this board.