mysql_fetch_array()

g0liatH

I always get this error and it seems that I can't solve it :mad:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/virtual/site51/fst/var/www/html/td/main/item.php on line 13

this is the code:

item.php

<?php
include('news/db.php');

if (isset($_GET["id"])){ 
$q = mysql_query("SELECT * FROM $table WHERE id = '".$_GET['id']."'"); 
} else {
echo "no item selected";
}
// That queries the database


echo "<br><br>";
while($r=mysql_fetch_array($q)){

$title = $r["title"];

$news = $r["news"];

$body = nl2br($news);

$author = $r["author"];

$link = "mailto:".$r["email"];

$date = $r["date"];

if($table == 'td_downloads') {
$download = $r["link"];
}

echo "<table width=$contentwidth border=0 cellpadding=0 cellspacing=0>
  <tr>
    <td height=\"30\" width=\"21\" background=\"images/leftup.png\"></td>
    <td height=\"30\" colspan=\"3\" background=\"images/up.png\">$what</td>
    <td height=\"30\" width=\"21\" background=\"images/rightup.png\"></td>
  </tr>
  <tr>
    <td width=\"21\" background=\"images/left.png\"></td>
    <td colspan=3 background=\"images/spacer_content.png\">
<font class=\"news\">Category: <font class=\"fakelinknews\">$what</font><br>
<font class=\"fakelinknews\">\"$title\"</font> posted by <a class=\"linknews\" href=\"$link\">$author</a> 
on <font class=\"fakelinknews\">$date</font></font><br><br>$body";
if($table == 'td_downloads') {
echo "<br><a href=\"$download\">Download</a>";
}

echo "
</td>
    <td width=\"21\" background=\"images/right.png\"></td>
  </tr>
  <tr>
    <td height=\"30\" width=\"21\" background=\"images/leftdown.png\"></td>
    <td height=\"30\" colspan=\"3\" background=\"images/down.png\"></td>
    <td height=\"30\" width=\"21\" background=\"images/rightdown.png\"></td>
  </tr>
</table>
";

}

mysql_close($cnx);
?>

another file passes a variable to this file so this is the url:

http://www.doesntmatter.com/td/main/item.php?id=3

mikotondria

hrrm....all seems ok to me (but then Im a bit of a noob 🙂,..
However the first thing that stands out really, that I wouldnt do, is putting the $_GET['id'] into the sql query.
I'd just make a variable and put that in..

$id = $_GET['id'];
$q = "SELECT * from TABLE WHERE id`='$id'";

is always the way I do it, not sure if its critical here, just my 2c 🙂..

/\/\iI{3

nemonoman

The query has not run, or has thrown an error.

if (isset($GET["id"])){
$myquery="SELECT * FROM $table WHERE id = '".$GET['id']."'";
echo $myquery; // should show something screwed up -- I think you have too many quotes in there
$q = mysql_query($myquery);
} else {
echo "no item selected";
}
// That queries the database

if(!$q){
$x=mysql_error();
die ("the query didn't run -- error was $x");
}

echo "<br><br>";
while($r=mysql_fetch_array($q)){

TheDefender

Where and how is the $table variable being defined?

Also, you may want to concatenate your table name in your query too...

$q = mysql_query("SELECT * FROM ".$table." WHERE id = '".$_GET['id']."'");

tekky

basic debugging 101 will go a long ways here...

<?php
include('news/db.php');

if (isset($_GET['id'])){ 
$query = "SELECT * FROM $table WHERE id ='" .$_GET['id']. "'";
$result = mysql_query($query) OR die('Error: ' . mysql_error()); //always use a comprehensive DIE statement so you know WHY you are erroring 
} else {
echo "no item selected";
}
// That queries the database


echo "<br><br>";
while($r=mysql_fetch_array($result)){

$title = $r["title"];

$news = $r["news"];

$body = nl2br($news);

$author = $r["author"];

$link = "mailto:".$r["email"];

$date = $r["date"];

if($table == 'td_downloads') {
$download = $r["link"];
}

echo "<table width=$contentwidth border=0 cellpadding=0 cellspacing=0>
  <tr>
    <td height=\"30\" width=\"21\" background=\"images/leftup.png\"></td>
    <td height=\"30\" colspan=\"3\" background=\"images/up.png\">$what</td>
    <td height=\"30\" width=\"21\" background=\"images/rightup.png\"></td>
  </tr>
  <tr>
    <td width=\"21\" background=\"images/left.png\"></td>
    <td colspan=3 background=\"images/spacer_content.png\">
<font class=\"news\">Category: <font class=\"fakelinknews\">$what</font><br>
<font class=\"fakelinknews\">\"$title\"</font> posted by <a class=\"linknews\" href=\"$link\">$author</a> 
on <font class=\"fakelinknews\">$date</font></font><br><br>$body";
if($table == 'td_downloads') {
echo "<br><a href=\"$download\">Download</a>";
}

echo "
</td>
    <td width=\"21\" background=\"images/right.png\"></td>
  </tr>
  <tr>
    <td height=\"30\" width=\"21\" background=\"images/leftdown.png\"></td>
    <td height=\"30\" colspan=\"3\" background=\"images/down.png\"></td>
    <td height=\"30\" width=\"21\" background=\"images/rightdown.png\"></td>
  </tr>
</table>
";

}

mysql_close($cnx);
?>

that should atleast give you some error messages to work with....

g0liatH

for cryin out loud I made a huge error! I forgot that this file was a sub file so I had to add some other files, so $table wasn't defined. thanks a lot everyone for your help!

defender, you were right 🙂
tekky, I know, always forget that :o

srry for late reply, was on vacation