Undefined variable - Please Help

artizan

Hi all, I have searched through the forum trying to find the solution to this problem, but to no avail....

Ok.. When I run my Email form, i get the error Undefined variable line 13. However, if i turn global variables ON, everything works fine. Ive used ISSET, which bypasses the error and jumps to "Sorry but you can't access this page directly" .So can anyone please shine some info on how I can solve this... ta in advance...

<?
if ($process) {
@extract($_POST);
$name = stripslashes($name);
$email = stripslashes($email);
$subject = "A Comment sent from: ".stripslashes($website);
$message = stripslashes($message);

mail("myemail@blah",$subject,$message,
"From: $name <$email>\r\n" .
"Reply-To: $name <$email>\r\n" .
"X-Mailer: PHP/" . phpversion());

$message = str_replace("\n","<br>",$message);
echo "The following message was sent:<br><br>";
echo "<b>From:</b> $name <".$email."><br>";
echo "<b>Subject</b> $subject<br>";
echo "<br><b>Message:</b><br>$message";
echo "<br><br>";
echo "<b>Thank You For Sending Me A Comment</b>";
} else {
echo "Sorry but you can't access this page directly";
}
?>

laserlight

Which line is line 13?

I suggest using the $_POST array directly rather than extracting it like that.

artizan

Originally posted by laserlight
Which line is line 13?

I suggest using the $_POST array directly rather than extracting it like that.

Thanks for your responce laserlight

The line thats causing the problem is

if ($process) {

laserlight

And where's $process coming from?

artizan

Originally posted by laserlight
And where's $process coming from?

Sorry

Its being called from my html form

<form action="contact.php" method="post">
Name: <input type="text" name="name" size="20" maxlength="20">
Email: <input type="text" name="email" size="30" maxlength="30">
Website: <input type="text" name="website" size="30" maxlength="30" value="http://">
Message: <textarea name="message" cols="50" rows="10"></textarea>

tekky

with register globals OFF you have to access POST/GET data via $GET['varname'] and $POST['varname']

thats why it works with it on and not off, as laserlight said, it is recommended to use it OFF and access them view $POST/$GET

laserlight

That's precisely why you shouldnt use extract($_POST)

<?php
if (isset($_POST['process'])) {
	if (!empty($_POST['name']))
		$name = stripslashes($_POST['name']);
	else
		$name = '';
	if (!empty($_POST['email']))
		$email = stripslashes($_POST['email']);
	else
		$email = '';
	if (!empty($_POST['website']))
		$subject = "A Comment sent from: " . stripslashes($_POST['website']);
	else
		$subject = "Sender unknown";
	if (!empty($_POST['message']))
		$message = stripslashes($_POST['message']);
	else
		$message = '';

mail("myemail@blah",
	$subject,
	$message,
	"From: $name <$email>\r\n" .
		"Reply-To: $name <$email>\r\n" .
		"X-Mailer: PHP/" . phpversion());

$message = str_replace("\n","<br>",$message);
echo "The following message was sent:<br><br>";
echo "<b>From:</b> $name <".$email."><br>";
echo "<b>Subject</b> $subject<br>";
echo "<br><b>Message:</b><br>$message";
echo "<br><br>";
echo "<b>Thank You For Sending Me A Comment</b>";
} else {
	echo "Sorry but you can't access this page directly";
}
?>

artizan

Thankyou very much for your help you two....

I tried it with this at first
if (isset($_POST['process'])) {

which never worked.....

but with this line of code as well it now works

if (!empty($_POST['name']))

cheers laser.... kind of understand how its resolved it........