[Resolved] INSERT() doesn't work

bpat1434

Hello all.

For some odd reason, I try and use an HTML form to insert certain values into a database. In the HTML form, I dont' know what's going on, but it seems that the INSERT function isn't working, or the values aren't being submitted. Any help would be appreciated.

HTML Form

<form action="scripts/modify/addItem.php" method="POST" name="add">
Title: <input type="text" size="30" name="title" /><br />
Short Text:<br /><textarea cols="32" rows="15" name="short"></textarea><br />
Extended Text:<br /><textarea cols="32" rows="15" name="extnd"></textarea><br />
<input type="hidden" name="item" value="stories" />
<input type="hidden" name="pid" value="1" />
<input type="submit" value="Add Story" />

PHP addItem Script

<?php
//
// Add Items to the DB
//

$title = $_GET['title'];
$short = $_GET['short'];
$extnd = $_GET['extnd'];
$date = date("F j, Y");

include("connection.php");

$query = "INSERT INTO `stories` (Date, Title, Short, Extnd) VALUES ('$date', '$title', '$short', '$extnd')";
$result = mysql_query($query, $dbc);

if($result == true){
	echo('Successfully entered into database');
	echo('<a href="http://winfieldvfd.org/admin/index.php?=1">Back</a>');
}
else{
	echo('Unable to insert values.  Try again.<br />');
	echo(mysql_errno().'<br />'.mysql_error());
	echo('<br />Table, Title, Short, Extnd');
	echo($table.'<br />==========');
	echo($title.'<br />==========');
	echo($short.'<br />==========');
	echo($extnd.'<br />');
}

?>

TheDefender

In your FORM tag, you set the method to POST, and when you call the variables, you are using the $GET method. Either change the form tag to the GET method, or change the variable definitions to use the $POST method.

bpat1434

What's the difference. It worked before, why is it now that I have to change it?

~Brett

It worked, thanks.

TheDefender

Well, it is two different methods of sending/retrieving the data. It shouldn't have worked like that.

If you submit a form using POST, then you have to retrieve the variables using the $POST (preferred) or $REQUEST method of retrieval. Likewise, if you submit using GET, then you have to retrieve them using the $GET (preferred) or $REQUEST method.

The way your code is written, it shouldn't have worked in the past.

Now if your register globals was on in the past, but is now off, then it may have been that you were calling the variables directly, but if you are saying your code, as you presented it, was working in the past, then your server had some seriously messed up configuration going in the past.

Roger_Ramjet

The difference is that GET vars are passed in the URL, you will see them in your address bar at the top of the page, while POST vars are submitted in the body of the request, and invisible to the user. POST can also contain more data then GET and include special characters which GET cannot. If you have problems understanding the difference, or think you may want to change the method at a later date then use $_REQUEST which accesses post, get, and cookie vars indiscriminately.

bpat1434

Thankyou very much for that informative response. Much appreciated.

~Brett