having problem with foreach ()

ejwf

I have a mysql database full of info I am trying to use to show to a web user.
The structure of the database is such that I have various clients and for each client there can be one or more sections or departments.
I am trying to list data for each of these sections, if there is only only section it works OK, but if there is 2 or more then I get nothing (no table / no info / nothing)
I think I need a foreach () in there somewhere but I cannot make this thing work.
Can anyone see where I have gone wrong and what I need to do - thanks

the code I have at the moment is

$query = "SELECT `ClientRef` FROM `tblUser` WHERE `CLogIn` = '$username'"; 
$result2 = mysql_query($query) 
   or die (mysql_error()); 
$row2 = mysql_fetch_array($result2); 
$ClientRef = $row2["ClientRef"]; 

$query = "SELECT `SectionId` FROM `tblSection` WHERE `ClientRef` = '$ClientRef'"; 
$result5 = mysql_query($query) 
   or die (mysql_error()); 
while ($row5 = mysql_fetch_array($result5)) 
$SectionRef[] = $row5["SectionId"]; 

foreach ($SectionRef AS $Value)
{
//list equipment
$query = "SELECT (TypeRef) AS TypeRef, (SerialNo) AS SerialNo, (CommonName) AS Location, (MachineId) AS MachineId, 
(ClicksList) AS ClicksList FROM `tblMachine` WHERE ClientRef = '$ClientRef' "; 
$result11 = mysql_query($query) 
or die(mysql_error());

if ($result11)
{		
echo' <form action="process_readings.php" method="POST"> 
<table align="centre" cellspacing="0" cellpadding="0"> 
<tr>
<td align="left"></td>
<td align="left"><b>Section</b></td>
<td align="left"><b>Type Ref</b></td>
<td align="left"><b>Serial Number</b></td>
<td align="left"><b>Location</b></td>
<td align="right"><b>Code</b></td>
<td align="left"></td>
<td align="left"><b>Meter Readings</b></td>
<td align="left"></td>
<td align="left"></td>
</tr>';

while ($row11 = mysql_fetch_array($result11,MYSQL_NUM)) 
{ 
echo "<tr><font face=\"Arial, Helvetica, sans-serif\"> 
<td width=\"10\" align=\"left\"> <input type=\"hidden\" name=\"ClicksList\" value\"{$row11[4]}\">  </td>
<td width=\"70\" align=\"left\"> {$row11[0]}</td> 
<td width=\"120\" align=\"left\"> {$row11[1]}</td> 
<td width=\"200\" align=\"left\"> {$row11[2]}</td> 
<td width=\"30\" align=\"right\"> {$row11[3]} </td>  ";

if ($row11[4] == 1)
{
echo "<td width=\"10\" align=\"left\"> {$row11[7]} <input type=\"text\" name=\"MachineId[]\" size=\"3\"></td>
<td width=\"200\" align=\"left\"> {$row11[5]} BW <input type=\"text\" name=\"BWClicks[]\"></td>
<td width=\"300\" align=\"left\"><input type=\"hidden\" name=\"CClicks[]\" value\"{NULL}\"></td><br> ";
}
else 
{
echo "<td width=\"1\" align=\"left\"> {$row11[7]} <input type=\"text\" name=\"MachineId[]\" size=\"3\"></td>
<td width=\"200\" align=\"left\"> {$row11[5]} BW <input type=\"text\" name=\"BWClicks[]\"> </td> 
<td width=\"300\" align=\"left\"> {$row11[6]} Colour <input type=\"text\" name=\"CClicks[]\"></td><br> ";
}
echo "</font></tr>\n"; 
} //close while loop 

} //close if

} // close foreach																
echo '</table>';

echo "<br><p align=\"center\"><input type=\"submit\" name=\"submit\" value=\"Submit\"> "; 

echo '</form>';

PHPMagician

This is your foreach loop:

foreach ($SectionRef AS $Value)

Yet, in any of the following code after that line, the variable $Value is not mentioned. I believe you wanted that $Value to be mentioned within the query: append this to the end of the query which is within the foreach loop

AND SectionRef='$Value'

Of course, I could have you schema wrong, make allowances.

I believe that is your problem.

ejwf

Thanks for your reply, but I don't think that is it......
I understand what you mean about not having $Value anywhere in the foreach statement, but I have tried to put it somewhere and I cannot find anywhere where it would make sense, so based on this I am re-writing the code based on a while statement and going the long way round !
I will let you know what I come up with - thanks

PHPMagician

lol, yeah, if you don't need a to use the $Value variable, it pointless creating a for-loop (in this case anyhow).

Here is how I see it you should have the query to return all sections:

SELECT s.SectionId, m.TypeRef, m.SerialNo, m.MachineId, m.ClicksList FROM tblMachine m,  tblSection s WHERE s.ClientRef='$ClientRef' AND m.ClientRef='$ClientRef'

That way, look like this:

<?php
$query = "SELECT `ClientRef` FROM `tblUser` WHERE `CLogIn` = '$username'";
$result2 = mysql_query($query)
   or die (mysql_error());
$row2 = mysql_fetch_array($result2);
$ClientRef = $row2["ClientRef"];

// This is my code
$query="SELECT s.SectionId, m.TypeRef, m.SerialNo, m.MachineId, m.ClicksList
FROM tblMachine m,  tblSection s
WHERE s.ClientRef='$ClientRef' AND m.ClientRef='$ClientRef'";
$result=mysql_query($query);
// You code again
echo' <form action="process_readings.php" method="POST">
<table align="centre" cellspacing="0" cellpadding="0">
<tr>
<td align="left"></td>
<td align="left"><b>Section</b></td>
<td align="left"><b>Type Ref</b></td>
<td align="left"><b>Serial Number</b></td>
<td align="left"><b>Location</b></td>
<td align="right"><b>Code</b></td>
<td align="left"></td>
<td align="left"><b>Meter Readings</b></td>
<td align="left"></td>
<td align="left"></td>
</tr>';
// My loop
while($row = mysql_fetch_array($result,MYSQL_NUM))
{
// This is all your code now
echo "<tr><font face=\"Arial, Helvetica, sans-serif\">
<td width=\"10\" align=\"left\"> <input type=\"hidden\" name=\"ClicksList\" value\"{$row11[4]}\">  </td>
<td width=\"70\" align=\"left\"> {$row11[0]}</td>
<td width=\"120\" align=\"left\"> {$row11[1]}</td>
<td width=\"200\" align=\"left\"> {$row11[2]}</td>
<td width=\"30\" align=\"right\"> {$row11[3]} </td>  ";
if ($row[4] == 1)
{
echo "<td width=\"10\" align=\"left\"> {$row11[7]} <input type=\"text\" name=\"MachineId[]\" size=\"3\"></td>
<td width=\"200\" align=\"left\"> {$row11[5]} BW <input type=\"text\" name=\"BWClicks[]\"></td>
<td width=\"300\" align=\"left\"><input type=\"hidden\" name=\"CClicks[]\" value\"{NULL}\"></td><br> ";
}
else
{
echo "<td width=\"1\" align=\"left\"> {$row11[7]} <input type=\"text\" name=\"MachineId[]\" size=\"3\"></td>
<td width=\"200\" align=\"left\"> {$row11[5]} BW <input type=\"text\" name=\"BWClicks[]\"> </td>
<td width=\"300\" align=\"left\"> {$row11[6]} Colour <input type=\"text\" name=\"CClicks[]\"></td><br> ";
}
echo "</font></tr>\n";
} //close while loop
echo '</table>';

echo "<br><p align=\"center\"><input type=\"submit\" name=\"submit\" value=\"Submit\"> ";

echo '</form>';
?>

(completely untested, like most of my posts)

Note: Consider using syntax indention. When I begun coding, I was lazy and didn't do it - now I hate code which is not indented. Start from an early stage learning good practices and you will be better faster.