Variable keeps going and going and going...

darthmahon

Hi,

Ok I have a slight problem with a multilingual website I am working on. There are links that allow the user to change languages throughout the site, this is the code:

<? if ($_SESSION["lang"]=="en") {

echo"<a href=\"".$_SERVER[PHP_SELF]."?".$_SERVER[QUERY_STRING]."&lang=fr\">";

} else if ($_SESSION["lang"]=="fr") {

echo"<a href=\"".$_SERVER[PHP_SELF]."?".$_SERVER[QUERY_STRING]."&lang=en\">";

} ?>

I needed to get both the current file being looked at and the querystring because it is a shopping cart and I am passing variables througout the url and I didn't want them to go off the current page when changing languages...so, if I keep pressing that, eventually I will end up with the following url:

index.php?section=product&tid=ha4dd&pid=1&lang=en&lang=fr&lang=en&lang=fr

See how &lang keeps repeating itself over and over, it's not that this causes the script to stop working, but it's bad to see it...

Is there anyway I keep stop this from happening if the user keeps changing languages without changing pages?

Cheers,
Chris

sneakyimp

you must either parse your query string with some string function that looks for your language var and chops it off OR you are going to have to build the query string from something else (try the $_GET vars perhaps?

not sure but something like this might work:

$query_string = '?';
foreach($_GET as $key=>$value) {
   $query_string .= "&" urlencode($key) . "=" . urlencode($value);
}

WATCH OUT FOR MAGIC QUOTES! i'm not sure you have to urlencode the $key....

LordShryku

To his first point, a str_replace would do the trick.

if(isset($_GET['lang']))
   $cur = @str_replace('&lang='.$_GET['lang'], '', $_SERVER['QUERY_STRING']);
else
   $cur = $_SERVER['QUERY_STRING'];

# then change the $_SERVER['QUERY_STRING'] calls to $cur

echo"<a href=\"".$_SERVER[PHP_SELF]."?".$cur."&lang=fr\">";

sneakyimp

go shryku!

shryku's code won't strip out multiple versions of the variable from your query string, but you won't have multiple versions of the variable if you add it to your script!