[Resolved] php and javascript, window close?

Dolemite50

Hi,
I have a site that has sections which require login. When somebody clicks on a members only section, a js popup appears in a small window and gives them two options.
1. go to sign in page
2. close window

I am using this for the close window link:

<a href="#" onclick="self.close();return false;"><img src="images/go.gif" width="24" height="24"></a>

And I am using this for the Sign in link:

<a href="<?php echo $forum ?>" target="_blank""><img src="images/go.gif" width="24" height="24"></a>

What I would like to do is have the popup window close when somebody clicks on the Sign in link.

If I dont use target="_blank", the window is too small for the followup page. So mainly I just need to know how to close a window "as" you link to another page.

Thanks

bodzan

Dolemite50

Hi Bodzan, thanks alot for the response. I havent gotten around to trying it yet because I ran into another problem.

I have an additional page that has identical code but the popup isnt working. Instead of opening as a popup it just opens as a normal window. The only difference that I can see is that on the code that isnt working, it is used in an include file. The page that is working has this for a header because there are rollovers.

<script language="JavaScript" type="text/JavaScript">
<!--
function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}

function MM_swapImgRestore() { //v3.0
  var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_findObj(n, d) { //v4.01
  var p,i,x;  if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
  if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
  for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
  if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
  var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
   if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>

The other page that isnt working doesnt have any javascript info in the header. It is a normal php page and then I use a php include file to show the table with the popup link. I tried pasting the above code into the other page but it didnt work.

What additional info is required to use this line:

<a href= "<?php echo $url2 ?>" onclick="window.open('<?php echo $url2 ?>','popup','width=400,height=350,scrollbars=no,resizable=no,toolbar=no,directories=no,location=no,menubar=no,status=no,left=50,top=100');return false">Leave a msg</a>

Do I need to define the js language somewhere in the header? If so, do I do it on the main file or the include file?

Sorry if this is confusing, I havent dabbled in js a whole lot. 🙂

tsinka

Hi,

I tested the a href code and it worked worked (IE and FireFox), but you need to make sure that the complete <a hre=.... onClick="..."...> stuff is on one line.

And I'd recommend to replace
<a href= "<?php echo $url2 ?>"
by
<a href="#"

Thomas

Dolemite50

thx alot thomas, Ill give 'er a whirl!

Dolemite50

hmmm,
I tried changing the href to # and now it doesnt work at all. The original page is called song.php. The popup is called reviewpop.php. Now, instead of pointing to reviewpop.php it points to song.php# ..?
I dont know what Im doing wrong here, its all on one line, and one instance was working fine but the same code being used as an include does not.
heres the code:

<?php 
$url1= append_sid("reviews.phpsongid=$songid&stitle=$stitle&page=1");
$url2= append_sid("givereviewpop.php?songid=$songid&stitle=$stitle");
if ($rcount==0){
echo "View all";
}
else 
echo "<a href= \"#\" onclick=\"window.open('$url1','popup','width=420,height=350,scrollbars=yes,resizable=no,toolbar=no,directories=no,location=no,menubar=no,status=no,left=50,top=100');return false\">View all</a>";
?>


<td width="73" valign="middle" class="hotNames"><div align="center"><a href= "#" onclick="window.open('<?php echo $url2 ?>','popup','width=400,height=350,scrollbars=no,resizable=no,toolbar=no,directories=no,location=no,menubar=no,status=no,left=50,top=100');return false">Write a review</div></td>

Thanks alot for any help.

Dolemite50

Dang, I just dont get it. That same code works great in five different spots on my site. The only place it doesnt work is when it is being used within an include file.

Do I need any special info in the header or should that line of code work fine on its own?

tsinka

Ok,

I can't find the error ... so ... post the complete page source (the generated HTML code) as attachment.

Thomas

Dolemite50

Ok, you asked for it!

Hehe, please dont poke to much fun at this beast.

Dolemite50

Oh Dear lord.

I think its because in that instance it was appending a variable that had an apostrophe in it? I suppose that if ...php?bandname=$bandName and the band name has an apostrophe it will break it?

Is this a case for adsslashes or urlencode?

tsinka

Yes,

use urlencode in this case, not only addslashes because you also need to encode characters like & and so on...

Get parameters with an apostrophe in it will break the JavaScript code.

Thomas

Dolemite50

Mighty kind of you thomas, have a good night. 🙂