[Resolved] Functions

[klik]

my first attempt at a php script. It's going to be a login script.

functions.php

<?php
include 'members/db_connect.php';

function login_form( $txt= "", $username = "", $password = "" ){
echo "
<form method=\"post\" action=\"?cmd=results\">\n
<p /><b>Username:</b>\n
<input type=\"text\" name=\"username\" size=\"20\" maxlength=\"20\">\n
<p /><b>Password:</b>\n
<input type=\"password\" name=\"password\" size=\"20\"
maxlength=\"20\"></p>\n
<center><font color=\"red\">$txt</font></center>
<input type=\"hidden\" name=\"cmd\" value=\"results\">
<input type=\"submit\" name=\"submit\" value=\"Login\"></p>\n
</form>\n\n";
}


function results(){
// Convert to simple variables
$username = $_POST['username'];
$password = $_POST['password'];
$referrer = $_POST['referrer'];


if((!$username) || (!$password)){
    $txt = "Please enter ALL of the information! <br />";
    login_form( $txt, $username, $password );
    exit();
}

// check if the user info validates the db
$sql = mysql_query("SELECT * FROM cms_users WHERE username='$username' AND password='$password'");
$login_check = mysql_num_rows($sql);

if($login_check > 0){
    while($row = mysql_fetch_array($sql)){
    foreach( $row AS $key => $val ){
        $$key = stripslashes( $val );
    }
      // Register some session variables!
	session_register('username');
	$_SESSION['username'] = $username;
	session_register('LoggedIn');
	$_SESSION['LoggedIn'] = 1;

    mysql_query("UPDATE cms_users SET last_login=now() WHERE user_id='$user_id'");

    header("Location: $referrer");
}
} else {
    $txt =  "You could not be logged in! The username and password do not match<br />
    Please try again!<br />";
login_form( $txt, $username, $password );
}


}
?>

within my index.php file

                                            <?php
if($_SESSION[LoggedIn] == 1){
echo "Welcome <font color=\"#003366\">$_SESSION[username]</font> , you are logged in. <br><br>";
echo "[<a href=\"includes/functions.php?action=logout\">Logout</a>]";
}
else{
login_form();
}
?>

My problem is when I hit the login button from index.php the page just simply reloads.
If it's a glaringly obvious mistake, remember this is my first script 🙁

[eoghain]

Well from what I can see you never deal with the submitted form. Your index page just checks the LoggedIn session variable, but it doesn't check to see if the user is trying to login.

My guess is you want to change your index to something like this:

if($_SESSION[LoggedIn] == 1){ 
echo "Welcome <font color=\"#003366\">$_SESSION[username]</font> , you are logged in. <br><br>"; 
echo "[<a href=\"includes/functions.php?action=logout\">Logout</a>]"; 
}
elseif ($_POST["cmd"]=="results" || $_GET["cmd"]=="results") {
results();
} 
else{ 
login_form(); 
}

[devinemke]

the page just simply reloads because you are never running your results() function. you need to do something like this:

if (isset($_POST['submit']) && $_POST['submit'] == 'Login')
{
	results();
}

if ($_SESSION['LoggedIn'] == 1)
{ 
	echo '
	Welcome <font color="#003366">' . $_SESSION['username'] . '</font> , you are logged in. <br><br>
	[<a href="includes/functions.php?action=logout">Logout</a>]
	'; 
} 
else
{ 
	login_form();
}

BTW: you don't want/need those session_register() lines.

[klik]

Excellent, thank you both for the code. Both work as I hoped for.

And thanks for the tip about those session register lines. Good to know.🙂