[Resolved] substr() not working as expected

bunner_bob

I'm doing errorchecking on uploaded files. In addition to checking filetype, I'm using substr() to check whether the file suffix is correct.

if (substr($_FILES['file']['name'], -4) != ".pdf" && substr($_FILES['file']['name'], -4) != ".PDF") {
    // generate error
}

But it ain't working. I can run .html files, or whatever, past it and they get through. If I switch it to

if (substr($_FILES['file']['name'], -4) == ".pdf") {
    // generate error
}

and then upload a .pdf, I do get an error (as expected).

What am I doing wrong?

nemonoman

Don't know. If you want to debug it, see what
substr($_FILES['file']['name'], -4

is actually doing. However if this were my code, here's what I'd do:

if (substr($_FILES['file']['name'], -4) == ".pdf") {}

else{
//generate error
}

bunner_bob

Geez - I am a frickin' mow-ron.

My file errorcheck routine is a batch of if/elses that run sequentially. I disabled the previous elseif, which checked whether the file type was not application/pdf. Or rather, I disabled the error message and flag. But i didn't disable the conditional check, so of course the errorcheck routine decided "ok, this isn't a pdf, condition met, stop checking conditions". Since the error was disabled, the submit went through and all worked great. Or rather badly, since it never even got to checking the file suffix at all.

Figured it out, made it right, works great. Thanks for the help.

Bob