Html/php

[klik]

Okay, so I have included a small snippet of code(see below) into my index.php page. Most of the page other than this snippet is HTML.

When index.php loads, the form which is meant to display IS displayed, but when results() function is called(after form processing) some of my HTML goes missing.

The form is put back in at the section the snippet appears at, but no HTML below this snippet is then included. The very bottom line of code after viewing the page source is </form>.This generates a page with no bottom half of HTML code(therefore half the website goes missing).

<?

if (isset($_POST['submit']) && $_POST['submit'] == 'Login')
{
    login_results();
}

if ($_SESSION['LoggedIn'] == 1)
{ 
    echo '
    Welcome <font color="#003366">' . $_SESSION['username'] . '</font> , you are logged in. <br><br>
    [<a href="?action=logout">Logout</a>]
    ';
	number_of_members();
} 
else
{ 
    login_form();
    number_of_members();

}

?>

Any ideas?

[devinemke]

are you calling the [man]exit[/man] or [man]die[/man] functions anywhere is your code?

[klik]

Here are 3 functions within my functions.php file.

function login_results()
{
// Convert to simple variables
$username = $_POST['username'];
$password = $_POST['password'];


if(($username == "") || ($password == "")){
    $txt = "Please enter ALL of the information! <br />";
    login_form( $txt, $username, $password );
    exit();
}

// check if the user info validates the db
$sql = mysql_query("SELECT * FROM cms_users WHERE username='$username' AND password='$password'");
$login_check = mysql_num_rows($sql);

if($login_check > 0){
    while($row = mysql_fetch_array($sql)){
    foreach( $row AS $key => $val ){
        $$key = stripslashes( $val );
    }
      // Register some session variables!
	$_SESSION['username'] = $username;
	$_SESSION['LoggedIn'] = 1;

    mysql_query("UPDATE cms_users SET last_login=now() WHERE user_id='$user_id'");
}
} else {
    $txt =  "You could not be logged in! The username and password do not match<br />
    Please try again!<br />";
login_form( $txt, $username, $password );
exit();
}
}

function number_of_members()
{
    // Counting Number of Products Available:
    $count = @mysql_query("SELECT * FROM cms_users");
    $num_rows = mysql_num_rows($count);
    // To display number of products:
    echo "<b>Total Members: <font type=\"arial\", color=\"#0000CC\">$num_rows</font></b>";
}

function login_form( $txt= "", $username = "", $password = "" )
{
echo "
<form method=\"post\" action=\"?cmd=results\">\n
<p /><b>Username:</b>\n
<input type=\"text\" name=\"username\" size=\"20\" maxlength=\"20\">\n
<p /><b>Password:</b>\n
<input type=\"password\" name=\"password\" size=\"20\"
maxlength=\"20\"></p>\n
<center><font color=\"red\">$txt</font></center>
<input type=\"hidden\" name=\"cmd\" value=\"login_results\">
<input type=\"submit\" name=\"submit\" value=\"Login\"></p>\n
</form>\n\n";
}

[devinemke]

you do have conditonal logic in your login_results() function which calls [man]exit[/man]. if those conditons are met then the PHP parser will halt and everything from that point on will not be sent to the browser.

[klik]

Thanks for the explanation. Is there a fix for this?

[devinemke]

Originally posted by klik
Is there a fix for this?

there's nothing to fix. the exit() function does exactly what it says. if you want/need further output to be sent to the client before exiting then you must do so before calling exit().

[klik]

Okay then.

At least I know it is working.

Only thing is I made a HTML page and changed that extension to php.
I inserted the code I showed you in my first post in the middle of this HTML code, so that the form was exactly displayed where I wanted it to be.

Now I'm not sure how to display the html code after the login form code.

Oh and Yes I am just getting into PHP if you were wondering.

[devinemke]

a common approach is to store your HTML is smaller more modular chunks (header, middle, footer) and dynamically spit them to the client (usually using [man]include[/man] or custom functions/classes that output the HTML). if you use conditional logic somewhere within your code where you want to trap errors and call [man]exit[/man] then simply spit out the remaining chunks of HTML before exiting. you might also want to look at Output Control Functions which give you an even greater amount of control over how/when output is sent to the browser.

[klik]

Thanks mate I'll look into that