header redirect not working - need some help

smueller72

I cannot get the a header redirect to work. The code is as follows:

$url = getenv(HTTP_HOST);
if ( stristr( $url, "sitekey.domain.com" ) ) {
header( "Location: http://sitekey.domain.com/index.php?site=sitekey" );
}

It does drop in to the 'Then' portion of the code properly but the redirect does not occur. I'm taken to the default site and not a subsite that I'm trying to redirect to. I've also tried it without having the 'Location: ..' portion of the code being fully qualified with the same results. Any help would be greatly appreciated. I'm at a loss.

Weedpacket

Originally posted by smueller72
I cannot get the a header redirect to work. The code is as follows:

$url = getenv(HTTP_HOST);
if ( stristr( $url, "sitekey.domain.com" ) ) {
header( "Location: http://sitekey.domain.com/index.php?site=sitekey" );
}

It does drop in to the 'Then' portion of the code properly but the redirect does not occur. I'm taken to the default site and not a subsite that I'm trying to redirect to.

The script is not going to stop executing just because you used the header() function. You have to tell it to stop.

$url = getenv(HTTP_HOST);
if ( stristr( $url, "sitekey.domain.com" ) ) {
  header( "Location: [url]http://sitkey.example.com/index.php?site=sitekey[/url]" );
  exit;
}

smueller72

Thanks for the reply. I've added the exit; and now the site does not display. I just get a blank page. Any ideas why?

Bunkermaster

for debug:

<?...
if (!headers_sent()){
    header(...);
} else {
    echo "headers already sent";
}
?>

You might have something displayed before your header() call. A space or a new line before opening <? can kill your header and if you don't display warning you're stuck.

smueller72

Thanks. I'll try that now. I did figure out the cause of the blank page was due to a syntax error. Now when I try it I get a 'Redirection limit for URL exceeded .. ' message and a reference to a possible cookies issue which I doubt is the actual case. Here is my code as it stands now.

<?php..
$url = getenv(HTTP_HOST);
if ( stristr( $url, "lee.maidstoorder.com" ) ) {
  header( "Location: /index.php?site=lee" );
  exit;
} 
?>

This is at the top of the code. No blank lines before.

I've tried every variation in the header() portion of the code - i.e. fully qualified, single quotes, no leading '/' etc etc with the same results. This is driving me nuts. Any help would be greatly appreciated.

smueller72

a little more info. I've put your debug code in place and I added another echo to the 'Then' portion of the code to let me know if it has gotten there and indeed the text does display. So my guess is that is it something with the syntax of the header() itself? Sorry if this is simple stuff - I'm not a PHP coder(if you didn't figure that one out already). Thanks in advance for any help.

Bunkermaster

need to see whole code you have above your header statement

smueller72

This is the top 10 or so lines of my code:

<?php
$url = getenv(HTTP_HOST);
if ( stristr( $url, "lee.maidstoorder.com" ) ) {
    header( "Location: index.php?site=lee" );
    exit;
}
// check to see if we should display a popup poll
if ( !defined( 'SMARTY_DIR' ) )
        include_once( 'config.php' );

Bunkermaster

i see a new line at start of code, is it in your code? if so remove it. You might want to turn warnings on so you see your error.

smueller72

No - there isn't a new line. Not sure why that appears to be showing in the post. How do I turn warnings on? Like I said I'm not a PHP Coder

Bunkermaster

first line of code, add a

<?
if (headers_sent()){ 
    die ('problem');
}
?>

If you have a "problem" echoes something is just not right

smueller72

Doesn't seem to do anything. I'm still getting the URL redirection error. I'm digging for a solution for that. Any other ideas would be appreciated.

Bunkermaster

ok create a blank php script with just the heade line and the opening/closing tags and a static url for redirect. Let's see what this bugger does when redirecting.

smueller72

Done and I still get the redirection error. Any way to see what is going on as it tries to redirect?

smueller72

Just changed the header code to be a relative url and it worked in the 'blank' script. I put that same bit of code into the original index.php file and I get the redirect error again.

Here is the entire script - just in case I'm missing something later on in the code

<?php
$url = getenv(HTTP_HOST);
if ( stristr( $url, "lee.maidstoorder.com" ) ) {
   header( "Location:/index.php?site=lee" );
        exit;
}
// check to see if we should display a popup poll
if ( !defined( 'SMARTY_DIR' ) )
        include_once( 'config.php' );
// get a list of all active polls

$page_id = intval( $_GET['page_id'] );
$form_id = intval( $_GET['form_id'] );

displayPolls();

// if no page or form is specified, then get the default page or form

if ( !$page_id && !$form_id ) {

    // update the site counter

    $siteInfo = $db->getRow( 'select * from ' . SITES_TABLE . " where site_key = '$site'" );

    $siteCounter = 1 + $siteInfo[counter];

    $db->query( 'update ' . SITES_TABLE . " set counter = '$siteCounter' where site_key = '$site' limit 1" );

    if ( $siteInfo[default_resource_type] == 'page' ) {
            $page_id = $siteInfo[default_resource_id];
    }
    else if ( $siteInfo[default_resource_type] == 'form' ) {
            header( 'Location:getForm.php?' . 'form_id=' . $siteInfo[default_resource_id] );
            exit;
    }
    else if ( $siteInfo[default_resource_type] == 'module' ) {

            // get the name of the desired module
            $moduleName = $db->getOne( 'select module_key from ' . MODULES_TABLE . " where id = '$siteInfo[default_resource_id]'" );

            // presumes that the directory that the module is installed in = the module name
            header( 'Location:' . MODULES_DIR . '/' . $moduleName . '/index.php' );
            exit;
    }
    else {
            $page_id = $db->getOne( 'select min(id) from ' . PAGES_TABLE . " where site_key = '$site'" );
    }
}

// get the page name for the <title> tag

$pageInfo = $db->getRow( 'select title, skin_id, counter from ' . PAGES_TABLE . " where id = '$page_id' and site_key = '$site'" );

$t->assign( 'title', $pageInfo[title] );

// load the skin for this page, if a skin has been associated with it

// if we're previewing a skin, then use the $_GET['preview_skin'] value instead

if ( $pageInfo[skin_id] ) {

    // 'settings' is the current settings that we have assigned to the template
    // the skin loader may override those settings, and re-assign to the template, $t

    // set image caching to ensure that we use the correct skin images
    // $c is a class Cacher object which is set in init.php

    $c->_skin = $pageInfo[skin_id];

    $skin->load( $pageInfo[skin_id], $t->get_template_vars( 'settings' ), $t, SETTINGS_TABLE );

    // load this skin's style settings

    $skin->load( $pageInfo[skin_id], $t->get_template_vars( 'cssStyles' ), $t, STYLES_TABLE );

    $stylesArray = $t->get_template_vars( 'cssStyles' );
}

$data = $db->getAll( "select * from " . SECTIONS_TABLE . " where page_id = '$page_id' and site_key = '$site' order by _order" );

// massage the data a bit to account for bulleted lists, etc.

$data = applyFormat( $data );

// update the counter for this page

$newCount = $pageInfo[counter] + 1;

$db->query( 'update ' . PAGES_TABLE . " set counter = '$newCount' where id = '$page_id' and site_key = '$site'" );

// fetch all data for this page
$t->assign( 'data', $data );

// if this page is the logout page, then also terminate the session
// HOWEVER: do not logout if we are simply previewing a skin!!

$inTepmplate = isInTemplate( 'page', $page_id );

if ( $page_id == $siteData[logout_page_id] ) {
        $s->end( $_REQUEST['PHPSESSID'] );
}

if ( $poll ) {
        $t->display( 'popupHeader.tpl' );
        $t->display( 'pages/index.tpl' );
        $t->display( 'popupFooter.tpl' );
}
else {

    $t->assign( 'bodyTemplate', 'pages/index.tpl' );
$t->display( $templateName );

}

$db->disconnect();
?>

Bunkermaster

<?php 
header('Location: http://www.google.com/'); 
?>

try this and tell me what happens.

Bunkermaster

try a space after :
ignore the parser error in the code above

smueller72

Redirect to google successful.

smueller72

Ok - I put the header redirect into my original code and it successfully redirected to Google. When I put my redirect back in it doesn't work. Here's what I'm guessing is the problem - this redirect is actually redirecting to itself - so we have a circular reference of sorts. If you look further in the code of the entire script there is a db select that determines what pages are displayed based upon the sitekey that was sent in. Would pulling the redirect out into a separate script work? Or is there a bit of code that I could add to the existing that might resolve this? This is just a guess as to what is going on.

Bunkermaster

ok, what are you trying to do here? maybe we can do this in an easier way 🙂
(if it's just a loop add a &redirect=1 to url and if redirect=1 don't redirect 😛)