[Resolved] how do I pass a variable in a hidden field

ejwf

Hello
I am trying to pass a couple of values from one page to another using hidden fields in a form but getting nowhere - can anyone see where I am going wrong - thanks
$body is the output from an If/Else statement
$Name comes from a user input in a form on a previous page as $Name = $_POST['name'];
code I have so far

 
<input type="hidden" name="name" value="<?php echo $Name; ?>" >
<input type="hidden" name="body" value="<?php echo $body; ?>" >

bubblenut

I'd suggest [man]urlencode[/man]ing them before echoing them out incase there are unexpected characters there.

Bunkermaster

show us the output code

ejwf

all the code is

$Name = $_POST['firstname'];

if (!isset($_POST['submit'])) 
{     

$answers = array( 
        1 => 'false', 
        2 => 'false', 
        3 => 'false',
		4 => 'false',
		5 => 'false',
		6 => 'false',
		7 => 'false', 
		8 => 'false',	
		9 => 'false',
		10 => 'false',
		11 => 'false',
		12 => 'false'
        ); 

    echo "<br><br>Thank You $Name, <br>Here is the feedback on your assessment:<br><br>"; 

    $i = 0; 
    foreach ($answers as $key => $value) 
    { 
       if ($value == $_POST['q'][$key]) {$i++;} 
    } 
        echo '<br>';          
    echo '<br>You got ' . $i . ' out of ' . count($answers) . ' correct. <br><br>';  
}

IF ($value != $_POST['q'][1])
{$body .= "  <br><br>
 Question 1 The right answer was False. <br>A good leader etc.etc. ";}
ELSE
{$body .= "  <br><br>
 Question 1 - You got this correct.  A good leader etc.etc.<br><br> ";}


IF ($value != $_POST['q'][2])
{$body .= "  <br><br>
 Question 2 The right answer was False. <br>The person in charge of a unit etc.etc.<br><br> ";}
ELSE
{$body .= "  <br><br>
 Question 2 - You got this correct.  The person in charge of a unit etc.etc.<br><br> ";}


IF ($value != $_POST['q'][3])
{$body .= "  <br><br>
 Question 3 etc. .<br><br>  ";}
ELSE
{$body .= "  <br><br>
  Question 3 - Yo
etc..<br><br> ";}

// and so on for 12 questions

echo $body;


echo '<form name="leadership" method="post" action="leadership_email.php">
          <table width="100%" border="0" cellspacing="0" cellpadding="5">
            <tr bgcolor="#FFEFE8" valign="top"> 
              <td width="13%"><br>
                E-Mail:</td>
              <td colspan="2"> 
                <p><b> 
                  <input type="text" name="email" size="40">
                  <br>
                  If you would like one of our team to assess this information 
                  in more detail,<br>
                  and e-mail you with some recomendations, then please fill in 
                  your e-mail address here.<br>
                  </b>All your information is treated in the strictest of confidence, 
                  your e-mail address is held only by <br>
                  us, and will not be passed on to any 
                  other party. 
                  <input type="hidden" name="name" value="<?php echo $Name; ?>" >
				  <input type="hidden" name="body" value="{$body}">
                </p>
                <p>
                  <input type="submit" name="Submit" value="Submit">
                </p>
              </td>
            </tr> </table></form>';

Bunkermaster

<?
//...
echo '<form name="leadership" method="post" action="leadership_email.php">
          <table width="100%" border="0" cellspacing="0" cellpadding="5">
            <tr bgcolor="#FFEFE8" valign="top"> 
              <td width="13%"><br>
                E-Mail:</td>
              <td colspan="2"> 
                <p><b> 
                  <input type="text" name="email" size="40">
                  <br>
                  If you would like one of our team to assess this information 
                  in more detail,<br>
                  and e-mail you with some recomendations, then please fill in 
                  your e-mail address here.<br>
                  </b>All your information is treated in the strictest of confidence, 
                  your e-mail address is held only by <br>
                  us, and will not be passed on to any 
                  other party. 
                  <input type="hidden" name="name" value="'.$Name.'" >
				  <input type="hidden" name="body" value="'.$body.'">
                </p>
                <p>
                  <input type="submit" name="Submit" value="Submit">
                </p>
              </td>
            </tr> </table></form>';
?>

Single quotes... can't include variables or reopen PHP tags in them 🙂

paulnaj

You are echoing an 'echo' statement like ...

echo '<?php echo $Name ?>';

Try doing what you did for the $body variable ...

echo '<form name="leadership" method="post" action="leadership_email.php"> 
...
                  <input type="hidden" name="name" value="$Name"> 
...
            </tr> </table></form>';

Paul.

Bunkermaster

Originally posted by paulnaj
You are echoing an 'echo' statement like ...

echo '<?php echo $Name ?>';

Try doing what you did for the $body variable ...
echo '<form name="leadership" method="post" action="leadership_email.php"> 
...
                  <input type="hidden" name="name" value="$Name"> 
...
            </tr> </table></form>'; 
Paul. [/B]

^ can't work

<?
$bleh = 'test';
echo '$bleh';
?>

Will echo

$bleh

<?
$bleh = 'test';
echo "$bleh";
?>

Will echo

test

ejwf

thanks for all your suggestions but it still isn't working...

I am testing the variables, by echoing them out on the page that generates the e-mail, but nothing comes out ...

back to the beginning, can anyone make any suggstions how to make this work - thanks

Bunkermaster

<pre><?
print_r( $_POST );
?></pre>

paste what you see.

ejwf

thanks
I've done the print_r( $POST );
The output was what it should be, I just need to format the e-mail so that it actually echo's all the variables in the e-mail - code I have got is

$name = $_POST['name'];
$email = $_POST['email'];
$body = $_POST['body'];

$text = 'The following person has completed the Leadership Assessment:
Name = $name
E-mail = $email

Their results were as follows

$body';


mail ("a@b.com", "Assessment Feedback", $text);

echo '<br><br><br><br>Thank You, a copy of your Assessment Results has been received by us.<br><br>
One of your team will contact you via the e-mail address you specified to make further recomendations .<br><br>';

Bunkermaster

same problem as before, you use single quotes and try to include variables... use doublequotes and you're out of the woods

paulnaj

Bunker, thanks for pointing out my glitch.

I gotta say, I never embed variables myself ... always do something like ...

echo 'My name is '.$name;

... it's always easier to read, easier to debug, and ever so slightly quicker.

The best thing about using single-quotes is when echo-ing HTML with it's double-quoted attributes.

Paulo.

ejwf

thanks
all sorted now
I just need to remember to engage the brain before typing next time !!