OOP DB sees password: NO

[Kudose]

Hello all. I all but copied the majority of this scipt to help me learn OOP.

My problem is that I get errors stating that I cannot connect to the database using no password. I am including the variables, why is it not picking them up?

TIA.

<?php
class dbConnect {
	var $dbLoc = "localhost";
	var $dbUser = "xxxxxx";
	var $dbPass = "xxxxxx";
	var $dbName = "xxxxxx";
	var $connection;
	var $result;
	var $items = array();
	var $rowCount = 0;
	var $serverVer;
	var $protoVer;

function dbConnect(){
	$this->connection = $this->connect();
}

function connect(){
	if(mysql_connect($this->$dbLoc, $this->$dbUser, $this->$dbPass, $this->$dbName)){
		$this->connection = mysql_connect($this->$dbLoc, $this->$dbUser, $this->$dbPass, $this->$dbName);
		return $this->connection;
	} else {
		return mysql_error();
	}
}

function doQuery($sql){
	if(!mysql_query($this->$sql)){
		return mysql_error();
	} else {
		return true;
	}
}

function doResultQuery($sql){
	$this->items = "";
	if($sql != ""){
		$this->result = mysql_query($sql, $this->connection);
		$item = array();
		while($item = mysql_fetch_array($this->result)){
			$this->items[] = $item;
		}
		return $this->items;
		mysql_free_result($this->result);
	} else {
		return mysql_error();
	}		
}

function destroyConnection(){
	mysql_close($this->connection);
	return true;
}

function numRows($sql){
	$this->rowCount = mysql_num_rows($sql);
	return $this->rowCount;
}

function mysqlInfo(){
	$this->$serverVer = mysql_get_server_info();
	$this->$protoVer = mysql_get_proto_info();
	return true;
}
}

$myDb = new dbConnect;
$myDb->mysqlInfo();

echo "MySQL Server Version: ".$myDb->serverVer."<br />";
echo "MySQL Protocol Version: ".$myDb->protoVer."<br />";
?>

[tsinka]

Hi,

replace all

$this->$varname
by
$this->varname

Thomas

[Kudose]

snickers

I just did that before I came back to this thread.

It fixed the problem.

Now I have a new one. In object mysqlInfo at the end:

class dbConnect {
	var $dbLoc = "localhost";
	var $dbUser = "xxx_xxx";
	var $dbPass = "xxxxxx";
	var $dbName = "xxx_xxx";
	var $connection;
	var $result;
	var $items = array();
	var $rowCount = 0;
	var $serverInfo = array();

function dbConnect(){
	$this->connection = $this->connect();
}

function connect(){
	if(mysql_connect($this->dbLoc, $this->dbUser, $this->dbPass, $this->dbName)){
		$this->connection = mysql_connect($this->dbLoc, $this->dbUser, $this->dbPass, $this->dbName);
		return $this->connection;
	} else {
		return mysql_error();
	}
}

function doQuery($sql){
	if(!mysql_query($this->$sql)){
		return mysql_error();
	} else {
		return true;
	}
}

function doResultQuery($sql){
	$this->items = "";
	if($sql != ""){
		$this->result = mysql_query($sql, $this->connection);
		$item = array();
		while($item = mysql_fetch_array($this->result)){
			$this->items[] = $item;
		}
		return $this->items;
		mysql_free_result($this->result);
	} else {
		return mysql_error();
	}		
}

function destroyConnection(){
	mysql_close($this->connection);
	return true;
}

function numRows($sql){
	$this->rowCount = mysql_num_rows($sql, $this->connection);
	return $this->rowCount;
}

function mysqlInfo(){
	$this->serverInfo = "";
	$this->serverInfo[] = mysql_get_server_info($this->connection);
	$this->serverInfo[] = mysql_get_proto_info($this->connection);
	return $this->serverInfo;
}
}

I try to use it by calling this code below:

$array = array();
$myDb = new dbConnect;
$array = $myDb->mysqlInfo();

print_r($array->serverInfo);

echo "MySQL Server Version: ".$array->serverInfo[0]."<br />";
echo "MySQL Protocol Version: ".$array->serverInfo[1]."<br />";

Why do these all come up blank?

TIA.

-Travis

[tsinka]

Put ini_set("error_reporting",E_ALL);

on top of the script you have so far. It should show some warnings.

After that try this:

print_r($array); 

echo "MySQL Server Version: ".$array[0]."<br />"; 
echo "MySQL Protocol Version: ".$array[1]."<br />";

The function returns an array not an object.

Thomas

[Kudose]

Thomas,

I added the ini_set but it didnt really do anything. I dont get any error or warnings.

Other than that, the corrections work and I see what I did wrong now.

Thanks.

🙂