FOpen adding an extra line at end of string?

Scot___SJIRadio

I am having my script import source from a file, and at the end of each string it is inserting a line. (ie) I have a file that looks like this:
John
Marie
Lou

#EOF

And then I want to put each line into an array called $Names[#]... but when I do something like

echo("$name[1] $name[2]");

it returns

"John
Marie"

See what I mean? Here is my code:

$host1 = fopen("$filename", "r");
$hosts = array();
$count2 = 1;
while (!feof ($host1)) {
$line = fgets ($host1, 1024);
$hosts[$count2] = $line;
$count2 = $count2 + $count2;
}
fclose($host1);

richie

It appears you have new line characters at the end of your array values. How about replacing those...

<?php
while(list(,$value) = each($myarray)) {

$value = preg_replace("/\s$/i", "", $value);

$newarray[] = $value;

}
?>

Now you have a new array, $newarray without the carriage returns after each element.

Weedpacket

It's not inserting line breaks; the line breaks are already there in the original file (you didn't say to take themout, after all). Consider using [man]trim[/man]. And while we're on the subject, look up [man]file[/man] as well; using a loop to read the file may not be necessary (although you'll still need one to trim the linebreaks).

Scot___SJIRadio

Thanks so much, but forgive my ignorance. I taught myself what I know in PHP, so I don't understand. Just to make sure I understand:

"/\s$/i" --- Represents a line break?

Also, I am not to familiar with the syntax for the while() function in that context. Can you elaborate on that ?

Gornakle

Originally posted by Scot @ SJIRadio
"/\s$/i" --- Represents a line break?

It will only match the newline character at the end of the line (\s matches whitespace and $ means "at the end"). 🙂

Weedpacket

Originally posted by Gornakle
It will only match the newline character at the end of the line (\s matches whitespace and $ means "at the end"). 🙂

Actually, it will match any single whitespace character at the end.

The /i modifier is redundant, since there are no upper- or lower-case characters involved; it will also fail if the file uses in network or Windows end-of-line conventions, since they use a sequence of two characters to represent the end of a line (\r\n), and this regular expression will only discard the last one.

A corrected regexp would read /\s+$/, but then that would make the whole expression equivalent to [man]rtrim[/man], which is much simpler.