[Resolved] whats wrong with echo?

[goaman]

Lil help pls... whats wrong with this code?

echo '

<input type="checkbox" name="remember"'. if($form->value("remember") != ""){  "checked" }.'>

';

Parse error: parse error, unexpected T_IF in index.php 

thanks in advance...

[laserlight]

An if conditional cannot be placed within an echo construct.

[goaman]

Originally posted by laserlight
An if conditional cannot be placed within an echo construct.

oh.. thats kinda bad... 🙁

anyway..thanks for your help.. 🙂

[laserlight]

oh.. thats kinda bad...

Not really, just workaround it, e.g.

echo 'foo';
if (some_condition) {
	echo 'bar';
}
echo 'baz';

[goaman]

I'm trying to echo a form if not logged in, please check this..

if($session->logged_in){
   echo "<div align=center>Logged in as <br><b>$session->username</div></b>";
   }
else
   {
   echo '


	        &nbsp;Login: 
            <input name="user" type="text" id="user" style="color: #000000; font-family: Verdana; font-weight: bold; font-size: 10px; background-color: #D8D7F7;" value="" size="10" maxlength="30" align="center"><div align="center"></div>
            &nbsp;Pass:&nbsp; 
            <input name="pass" type="password" id="pass" style="color: #000000; font-family: Verdana; font-weight: bold; font-size: 10px; background-color: #D8D7F7;" value="" size="10" maxlength="30" align="center"><div align="center"> <a href="register.php"> 
              <input name="login" type="image" src="images/register.jpg" width="43" height="15"></a> 
              <input type="hidden" name="sublogin" value="1">
              <input name="login" type="image" src="images/login.jpg" width="43" height="15"></a> 


// problem with this line..
<input type="checkbox" name="remember" if ($form->value("rememberme") != ""){ echo "checked"; }.' >
				</div>
                </font></td>
            </tr>
          </form> '; 

[goaman]

I'm trying to echo a form if not logged in, please check this..

if($session->logged_in){
   echo "<div align=center>Logged in as <br><b>$session->username</div></b>";
   }
else
   {
   echo '


	        &nbsp;Login: 
            <input name="user" type="text" id="user" style="color: #000000; font-family: Verdana; font-weight: bold; font-size: 10px; background-color: #D8D7F7;" value="" size="10" maxlength="30" align="center"><div align="center"></div>
            &nbsp;Pass:&nbsp; 
            <input name="pass" type="password" id="pass" style="color: #000000; font-family: Verdana; font-weight: bold; font-size: 10px; background-color: #D8D7F7;" value="" size="10" maxlength="30" align="center"><div align="center"> <a href="register.php"> 
              <input name="login" type="image" src="images/register.jpg" width="43" height="15"></a> 
              <input type="hidden" name="sublogin" value="1">
              <input name="login" type="image" src="images/login.jpg" width="43" height="15"></a> 


// problem with this line..
<input type="checkbox" name="remember" if ($form->value("rememberme") != ""){ echo "checked"; }.' >
				</div>
                </font></td>
            </tr>
          </form> '; 

Terribly sorry for the Double POST... 🙁

[rockerscc]

do it like this:

if($session->logged_in){
echo "<div align=center>Logged in as <br><b>$session->username</div></b>";
}
else
{
$form_block = "put your html here up to the point you have the if statement";
//make sure you escape your quotes in html with \ before every "

//then do this.

$form_block .= "<input type=\"checkbox\" name=\"remember\"";

if ($form->value("rememberme") != "") {
$form_block .= " value=\"ON\"";
}

$form_block .= "></div>
</font></td>
</tr>
</form>";

print $form_block;
}

[Samg]

You can't have Double Quotes within an echo statement, so add ?> bofore the login form, and add "< ?php" (without the space) after the login form.

<?php 
if($session->logged_in){
   echo "<div align=center>Logged in as <br><b>$session->username</div></b>";
   }
else
   {   ?>

<!-- plain HTML shown if not logged in -->
                   &nbsp;Login:
                <input name="user" type="text" id="user" style="color: #000000; font-family: Verdana; font-weight: bold; font-size: 10px; background-color: #D8D7F7;" value="" size="10" maxlength="30" align="center"><div align="center"></div>
                &nbsp;Pass:&nbsp;
                <input name="pass" type="password" id="pass" style="color: #000000; font-family: Verdana; font-weight: bold; font-size: 10px; background-color: #D8D7F7;" value="" size="10" maxlength="30" align="center"><div align="center"> <a href="register.php">
                  <input name="login" type="image" src="images/register.jpg" width="43" height="15"></a>
                  <input type="hidden" name="sublogin" value="1">
                  <input name="login" type="image" src="images/login.jpg" width="43" height="15"></a>


<input type="checkbox" name="remember" <?if ($form->value("rememberme") != "")>{ echo "checked"; };?>>
                </div>
                </font></td>
            </tr>
          </form> ';
<?
// php continues here...

[paulnaj]

Hi all,

Just to chuck in another option using the tertiary operator ?:

...

<?php
echo ' 

<input type="checkbox" name="remember"'.($form->value("remember") != "")? ' checked': '').'> 

';

?>

Paul 🙂

[Installer]

You can't have Double Quotes within an echo statement...

Why not, pray tell?

[Samg]

Originally posted by Installer
Why not, pray tell?

Sorry, I meant that his echo is messed up, the way it was...

[Installer]

I don't think so. The whole thing was enclosed in single quotes, which makes escaping the double quotes unnecessary (if that's what you meant).

edit: spllng

[goaman]

Originally posted by rockerscc
do it like this:

if($session->logged_in){
echo "<div align=center>Logged in as <br><b>$session->username</div></b>";
}
else
{
$form_block = "put your html here up to the point you have the if statement";
//make sure you escape your quotes in html with \ before every "

//then do this.

$form_block .= "<input type=\"checkbox\" name=\"remember\"";

if ($form->value("rememberme") != "") {
$form_block .= " value=\"ON\"";
}

$form_block .= "></div>
</font></td>
</tr>
</form>";

print $form_block;
}

After some modification this seems to be working as I wanted... thanks guys, I appreciate your help... and BIG thanks to rockerscc 😃