Forum

fowler

Im trying to create a forum using mysql and php. but I get a error message, and I cant really figure out what to make of it, at first I just though I was using the wrong datatype for storage in my mysql database (date vs datetime) but Ived changed that and I still get the same message. Im new to php and would really need a more experienced person to give me a hint. the code that generates the error is as follows:

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<?
include "include/db_connection.php";
$db=@mysql_pconnect($db_HOST,$db_USER,$db_PASS);
@mysql_select_db($db_db) or die("DATABASE ERROR". mysql_error());
?>
</head>

<body>
<?
if(isset($_POST['new']))
{
$date=date("Y-m-d H:i:s");
$sql="INSERT INTO forum(title,name,email,message,date) VALUES ('$title','$name','$email',$message','$date')";
mysql_query($sql) or die ("Fel ".mysql_error());
echo("It has been posted");
}
else
{
?>
<form method="post" action="new.php" name="feed">
Subject:<br>
<input type="text" name="subject"><br>
Name:<br>
<input type="text" name="name"><br>
Email:<br>
<input type="text" name="email"><br>
Message:<br>
<textarea name="message"></textarea><br>
<br><input type="submit" name="new" value="Send"><input type="reset" value="Reset"><br>
</form>
<?
}
?>
</body>
</html>

and the error message:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '2004-11-28 19:53:38')' at line 1

Roger_Ramjet

If this is a direct paste, then you are missing a 'quote' in the sql string:

$sql="INSERT INTO forum(title,name,email,message,date) VALUES ('$title','$name','$email','$message','$date')"; 

//NOT
$sql="INSERT INTO forum(title,name,email,message,date) VALUES ('$title','$name','$email',$message','$date')";

fowler

it helped🙂

fowler

Im in need of help again, Ive looked through this pice of code but I cant find the error. My knowledge of the mysql syntax is limited so any help would be nice.

<body>
<?

$cid=$POST['cid'];
$top=$POST['top'];
$subject=$POST['subject'];
$name=$POST['name'];
$email=$POST['email'];
$message=$POST['message'];

$date=date("Y-m-d H:i:s");

$sql="INSERT INTO forum
(pid,title,name,email,message,date) VALUES ($cid,'$subject','$name','$email','$message','$date')";
mysql_query($sql) or die ("Fel ".mysql_error());
$sql="UPDATE forum SET lastchange='$date',num_change=num_change+1 WHERE cid=$top";
mysql_query($sql) or die ("Fel ".mysql_error());

echo("youranswear has been posted");
?>
<a href="forum.php">Back to forum</a>

</body>
</html>

and the error:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

rockerscc

It's another problem with leaving out '

whenever you are putting varialbes into the sql, you need to use '

check your VALUES() and also
$sql="UPDATE forum SET lastchange='$date',num_change='num_change+1' WHERE cid='$top'";

what is num_change='num_change+1' ? I have never tried to add in a sql statement. Can you do that?

Roger_Ramjet

Originally posted by rockerscc
It's another problem with leaving out '

whenever you are putting varialbes into the sql, you need to use '

check your VALUES() and also
$sql="UPDATE forum SET lastchange='$date',num_change='num_change+1' WHERE cid='$top'";

what is num_change='num_change+1' ? I have never tried to add in a sql statement. Can you do that?

Yes, sql handles maths very well. Syntax needs tweaking though. Strings etc need to be quoted, but column names must not be, and numerals do not need to be quoted either. So:

num_change=num_change + 1 is the correct syntax.