MySQL mysql_fetch_assoc warning

nro

function DB_GetInfo( $table , $id , $field) {
$results = mysql_fetch_assoc($this->DB_Query('SELECT '.$field.' FROM `'.$table.'` WHERE `id` = \''.$id.'\''));
if($field == '*')
	return $results;
else
	return $results[$field];
}

My problem:
I get the following warning and can't continue with my code:
Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /home/netvir/public_html/mike/cms/pwrful/CMS_Database.php on line 85

The function DB_Query within the same class just simply queries the database. I have tried replacing "$this->DB_Query" with "mysql_query" and get the same problem.

Any suggestions?
Thanks

paulnaj

Hi nro,

Here's a tip ... if you have a line of code that could be written as two lines, do yourself a favour and write it over the two lines.

So, I would first change ...

$results = mysql_fetch_assoc($this->DB_Query('SELECT '.$field.' FROM '.$table.' WHERE id = ''.$id.'''));

... to ...

$sql = 'SELECT '.$field.' FROM '.$table.' WHERE id = \''.$id.'\'';
// Only for debugging
echo $sql;
$query = $this->DB_Query($sql);
$results = mysql_fetch_assoc($query);

Of course, you can always change it to 'shortcut' code once it's been debugged, if you want, but there is absolutely no reason to do so.

Now, having had the warning 'supplied argument is not a valid MySQL result resource', first thing I'd do is to check that the SQL actually is well-formed. Then I'd look up what DB_Query() actually returns, and how you should use that return. If it returns the same sort of object that mysql_query() returns, then check the manual.

See how you get on.

Paul.

nro

I have broken it down as simple as possible and used the mysql_query() function instead of DB_Query. I also use the same sort of code in different sections of the class but it doesn't seem to be working here. I'm stuck.

Thanks

tsinka

Hi,

post the complete code (as attachment).

Thomas

nro

Files attached

Warning on line 89.

Warning: mysql_query(): supplied argument is not a valid MySQL-Link resource in /home/netvir/public_html/mike/cms/pwrful/CMS_Database.php on line 89

tsinka

Hi,

I'd suggest to get another DB class or to use PEAR::ADODB. The class needs some tweaking.

Try to change the DB_Query function to:

    function DB_Query($query) {
        if( ! $this->DB_IsConnected() ) print 'Not connected, can\'t query database';
          return false;
        else {
            return mysql_query($query,$this->DB_Link);
        }
    }

That's some kind of a hack but at least you need to return the result identifier (and e.g. false if no connection to the database exists).

So in the PHP you need to check first if the returned result resource is valid.

But the class needs some tweaking.

Thomas