OOP - Getting no results at all.

Kudose

Hello all.

Here I have a class that is supposed to return my query back into a variable (array if needed). My problem is that it isnt working. I get no output when trying to call data. Any help would be great.

<?php
ini_set("error_reporting", "E_ALL");

class dbConnect {
	var $dbLoc = "localhost";
	var $dbUser = "xxx_xxx";
	var $dbPass = "xxx";
	var $dbName = "xxx_xxx";
	var $connection;
	var $conn_temp;
	var $result;
	var $items = array();
	var $rowCount = 0;
	var $serverInfo = array();

function dbConnect(){
	$this->connection = $this->connect();
}

function connect(){
	if(mysql_connect($this->dbLoc, $this->dbUser, $this->dbPass)){
		$this->conn_temp = mysql_connect($this->dbLoc, $this->dbUser, $this->dbPass, $this->dbName);
		$this->connection = mysql_select_db($this->dbName, $this->conn_temp);
		return $this->connection;
	} else {
		return mysql_error();
	}
}

function doQuery($sql){
	if(!mysql_query($this->$sql)){
		return mysql_error();
	} else {
		return true;
	}
}

function doResultQuery($sql){
	$this->items = "";
	if($sql != ""){
		$this->result = mysql_query($sql, $this->connection);
		$item = array();
		while($item = mysql_fetch_array($this->result)){
			$this->items[] = $item;
		}
		return $this->items;
		mysql_free_result($this->result);
	} else {
		return mysql_error();
	}		
}

function destroyConnection(){
	mysql_close($this->connection);
	return true;
}

function numRows($sql){
	$this->rowCount = mysql_num_rows($sql, $this->connection);
	return $this->rowCount;
}
}



include('classes.inc.php');

$myDb = new dbConnect;

$site_info = $myDb->doResultQuery("SELECT * FROM config");

//I get no data output in the following
//lines.  Not even Array letting me know 
//something is there.  No errors either.
?>

<html>
<head>
	<title><?php echo $site_info->title; ?></title>
</head>
<body>
The title of the page is: <?php echo $site_info; ?>
</body>
</html>

Thanks in advance!

Shrike

Your not returning an object, but an array. So you'd need to reference it as such ($site_info['title'] perhaps). A few other things - there's little point returning mysql_error() if the variable $sql is an empty string, since that won't ever generate a mysql error. Secondly, once you have returned something from a function, processing ends for that function. So the mysql_free_result() call won't ever be done.

Kudose

Good call on the extra info. I will try to call it out as an array. Here is where I found the info I am trying to learn from.

http://www.gurusnetwork.com/tutorial/oop_php/3/

Kudose

I implemented your reccommendations and am learning more, but still am not achieving the desired result.

In this script I still get 0 variable output, including the print_r

<?php
class dbConnect {
	var $dbLoc = "localhost";
	var $dbUser = "xxx_xxx";
	var $dbPass = "xxx";
	var $dbName = "xxx_xxx";
	var $connection;
	var $conn_temp;
	var $result;
	var $items = array();
	var $rowCount = 0;
	var $serverInfo = array();

function dbConnect(){
	$this->connection = $this->connect();
}

function connect(){
	if(mysql_connect($this->dbLoc, $this->dbUser, $this->dbPass)){
		$this->conn_temp = mysql_connect($this->dbLoc, $this->dbUser, $this->dbPass, $this->dbName);
		$this->connection = mysql_select_db($this->dbName, $this->conn_temp);
		return $this->connection;
	} else {
		return mysql_error();
	}
}

function doQuery($sql){
	if(!mysql_query($this->$sql)){
		return mysql_error();
	} else {
		return true;
	}
}

function doResultQuery($sql){
	$this->items = "";
	if($this->result = mysql_query($sql, $this->connection)){
		$item = array();
		while($item = mysql_fetch_array($this->result)){
			$this->items[] = $item;
		}
		return $this->items;
	} else {
		return mysql_error();
	}		
}

function destroyConnection(){
	mysql_close($this->connection);
	return true;
}

function numRows($sql){
	$this->rowCount = mysql_num_rows($sql, $this->connection);
	return $this->rowCount;
}

function mysqlInfo(){
	$this->serverInfo = "";
	$this->serverInfo[] = mysql_get_server_info($this->connection);
	$this->serverInfo[] = mysql_get_proto_info($this->connection);
	return $this->serverInfo;
}
}


$myDb = new dbConnect;

$site_info = $myDb->doResultQuery("SELECT * FROM config");

print_r($site_info);
?>

<html>
<head>
	<title><?php echo $site_info['title']; ?></title>
</head>
<body>
The title of the page is: <?php echo $site_info['title']; ?>
</body>
</html>

Thanks for your advice thus far!

PHPMagician

Doing:

echo $site_info['title'];

Will only display the word 'Array' if the function worked, or nothing as is the case. This is because you are returning an array, of an array. Therefore, something like this should work:

echo $site_info[0]['title'];

However, if you are getting no return obviously an error is present. I do know that it is pointless doing:

$this->item = "";

Which you do on the first line of the method. You are basically casting an array as a string. However, I would assume PHP would cast the string to an array upon appending an element, so that should not really cause a problem.

From my quick glance, I cannot really see the problem at hand which would cause nothing to be returned besides the possibility that config has no rows - which I assume is not the case.

Kudose

This is so frustrating. I see where you are coming from and how your right. From what I can see it should work implementing your code, but it doesn't.

I guess I will just have to scrap it and start over. That generally works.

Thanks anyways.