Handling Notice Errors in eval() statements

RossC0

Hi,

I have some code that goes through a generic action dispatcher, which uses eval() statements.

I get an error from my statement which is evaluated on the first loop, which is caused by looking at the previous index:

$uniqueKeys[$uniqueKeysKey-1]

Is there a way to stop the eval() statement giving a notice error?

I tried @eval(...) but the error still went through my custom error handler.

Does @eval() stop errors? If so can you tell if the @ syntax has been used from the $error_context ?

dalecosp

That's a good ??, and one that shouldn't sit at the bottom of the list unanswered.

Not that I exactly know the answer, unfortunately.

What happens if you set error_reporting to zero in the eval()'ed code?

rehfeld

turning off error_reporting is NEVER the way to fix an error.

fix the problem, dont cover it up


if (isSet($uniqueKeys[$uniqueKeysKey-1])) {
    // use it however you are using it
}

the problem is still in the way you are looping. you usually should not have to do that. if you post more of your code me or someone else could show you a more elegant way to do it.

RossC0

Hi thanks for the replies,

The problem I have is putting an if statement into the eval() code - it doesn't seem to like it (I get a parse error when I hit a ; after the first if statement) Am I doing this wrong?

The reason why I'm passing $uniqueKeys[$uniqueKeysKey-1] to a function along with $uniqueKeys[$uniqueKeysKey] is so I can determine if I need to run a query (and therefore save processing time).

I actually handle the errors with a custom error handler, so I can handle eval() notice errors easily enough as the error_file code for eval() statements doesn't follow the normal error syntax and has the file, line number and a message saying it was eval()'d code.

I was just wondering if I can identify errors that use the error control @

RossC0

OK looking into it further, it seems to be the custom error handler that doesn't use the @ error controller!

Heres my test code, the logic is:
1) create an array to loop
2) create statements for evaulation, that call a basic function.
3) Evaluate the statements.

First with the built in error handler, then with a custom error handler.

<?php
// Set report all errors
error_reporting(E_ALL);
// Create an array to test.
$test = array('ten', 'twenty', 'thirty', 'forty');
// Create an evaluate term.
$evalTerm = 'tester($test[$key], $test[$key-1]);';

// A function that tests the evaluate term.
function runTest($test, $evalTerm){
	foreach ($test as $key => $value){
		@eval($evalTerm);
	}
}


// A function that outputs the variables.
function tester($arrayNow = NULL, $arrayBefore = NULL){
	echo($arrayNow.' : '.$arrayBefore.'<br />');
}

// A Custom Error Handler (outputs the error message).
function ERROR_HANDLER($error_type, $error_msg, $error_file, $error_line, $error_context)
{

$a_ErrorTypes = array(E_ERROR 			=>'E_ERROR',		// used to get a word-based error code
                      E_WARNING 		=>'E_WARNING',		// instead of the number that will be
                      E_NOTICE 			=>'E_NOTICE',		// passed to this function
					  E_USER_ERROR 		=>'E_USER_ERROR',
                      E_USER_WARNING 	=>'E_USER_WARNING',
                      E_USER_NOTICE	 	=>'E_USER_NOTICE',
                      );

echo('<br />==========  ERROR ==========<br /> ');
echo('<b>Type: </b>'.$a_ErrorTypes[$error_type].' :<b> Message:</b> '.$error_msg.' : <b> File:</b> '.$error_file.' : <b> Line:</b> '.$error_line.'<br />');
print_r($error_context);
echo('<br />======== ERROR END ======== <br />');
}

echo('<hr />');
// OK RUN THE TEST WITH THE NORMAL HANDLER:
echo(' ======= RUNNING NORMAL ERROR HANDLER ======== <br />');
runTest($test,$evalTerm);
echo('==================== DONE =====================');
echo('<hr />');

// NOW WITH A CUSTOM ERROR HANDLER:
set_error_handler('ERROR_HANDLER');

echo(' ======= RUNNING CUSTOM ERROR HANDLER ======== <br />');
runTest($test,$evalTerm);
echo('==================== DONE =====================');
echo('<hr />');
?>

My problem is I can't identfy in a custom error the @ control error prefix!

RossC0

OK Found it!

I need if(error_reporting() != 0){ ... } in my error handler - its in the php manual under user notes :o