Form Error checking

duke

I am having a problem if anyone can help.

I hardly no any php --thats the problem , but seriously.
I have a form that I am trying toi send to email.

the form works fine and sends all the fields that are in the form .

However , it sends all the fields regardless of what they are and I need to error check the fields .

The form can be found here : www.homequotes123.biz

I was doing this for a friend and the server that their site is on is PHP 4
---I know some asp --but not php,

If anyone can PLEASE take a look at the form and tell me how I would error check in the php page that the form posts to I would greatly appreciate it.

I know this is probably basic and I have searched then net for plent of "free" scripts that claim to be easy to use "form to email" and "processor" scripts that either I can not get to work --or --- particularly , don't work on the php4 version of the server the site is on .

I just need to make all fields required (with the exception of one,'work phone')

Please anyone feel free to email me , if I can offer anything in return for your help --I will.

thanks

vaaaska

This is basically about email validation but the concepts are there...I think it will be useful. If you know ASP then I think you can take what you have here and go the rest of the distannce. Good luck...v

http://codewalkers.com/tutorials/73/1.html

kingbear

Basically what you want to do is iterate through all the fields after you POST and check that they are not empty .... here's some pseudo code:

foreach($_POST as $index=>$value) {
if(!$value && ($index != "workphone")) {
//then there's a missing field
}
}

duke

This is very basic what I have now , it look like this

<?
$MailToAddress = "example@example.com";
$MailSubject = "Application";
if (!$MailFromAddress) {
$MailFromAddress = "applicant@homequotes123.biz";
}
$Header = "";
$Footer = "";
?>
<html><title>Thank You - Application Sent</title>
<body bgcolor="#FFFFFF">
<center>
Thank You! 
Your application has been delivered.
One of our represenatives will contact you shortly at the email address
that you provided.
</center>

<?
if (!is_array($HTTP_POST_VARS))
return;
reset($HTTP_POST_VARS);
while(list($key, $val) = each($HTTP_POST_VARS)) {
$GLOBALS[$key] = $val;
$val=stripslashes($val);
$Message .= "$key = $val\n";
}

if ($Header) {
$Message = $Header."\n\n".$Message;
}

if ($Footer) {
$Message .= "\n\n".$Footer;
}

mail( "$MailToAddress", "$MailSubject", "$Message", "From: $MailFromAddress");
?>
 
 
</body>
</html>

I thank you for your help ---but I am still very unclear as to how to correctly edit or write the syntax that you provided.

can I keep what I currently have and just edit it?

How to I set it up to check "if" validation and if not entered, display a messgage for that field.

(i.e. - "your your email address is missing", another example, "your address is missing" )

kingbear

At the very top of the script you should have your error checking --


//Go through the POST array and check that all fields are set

foreach($_POST as $key=>$value) {
//See if the value is set ; if not then return to the form page with the error set to the key
if(!$value) {
//The value is not set so return to the referring page
header("Location: whatever.php?error=$key");
}
}

If there's an error you are sent back to the form page (whatever.php) and you should echo out something like:

echo("The field " . $_GET["error"] . " is required");

Then assuming that the form was valid and no error was seen the body of the email is constructed like this:


$body = "";

foreach($_POST as $key=>$value) {

$body .= "$key = $value";

}

mail($to, $subject, $body);

duke

thanks for your reply --

it is extremely appreciated.

It make sense to me --when I read it ..

but I am still having a difficult time with the syntax

everytime I take what you supplied and try to use it my code all ready ..

the code I have "dies" --becomes "uncolored" meaning that there is an error somwhere.

you stated that I would insert and the very top of my script
--does that mean above the <? symbol????

or does it go inside underneath that?

the script I provided above is exactly "as is"

can you just copy and past what you provided to show exactly where it goes?

I am very unfamiliar --not trying to frustrate anyone as much as I already am ..--just trying to get it working and I have already attempted many solutions before posting here.

so please be patient with me --I am learning (apparently not fast enough)

kingbear

Try this (replace whatever.php with the name of the script the form is on):

<?
foreach($_POST as $key=>$value) {
if(!$value) {
header("Location: whatever.php?error=$key");
}
}

$MailToAddress = "example@example.com";
$MailSubject = "Application";
if (!$MailFromAddress) {
$MailFromAddress = "applicant@homequotes123.biz";
}
$Header = "";
$Footer = "";
?>
<html><title>Thank You - Application Sent</title>
<body bgcolor="#FFFFFF">
<center>
Thank You! 
Your application has been delivered.
One of our represenatives will contact you shortly at the email address
that you provided.
</center>

if ($Header) {
$Message = $Header."\n\n";
}

foreach($_POST as $key=>$value) {
$Message .= "$key = $value\n";
}

if ($Footer) {
$Message .= "\n\n".$Footer;
}

mail( "$MailToAddress", "$MailSubject", "$Message", "From: $MailFromAddress");
?>
 
 
</body>
</html>

duke

no go.....

I copy and pasted what you supplied --and changed the name ' whaterver.php' --- to name of the form page ...

(which is index.html)

and it still doesnt work .

I get this message

Warning: Invalid argument supplied for foreach() in /nfs/cust/3/80/65/556083/web/email2.php on line 2

NOTE:

once I copy and paste what you supplied in "ULTRADEV"

the text again becomes "un-color coded" --which usually indicates an incorrect syntax

would that be correct to say?

when all of the script is correct in the file it is color coded (blue)

---still having problems---

duke

SORRY!!

I stand corrected ...

appers I am getting the email ..

but I do get the error message.

why is that?

Warning: Invalid argument supplied for foreach() in /nfs/cust/3/80/65/556083/web/email2.php on line 2

It does not appear to be doing anything different than it dit before ..

(i.e. checking errors) --still sends all fields no matter what.

kingbear

try replacing $_POST with $HTTP_POST_VARS

duke

I tried making the change that you stated.

however when I use that -- $HTTP_POST_VARS

I dont get the error I was getting before --but the page does not diplay the "thank you page"

It looks as if post when you click "submit" and reads the in the url the name of the page that it is supposed to post to (email2.php)

but it still displays the same application page.

when you then click submit again in then displays the "thank you page"

still may problems here.

can anyone please help with the above "code" that I provided of what I have already to send my html form to a .php file that will error check that all fields except for one are "required" and validate email

the form I have already post all fields no matter what is inserted and it does currently send it to my email .

However as inexperienced as I am with php ---if it has to be re-written to do so , i am not wrting it correctly and having a hard time understanding the correct syntax and what exactly needs to be modified.

again the form can be found here http://www.homequotes123.biz/index3.html

duke

Found an excellent tutorial on this subject ---but after repeated attempts...I am still doind this incorrectly

any help?

Here is the tutorial

http://www.php-mysql-tutorial.com/form-validation-with-php.php