need help for SEARCH code

nemati_mojgan

Hi everybody,
I have a problem with search code. I have the fellow code which has to search my database, but when I execute that, nothing happened, please help me.

<?php
$searchstring=$_GET['searchstring'];
if ($searchstring)
{
$sql=" select * from searchstatic where $searchtype like '%$searchstring%' order by title ASC";
$result=mysql_query($sql,$db) ;
echo "<TABLE BORDER=2>" ;
echo "<TR><TD><B>Full Name</B><TD><B>Nick Name</B><TD>Options<B></B></TR>" ;
while ($myrow=mysql_fetch_array($result))
{
echo "<TR><TD>".$myrow["title"]."</td><td>".$myrow["body"]. "</td><td>" .$myrow["pageurl"]. "</td></tr>\n" ;
//echo "<TD><a ref=\"view.php?id=".$myrow["id"]."\" >View</a>" ;
}
echo "</TABLE>" ;
}
else
{
?>
<form method="POST" action="<?php $PHP_SELF ?>">
<table broder="2" cellspacing="2">
<tr><td>Insert your search string here</td>
<td>Search type</td></tr>
<tr>
<td><input type="text" name="searchstring" size="28"></td>

</tr>
</table>
<p><input type="submit" value="Submit" name="B1"><input type="reset" value="Reset"></p>
</form>
<?
}

Thanks in advance

dalecosp

Hi!

My first question is, "where is the variable $db defined?"

It doesn't appear in this script, so unless this is only an excerpt, I wouldn't expect $result to obtain any value from the database query.

That said, if you would allow a little criticism in the form of a suggestion, you could stand to add some error-checking capability to your script. For example:

<?php 
$searchstring=$_GET['searchstring']; 
if ($searchstring) 
{ 
$sql=" select * from searchstatic where $searchtype like '%$searchstring%' order by title ASC"; 
$result=mysql_query($sql,$db) ; 
if (!$result) {
   echo "An error has occurred!  The database query returned empty!";
}

Now, this doesn't necessarily fix your problem, but it's part of debugging: successfully determining *where* to look for your bugs ....

HTH,

zonewatcher

Also, where is $searchtype defined? Your script reads a value from the $_GET array and your form is a POST. What error messages are echoed to the screen?

dalecosp

Originally posted by zonewatcher
Also, where is $searchtype defined? Your script reads a value from the $_GET array and your form is a POST. What error messages are echoed to the screen?

Good catch. If we were frogs, you'd be fatter than me. 😉

nemati_mojgan

Thanks for your guide.
You're right. I wanted to define $db through db_conn() function, but I had forgotten to call that.
I applied that changes, but unfortunately the result is the same as befor. nothing happened when I click the submit. No error, no result.
Thanks again

Originally posted by dalecosp
Hi!

My first question is, "where is the variable $db defined?"

It doesn't appear in this script, so unless this is only an excerpt, I wouldn't expect $result to obtain any value from the database query.

That said, if you would allow a little criticism in the form of a suggestion, you could stand to add some error-checking capability to your script. For example:
<?php 
$searchstring=$_GET['searchstring']; 
if ($searchstring) 
{ 
$sql=" select * from searchstatic where $searchtype like '%$searchstring%' order by title ASC"; 
$result=mysql_query($sql,$db) ; 
if (!$result) {
   echo "An error has occurred!  The database query returned empty!";
}
Now, this doesn't necessarily fix your problem, but it's part of debugging: successfully determining *where* to look for your bugs ....

HTH, [/B]